tree 31b3c19e592b1f2a127d955cdbb09c5073e4eaa7
parent 0e4e31197428a347842d152773b4cace4645ca25
author Joe Wreschnig <joe.wreschnig@gmail.com> 1609356921 +0100
committer GitHub <noreply@github.com> 1609356921 -0600
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJf7NZ5CRBK7hj4Ov3rIwAAdHIIAIE8z3mfY5hCcibmCBHMutY6
 LnW+YZfD4AXyPB1MMrPNz/9q3/rpz+Z0MxVKjj4OqyZYZ2qUVFxMho//FiD8+ikl
 ro6/1ZFBY3Nel2zV1RXQg93JoxwCp+qOwMSfhXUkotsvMgyyGamG3e6Zs7VX0RdX
 dFn84zISIAd5FW97bQkLjfdOXF+iEzek/AaB90DCWDQAef3RzE2YslhZbSkjp/xm
 EggWhQtJr8ujDSgWBhFnZLmmNweF7QNvJiczMGYhXyy0OFo/46tHzz6ArTNhDvwL
 0IaKymcb70nZu3Rs/5SdMVQXFv5mFZIfb7oyy6vy4VJJQpQWET3Vl6jg6g7Ae7s=
 =ljm9
 -----END PGP SIGNATURE-----
 

Use a custom error type for invalid lengths, replacing `fmt.Errorf` (#69)

* Add benchmarks for different kinds of invalid UUIDs

Also add a test case for too-short UUIDs to ensure behavior doesn’t
change.

* Use a custom error type for invalid lengths, replacing `fmt.Errorf`

This significantly improves the speed of failed parses due to wrong
lengths. Previously the `fmt.Errorf` call dominated, making this the
most expensive error and more expensive than successfully parsing:

    BenchmarkParse-4                 29226529        36.1 ns/op
    BenchmarkParseBadLength-4         6923106       174 ns/op
    BenchmarkParseLen32Truncated-4   26641954        38.1 ns/op
    BenchmarkParseLen36Corrupted-4   19405598        59.5 ns/op

When the formatting is not required and done on-demand, the failure per
se is much faster:

    BenchmarkParse-4                 29641700        36.3 ns/op
    BenchmarkParseBadLength-4        58602537        20.0 ns/op
    BenchmarkParseLen32Truncated-4   30664791        43.6 ns/op
    BenchmarkParseLen36Corrupted-4   18882410        61.9 ns/op