tp: delete the legacy PerfettoSqlPreprocessor (#5472)
**Stack:**
1. #5614 — `tp: prep PerfettoSqlParser for a second backend`
2. #5615 — `tp: add syntaqlite-driven macro expansion behind a flag`
3. #5525 — `tp: replace sqlfluff formatter with syntaqlite` (parallel;
based on #5615)
4. #5616 — `tp: route PerfettoSqlParser through syntaqlite macro
expansion`
5. **#5472 — `tp: delete the legacy PerfettoSqlPreprocessor`** ← you are
here
---
Final PR in a 4-PR stack that splits the original "replace the
handrolled preprocessor with syntaqlite" change. With trace_processor
routing through the syntaqlite-driven macro path (see the previous PR in
the stack), the handwritten preprocessor and the
`LegacyImpl`/`constexpr`/`std::optional<>` machinery that gated its
existence have no remaining production callers.
This PR:
* Deletes `src/trace_processor/perfetto_sql/preprocessor/` entirely
(~2.6k lines of generated grammar + handwritten preprocessor +
tests) and drops its `BUILD.gn` / `Android.bp` / `BUILD` references
from the parser, engine, and root `trace_processor` targets.
* Inlines the real `Macro` struct on `PerfettoSqlParser` (was a
`using` alias to the preprocessor type) and drops the parser/engine
includes of the preprocessor header.
* Collapses `PerfettoSqlParser::Impl` from the dual-impl wrapper into
the syntaqlite implementation directly: no more `LegacyImpl`,
`kUseSyntaqliteMacros` / `kUsesSyntaqliteMacros`, `std::optional<>`
slots, or `if constexpr` dispatch.
* Drops the `kBang` token alias added to `SqliteTokenizer` when the
legacy preprocessor needed to recognise `!` as a macro indicator.
* Drops the `kUsesSyntaqliteMacros` test gate and the
`ExpandsTokenApplyIntrinsic` skip-on-legacy guard.
* Refreshes the engine.cc architecture comment to drop the
preprocessor layer from the diagram.
The earlier PRs in the stack:
1. `tp: prep PerfettoSqlParser for a second backend` — pure refactor.
2. `tp: add syntaqlite-driven macro expansion behind a flag` — adds
`SyntaqliteMacroImpl` + `intrinsic_macro_expansion.{h,cc}` +
`SqlSource::FromMacroExpansion` + the syntaqlite library bump,
behind `kUsesSyntaqliteMacros = false`.
3. `tp: route PerfettoSqlParser through syntaqlite macro expansion` —
flips the flag.Perfetto is an open-source suite of SDKs, daemons and tools which use tracing to help developers understand the behaviour of complex systems and root-cause functional and performance issues on client and embedded systems.
It is a production-grade tool that is the default tracing system for the Android operating system and the Chromium browser.
Perfetto is not a single tool, but a collection of components that work together:
Perfetto was designed to be a versatile and powerful tracing system for a wide range of use cases.
ftrace, allowing you to visualize scheduling, syscalls, interrupts, and custom kernel tracepoints on a timeline.chrome://tracing. Use it to debug and root-cause issues in the browser, V8, and Blink.We‘ve designed our documentation to guide you to the right information as quickly as possible, whether you’re a newcomer to performance analysis or an experienced developer.
New to tracing? If you're unfamiliar with concepts like tracing and profiling, start here:
Ready to dive in? Our “Getting Started” guide is the main entry point for all users. It will help you find the right tutorials and documentation for your specific needs:
Want the full overview? For a comprehensive look at what Perfetto is, why it's useful, and who uses it, see our main documentation page:
For users interested in the Debian distribution of Perfetto, the official source of truth and packaging efforts are maintained at Debian Perfetto Salsa Repository
Have questions? Need help?
We follow Google's Open Source Community Guidelines.