runtime: TextOutputOptions::WithNumericBase should take a uint8_t
The `TextOutputOptions::numeric_base_` field is stored as a `uint8_t`.
However, `TextOutputOptions::WithNumericBase` takes an `int` parameter.
Albeit unlikely, this allows for some potential data loss since an `int`
on most systems is four bytes whereas a `uint8_t` is only a single byte.
A previous commit (85f3b790) used `static_cast` to remove the
`-Wimplicit-int-conversion` compiler warning. However, we don't actually
need a static cast here. Instead, we should just update the parameter
type to be `uint8_t` since that's the type used in internal storage as
well. It's unlikely that anyone will want a numeric base larger than 255
anyway, but if they do, they should deal with that at the call site
rather than Emboss deciding to eliminate data under the hood.
This change updates `TextOutputOptions::WithNumericBase` to take a
`uint8_t` in as its parameter instead of an `int`.
diff --git a/runtime/cpp/emboss_text_util.h b/runtime/cpp/emboss_text_util.h
index b3daf86..500d828 100644
--- a/runtime/cpp/emboss_text_util.h
+++ b/runtime/cpp/emboss_text_util.h
@@ -67,9 +67,9 @@
return result;
}
- TextOutputOptions WithNumericBase(int new_value) const {
+ TextOutputOptions WithNumericBase(uint8_t new_value) const {
TextOutputOptions result = *this;
- result.numeric_base_ = static_cast</**/ ::std::uint8_t>(new_value);
+ result.numeric_base_ = new_value;
return result;
}
