tree ff9f0b0ccd69d8127487e3086091abb900b074ef
parent 5bceb69540612522dda873bd734395b4a43b1d41
author Brad Fitzpatrick <bradfitz@golang.org> 1533657548 +0000
committer Marcel van Lohuizen <mpvl@golang.org> 1533915355 +0000

unicode/norm: move sync.Once check out of loop

Follow-up to CL 127926.

The recompMap map is only used by func combine, which only has one
caller. Move the sync.Once.Do call that populates the map out of func
combine up to its sole caller.

I wasn't actually able to measure a difference with this, but
it seems better to do one-time work outside of a loop.

And I verified that combine is still inlined, even with the nil check+panic.

./composition.go:501:24: inlining call to combine

Change-Id: I6929af1de5f068051ef00cf0938b880ff87e1ce4
Reviewed-on: https://go-review.googlesource.com/128575
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Kevin Burke <kev@inburke.com>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>