tree ef8dd962c1de28efad42e246e8fdfee001598c6b
parent d0dc0def2e8a155b703a9b4966ca8f803ce06308
author Damien Neil <neild@users.noreply.github.com> 1520903239 -0700
committer GitHub <noreply@github.com> 1520903239 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJapyRHCRBK7hj4Ov3rIwAAdHIIACyECk6q8bHhJyZ49RohiF+d
 OiwQpg6YnHwiNnEV8/P1gYA1dQoNbjWobws5xwqjQywNwVwjEnTMqGPg+YcHbwI4
 i1TD9qq5F+3xH3vVtE5Gk05MtjB3lsVgN9vk53prIaez18ddWKzYWrU+i31edLLH
 pxayiZrd4IwB2/xgL0YoS+utEbWD4mdvMGmoX0or08eZtNTSulbcYXogbOSrsxmP
 XHpuxpng80zSv4TnQlo6ll6OQPbGfKNzHEaJViFYiOjtt2ZppMU3z9UF2YAG7TL5
 7EKyUGv0qE6KuFftBGeKk9MkQu+ZSNoJWKUEMGHNrPB6kU1Ma2+Ua+P9cNcZWjQ=
 =Qeoy
 -----END PGP SIGNATURE-----
 

protoc-gen-go: fix generation of public imports (#549)

(*Generator).DefaultPackageName returns either a qualified ("pkg.name") or
unqualified ("name") name.

Prior to commit 9d4962b4, it based this decision on whether the
name was in the package we're generating code for.  After this
commit, it bases this on whether the name is in the file we're
currently generating code for. i.e., what was once an invariant
across all files is no longer.

This is mostly fine, except for one case: We run the generator
across files we do not generate code for, in order to build a list
of symbols used to generate code for public imports. This change
caused some of those symbols to no longer be qualified.

In particular, this causes bad generation for wrapper types of
publicly imported messages that contain a field whose type is
another message in the same publicly imported package.

Fix this. Clean up some effectively dead code in SetPackageNames
at the same time. Fix tests to catch this case. (It wouldn't have
caught it anyway, but imp.proto is supposed to contain a public import.
This seems to have been lost when exporting code to git. Fixed.)