tree 51f99411d77977925ff81b93e525ed63f415cf18
parent be03c15fcaa227d4af8e81c350160fe65984a50a
author Herbie Ong <herbie@google.com> 1554876143 -0700
committer Herbie Ong <herbie@google.com> 1555405426 +0000

proto: wrap v2 textproto marshal/unmarshal

Removed V1 test files related to textproto serialization as these do not
provide much relevance given that pure V1 implementation is temporary and
maintaining dual mode for these tests can be troublesome.

Before deleting or changing any test files, all tests except for
timestamp_test.go:TestTimestampString pass with tag use_golang_protobuf_v1.

The issue with TestTimestampString is brought about by updating go.mod's V2
dependency to a newer version of Timestamp proto message that has String method
already using V2 textpb. Test is fixed in this CL.

Before these tests were removed, each was inspected for pass/fail
against the wrapped implementation.

Following tests failed due to expected differences between V1 and V2.
The failure reasons are added as review comments in the CL for
documentation purposes.

text_parser_test.go
  TestUnmarshalText
  TestMapParsing
  TestOneofParsing

text_test.go
  TestMarshalText
  TestMarshalTextUnknownEnum
  TestTextOneof
  TestCompactText
  TestStringEscaping
  TestMarshalTextFailing
  TestRepeatedNilText
  TestProto3Text

any_test.go
  TestMarshalGolden
  TestMarshalUnknownAny
  TestUnmarshalOverwriteAny
  TestUnmarshalAnyMixAndMatch

Change-Id: I2505341d6f47384a69b195efc3218fa07efc4e7a
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/171459
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>