tree deb6f58dc30d988079a37d824a1b095d8371a212
parent 2ef4baf0d952c0923060e01d5977f6d980e6195f
author Joe Tsai <joetsai@digital-static.net> 1519851456 -0800
committer GitHub <noreply@github.com> 1519851456 -0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJalxfACRBK7hj4Ov3rIwAAdHIIAHSXnpVaS6pPnbQIhTzUuAyz
 lTpHsOjsW6gqdeUShq3SHi9IikoDccRJWXQKNIGUoZsnoB87Bbh7/VdsREQCNuQ4
 hq/cOL/Wkv/0A7ryXhMZNNmXBR25fNbn/1HWo/qVGaJOBohVqUSn11tXWDRHA1yR
 5hBdJIYX2/+EUt6VrRdnX8ckUVVw0+96bM0lBajozzdAUriC+4lZe651Wfl28L6U
 FTOjIW5gwLYZzHy+m5hedRtfqItQWQR2yErwXfM3qtHgfA/hLf/ZgM5xXWxVAkR0
 WJiZDRntS++lmvDDflnkzsOmnwkSQlbwE9qNYLAQM3SlDjvemnCF4h3Hg4LHgss=
 =RIpJ
 -----END PGP SIGNATURE-----
 

Rename generated Marshal and Unmarshal protobuf method (#536)

As part of the recent protobuf optimization work, we started generating
Unmarshal and Marshal methods on generated messages. These were done to
support the table-driven implementation within the proto package.

We are renaming Marshal as XXX_Marshal and Unmarshal as XXX_Unmarshal
to make it clear that users are not supposed to call these directly.
There are several reasons for the rename:
* The Marshal method assumes that deterministic is the only option we
would ever support for protos, and is not very forward compatible.
* The presence of a deterministic boolean is confusing for users,
where many set it without considering whether it is necessary.
* The Unmarshal method has a slightly different semantic than the previously
documented proto.Unmarshaler interface. The documented Unmarshal specifies
that Reset is called, while the new method does no such thing. The semantic
difference warrants a rename of the method.
* Some users in the Go community depend on these methods not being
generated by default.

Fixes #530