tree ca0235c9f0e4f99c8e0b2e6b6c298cd035d08c03
parent 1d3f30b51784bec5aad268e59fd3c2fc1c2fe73f
author Joe Tsai <joetsai@digital-static.net> 1547018567 -0800
committer GitHub <noreply@github.com> 1547018567 -0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJcNaFHCRBK7hj4Ov3rIwAAdHIIAGhYJgjfjYY+XxW7hTHFJWp/
 fqK41uoG8b9Nn0jqH5Kht+FrPbuXtCJEYmvUMgIStL5q8mHc6bCBDCSW5qZb3ZiM
 Rvx3HmjaxhJf1f1IY/YgwuusSVq9xh+R00E/zykuTJWux+WMZbv1kplUFa93pJwt
 AE/B7/Wf42xOaUCIQEhBoyaC1Rd0nw3cyionuTlzFNPWAECoFElj4X+rkbGFQitr
 Z+C+gX1HWW3IJZfach7sYZwi6TntZ2UTP2o1LBohYpp8XIfi9w9eFo735qzVXhMj
 TdVQbHc+KCdNqEdRiaLFuKWrKZk7krmZCU6h2t+AbcMfpKDJ8kd8K0TUjs+WKPM=
 =gx8v
 -----END PGP SIGNATURE-----
 

protoc-gen-go: fix oneof name mangling regression (#782)

The generator currently uses an unintuitive and stateful algorithm
for name generation where it "fixes" name conflicts by appending "_"
to the end of the new name.

PR#657 refactored the generator code and noticed that the above
algorithm was not properly taking into account that a Get method is
generated for parent oneofs, fixing it in the same PR. While this is
more correct, this breaks users (see #780) since it means that the
generation of names can change.

This PR changes the name mangling logic to be as it was previously.
This does mean that some new proto files may be unbuildable,
but that is arguably better than breaking existing proto files.

Fixes #780