Preserve parameter references in unopened files

Summary:
An earlier change fixed incoming call hierarchy for files that the client did not open. It requested `Require::Everything` for every file that depends on the target module. This made the required ASTs available. However, the same helper also serves find references and find implementations. Those requests then performed full analysis on every dependent file.

D117389890 (PR) limits that work. Incoming call hierarchy performs full analysis only on files that reference the target. Type hierarchy performs full analysis on its candidate files. Most find-reference requests and all find-implementation requests use only the retained index. This keeps incoming call hierarchy correct and makes common reference requests faster.

D117389890 leaves one correctness problem. Parameter references do not use only the index. To find a keyword argument such as `greet(message="Hello")`, Pyrefly scans the caller AST. It also uses bindings to confirm that the keyword resolves to the selected parameter. An unopened file has neither at `Require::Indexing`. Find references therefore omits the keyword argument. Rename can change the parameter definition but leave `message=` unchanged in the unopened caller.

This diff requests `Require::Everything` for all dependent files only when the selected definition is a parameter. Other definitions keep the index-only path from D117389890. This restores parameter references and rename without removing the main performance improvement.

This diff also removes a duplicate type-hierarchy request for `Require::Everything`. The caller already makes the same request before it reads the candidate files.

The tests cover parameter references and parameter rename in an unopened caller file. The call hierarchy test now has two unopened caller files. This verifies that one batch prepares every selected caller file.

Reviewed By: stroxler

Differential Revision: D117455220

fbshipit-source-id: f8ba135ace020fbcd0e4ba9b0e7509773ba832be
6 files changed
tree: 0d60cd56d273c75a499d61993dfa6e474ebd3c6c
  1. .cargo/
  2. .claude/
  3. .github/
  4. .llms/
  5. .vscode/
  6. conformance/
  7. crates/
  8. lsp/
  9. pyrefly/
  10. pyrefly_wasm/
  11. release_notes/
  12. schemas/
  13. scripts/
  14. tensor-shapes/
  15. test/
  16. website/
  17. .gitattributes
  18. .gitignore
  19. action.yml
  20. AGENTS.md
  21. ARCHITECTURE.md
  22. Cargo.lock
  23. Cargo.toml
  24. CODE_OF_CONDUCT.md
  25. CONTRIBUTING.md
  26. debug.html
  27. empty.py
  28. LICENSE
  29. package-lock.json
  30. README.md
  31. REVIEW.md
  32. rust-toolchain.toml
  33. rustfmt.toml
  34. TENSOR_SHAPES_CONTRIBUTING.md
  35. test.py
  36. version.bzl
  37. yarn.lock
README.md

Pyrefly: A fast type checker and language server for Python with powerful IDE features

pyrefly PyPI VS Code Open VSX Discord License: MIT

Pyrefly is a type checker and language server for Python, which provides lightning-fast type checking along with IDE features such as code navigation, semantic highlighting, and code completion. It is available as a command-line tool and an extension for popular IDEs and editors such as VSCode, Neovim, Zed, and more.

See the Pyrefly website for full documentation and how to add Pyrefly to your editor of choice.

Pyrefly's current development status is stable.

Key Features

  • Fast. Pyrefly checks over 1.85 million lines of code per second, type checking projects like PyTorch 15x faster than Mypy and Pyright. In the IDE, rechecks typically complete in under 10 milliseconds after saving a file.
  • Production-proven at scale. Pyrefly is the default type checker for Instagram's 20-million-line Python codebase at Meta, and has been adopted by large open source projects including PyTorch and JAX.
  • Full-featured language server. Code navigation, autocomplete, hover information, inlay hints, semantic highlighting, and more, with consistent results across the CLI and your editor of choice.
  • Understands real-world Python. Built-in support for frameworks and tools like Pydantic, Django, and pytest, with model validation, field types, fixture navigation, and autocomplete that work out of the box.
  • Adoption-ready. Migrate from Mypy or Pyright with pyrefly init, silence existing errors with pyrefly suppress, and generate type annotations with pyrefly infer. Start with one file and expand at your own pace.

Getting Started

Version Policy

Pyrefly releases new minor versions (1.x.0) monthly and patch versions in between as-needed for critical fixes. Pyrefly does not follow strict semantic versioning: minor versions contain more significant changes than patch versions, but any version may introduce new type errors and other breaking changes. The pyrefly suppress command can be used to easily silence errors when upgrading to a new version.

Getting Involved

If you have questions or would like to report a bug, please create an issue.

See our contributing guide and architecture overview for information on how to contribute to Pyrefly.

Join our Discord to chat about Pyrefly and types. This is also where we hold biweekly office hours.