tree c4c414feae7e2868d997235ada91309280026d34
parent 8ab80e4a206a5a145eedced21ff769dfee62c286
author Brian Goff <cpuguy83@gmail.com> 1634844427 +0000
committer Sebastiaan van Stijn <github@gone.nl> 1634887808 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIcBAABAgAGBQJhcmiAAAoJEHZpjznVJ86MzvcP/0E9Pv8KzJOWf076D0PVz1ck
 Gf4gOE2NyC+HJyrHpAJxpjaTgCwo3R7kOibBe9VpCQlzXaxSLeeBVTS8UEtcZofs
 LTa74/5hZaoRia2tiXvXucd3+Ur5x1B0IobBCaZTpJgDjFZOJUY5DjGsYyP8fHmN
 ZDfx2K7IYGVOvRqyG9nQatHA3g8OeBPO8PRsV/ER2zhraLuvsqObPyNPvj/CRwNG
 bm8mMTzrC40dq5CIesWEWq8R2AaTxY2pYaPkx7Ngt+KF/D4TyhgvRpSRdAi356mq
 uJfK8z0rKBtUmHWIGaEgzfNDodmAjfMdiGOBTXfCABWBXsQEoaAQEJry4dKZu0YQ
 xoiEsd/zWH9oEZElrLgYCf+UU5gqbCX+8KEkyEj+ktlwVX+dseKmrP/IAnotct7C
 SGGbvg//nrdnR0C2jFwrhfWUXsY9ZYF8HOQNSIo0ygyszoAtKlF3Zq593L38zO7u
 z4S5MWMOj22p68BziB99gDMrb+Q9bnGJ17/BCJ1mMfx/Wx9g0VSff8n6koVr6Q7B
 7OkpJep+tHXyFUm6/yu9kZtCBuvPiWi7ePSkSel9gySG1v6d2AyS7xo8JmQqTENv
 fFAdGpFvP5oLCka1THAvrmkrD8BNDzAPSWmFg9PW+4PSlr4a/G7ZSzl2ObQfeO31
 3Asy0xFyJAFqVgwLl/QU
 =/jJ0
 -----END PGP SIGNATURE-----

Fix racey TestHealthKillContainer

Before this change if you assume that things work the way the test
expects them to (it does not, but lets assume for now) we aren't really
testing anything because we are testing that a container is healthy
before and after we send a signal. This will give false positives even
if there is a bug in the underlying code. Sending a signal can take any
amount of time to cause a container to exit or to trigger healthchecks
to stop or whatever.

Now lets remove the assumption that things are working as expected,
because they are not.
In this case, `top` (which is what is running in the container) is
actually exiting when it receives `USR1`.
This totally invalidates the test.

We need more control and knowledge as to what is happening in the
container to properly test this.
This change introduces a custom script which traps `USR1` and flips the
health status each time the signal is received.
We then send the signal twice so that we know the change has occurred
and check that the value has flipped so that we know the change has
actually occurred.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit 27ba755f70b05fce0bf14a49bfe33e540408c7c6)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>