commit | 9a8e878d3d75d3c43d16b5016b2ed03a92bc0f64 | [log] [tgz] |
---|---|---|
author | scentini <rosica@google.com> | Tue Jul 19 12:29:40 2022 +0000 |
committer | GitHub <noreply@github.com> | Tue Jul 19 14:29:40 2022 +0200 |
tree | ae3c85a9e583e196a3050f14dd930033172d34d5 | |
parent | 25baabc205e4d54e91bca4960cf48bb432f441d0 [diff] |
Fix `rust_binary_without_process_wrapper` build with `--stamp` (#1473) https://github.com/bazelbuild/rules_rust/pull/1452 set `rust_*.stamp=0` as a default for all rules except `rust_binary`, which has -1 as a default. The `rust_binary_without_process_wrapper` rule is used to build the process wrapper itself. It needs to override the `stamp` attribute back to 0, as we do not support stamping without the process wrapper. https://github.com/bazelbuild/rules_rust/pull/1452 introduced a bug where the default value for this rule became `-1`, thus building `//util/process_wrapper` with `--stamp` is now broken. This PR fixes the issue by routing all the attributes through the [_common_attrs_for_binary_without_process_wrapper](https://source.corp.google.com/piper///depot/google3/third_party/bazel_rules/rules_rust/rust/private/rust.bzl;rcl=461281665;l=1069?q=rust_binary_without_process_wrapper&ct=os&sq=package:piper%20file:%2F%2Fdepot%2Fgoogle3%20-file:google3%2Fexperimental) function, thus ensuring that the `stamp` attribute is once again set to 0.
This repository provides rules for building Rust projects with Bazel.
General discussions and announcements take place in the GitHub Discussions, but there are additional places where community members gather to discuss rules_rust
.
Please refer to the full documentation.