| commit | 4e5fac5980bcc723fb0f70c5625dec3f9738c3fd | [log] [tgz] |
|---|---|---|
| author | scentini <rosica@google.com> | Fri Aug 05 13:20:21 2022 +0000 |
| committer | GitHub <noreply@github.com> | Fri Aug 05 13:20:21 2022 +0000 |
| tree | 7eb09e48ca27cbfd5cc5e0a62ca0bc01a9281ea0 | |
| parent | 6c389346367c3792ceb71a13493722eddacc9bc1 [diff] |
Do not pass `--Clink-arg=-l` for libstd and libtest (#1500)
Fixes #1374
We skip adding `-Clink-arg=-l...` for libstd and libtest from the standard library, as these two libraries are present both as an `.rlib` and a `.so` format. On linux, Rustc adds a -Bdynamic to the linker command line before the libraries specified with `-Clink-arg`, which leads to us linking against the `.so`s but not putting the corresponding value to the runtime library search paths, which results in a "cannot open shared object file: No such file or directory" error at exectuion time. We can fix this by adding a `-Clink-arg=-Bstatic` on linux, but we don't have that option for macos. The proper solution for this issue would be to remove `libtest-{hash}.so` and `libstd-{hash}.so` from the toolchain. However, it is not enough to change the toolchain's `rust_std_{...}` filegroups here: https://github.com/bazelbuild/rules_rust/blob/a9d5d894ad801002d007b858efd154e503796b9f/rust/private/repository_utils.bzl#L144 because rustc manages to escape the sandbox and still finds them at linking time. We need to modify the repository rules to erase those files completely. This PR should be a good workaround until we get do to the proper thing though.
This PR also fixes the following issues for Windows:
* get_lib_name() didn't work properly on windows for `libc`
* `-Clink-arg` should point to the library name with extension included for windows.
This repository provides rules for building Rust projects with Bazel.
General discussions and announcements take place in the GitHub Discussions, but there are additional places where community members gather to discuss rules_rust.
Please refer to the full documentation.