| commit | 40dce282a25d411c36cbaaac061c97d0805e5bb2 | [log] [tgz] |
|---|---|---|
| author | Daniel Wagner-Hall <dwagnerhall@apple.com> | Thu Mar 03 18:03:34 2022 +0000 |
| committer | GitHub <noreply@github.com> | Thu Mar 03 18:03:34 2022 +0000 |
| tree | 6cb8e99fa1f70a6b1055bc2fef5190aec426bb2d | |
| parent | 59fab4e79f62bfa13551ac851a40696c24c0c3a4 [diff] |
Treat rustfmt as optional (#1164) All the code above this call treats rustfmt as optional, but then when we make the BUILD for the rust toolchain, we unconditionally point at the presumed rustfmt label. At https://github.com/bazelbuild/rules_rust/blob/59fab4e79f62bfa13551ac851a40696c24c0c3a4/rust/toolchain.bzl#L331-L335 we conditionally create a symlink based on whether the attribute is set, but because we unconditionally set the attribute, this causes a hard error failing to symlink to a non-existent file. Instead, treat rustfmt as optional in this function too, so that the code above and below properly convey the optionality to each other.
This repository provides rules for building Rust projects with Bazel.
General discussions and announcements take place in the GitHub Discussions, but there are additional places where community members gather to discuss rules_rust.
Please refer to the full documentation.