tree: 567e5a05e761c2732262dafa355aa1804fe11955 [path history] [tgz]
  1. manifest/
  2. modules_mapping/
  3. pythonconfig/
  4. testdata/
  5. bazel_gazelle.pr1095.patch
  6. BUILD.bazel
  7. configure.go
  8. def.bzl
  9. deps.bzl
  10. fix.go
  11. generate.go
  12. kinds.go
  13. language.go
  14. parse.py
  15. parser.go
  16. python_test.go
  17. README.md
  18. resolve.go
  19. std_modules.go
  20. std_modules.py
  21. target.go
gazelle/README.md

Python Gazelle plugin

This directory contains a plugin for Gazelle that generates BUILD file content for Python code.

Installation

First, you'll need to add Gazelle to your WORKSPACE file. Follow the instructions at https://github.com/bazelbuild/bazel-gazelle#running-gazelle-with-bazel

Next, we need to fetch the third-party Go libraries that the python extension depends on.

Add this to your WORKSPACE:

# To compile the rules_python gazelle extension from source,
# we must fetch some third-party go dependencies that it uses.
load("@rules_python//gazelle:deps.bzl", _py_gazelle_deps = "gazelle_deps")

_py_gazelle_deps()

Next, we‘ll fetch metadata about your Python dependencies, so that gazelle can determine which package a given import statement comes from. This is provided by the modules_mapping rule. We’ll make a target for consuming this modules_mapping, and writing it as a manifest file for Gazelle to read. This is checked into the repo for speed, as it takes some time to calculate in a large monorepo.

Create a file gazelle_python.yaml next to your requirements.txt file. (You can just use touch at this point, it just needs to exist.)

Then put this in your BUILD.bazel file next to the requirements.txt:

load("@pip//:requirements.bzl", "all_whl_requirements")
load("@rules_python//gazelle/manifest:defs.bzl", "gazelle_python_manifest")
load("@rules_python//gazelle/modules_mapping:def.bzl", "modules_mapping")

# This rule fetches the metadata for python packages we depend on. That data is
# required for the gazelle_python_manifest rule to update our manifest file.
modules_mapping(
    name = "modules_map",
    wheels = all_whl_requirements,
)

# Gazelle python extension needs a manifest file mapping from
# an import to the installed package that provides it.
# This macro produces two targets:
# - //:gazelle_python_manifest.update can be used with `bazel run`
#   to recalculate the manifest
# - //:gazelle_python_manifest.test is a test target ensuring that
#   the manifest doesn't need to be updated
gazelle_python_manifest(
    name = "gazelle_python_manifest",
    modules_mapping = ":modules_map",
    # This is what we called our `pip_install` rule, where third-party
    # python libraries are loaded in BUILD files.
    pip_repository_name = "pip",
    # When using pip_parse instead of pip_install, set the following.
    # pip_repository_incremental = True,
    # This should point to wherever we declare our python dependencies
    # (the same as what we passed to the modules_mapping rule in WORKSPACE)
    requirements = "//:requirements_lock.txt",
)

Finally, you create a target that you'll invoke to run the Gazelle tool with the rules_python extension included. This typically goes in your root /BUILD.bazel file:

load("@bazel_gazelle//:def.bzl", "gazelle")
load("@rules_python//gazelle:def.bzl", "GAZELLE_PYTHON_RUNTIME_DEPS")

# Our gazelle target points to the python gazelle binary.
# This is the simple case where we only need one language supported.
# If you also had proto, go, or other gazelle-supported languages,
# you would also need a gazelle_binary rule.
# See https://github.com/bazelbuild/bazel-gazelle/blob/master/extend.rst#example
gazelle(
    name = "gazelle",
    data = GAZELLE_PYTHON_RUNTIME_DEPS,
    gazelle = "@rules_python//gazelle:gazelle_python_binary",
)

That's it, now you can finally run bazel run //:gazelle anytime you edit Python code, and it should update your BUILD files correctly.

A fully-working example is in examples/build_file_generation.

Usage

Gazelle is non-destructive. It will try to leave your edits to BUILD files alone, only making updates to py_* targets. However it will remove dependencies that appear to be unused, so it's a good idea to check in your work before running Gazelle so you can easily revert any changes it made.

The rules_python extension assumes some conventions about your Python code. These are noted below, and might require changes to your existing code.

Note that the gazelle program has multiple commands. At present, only the update command (the default) does anything for Python code.

Directives

You can configure the extension using directives, just like for other languages. These are just comments in the BUILD.bazel file which govern behavior of the extension when processing files under that folder.

See https://github.com/bazelbuild/bazel-gazelle#directives for some general directives that may be useful. In particular, the resolve directive is language-specific and can be used with Python. Examples of these directives in use can be found in the /gazelle/testdata folder in the rules_python repo.

Python-specific directives are as follows:

DirectiveDefault value
# gazelle:python_extensionenabled
Controls whether the Python extension is enabled or not. Sub-packages inherit this value. Can be either “enabled” or “disabled”.
# gazelle:python_rootn/a
Sets a Bazel package as a Python root. This is used on monorepos with multiple Python projects that don't share the top-level of the workspace as the root.
# gazelle:python_manifest_file_namegazelle_python.yaml
Overrides the default manifest file name.
# gazelle:python_ignore_filesn/a
Controls the files which are ignored from the generated targets.
# gazelle:python_ignore_dependenciesn/a
Controls the ignored dependencies from the generated targets.
# gazelle:python_validate_import_statementstrue
Controls whether the Python import statements should be validated. Can be “true” or “false”
# gazelle:python_generation_modepackage
Controls the target generation mode. Can be “package” or “project”
# gazelle:python_library_naming_convention$package_name$
Controls the py_library naming convention. It interpolates $package_name$ with the Bazel package name. E.g. if the Bazel package name is foo, setting this to $package_name$_my_lib would result in a generated target named foo_my_lib.
# gazelle:python_binary_naming_convention$package_name$_bin
Controls the py_binary naming convention. Follows the same interpolation rules as python_library_naming_convention.
# gazelle:python_test_naming_convention$package_name$_test
Controls the py_test naming convention. Follows the same interpolation rules as python_library_naming_convention.
# gazelle:resolve py ...n/a
Instructs the plugin what target to add as a dependency to satisfy a given import statement. The syntax is # gazelle:resolve py import-string label where import-string is the symbol in the python import statement, and label is the Bazel label that Gazelle should write in deps.

Libraries

Python source files are those ending in .py but not ending in _test.py.

First, we look for the nearest ancestor BUILD file starting from the folder containing the Python source file.

If there is no py_library in this BUILD file, one is created, using the package name as the target's name. This makes it the default target in the package.

Next, all source files are collected into the srcs of the py_library.

Finally, the import statements in the source files are parsed, and dependencies are added to the deps attribute.

Tests

Python test files are those ending in _test.py.

A py_test target is added containing all test files as srcs.

Binaries

When a __main__.py file is encountered, this indicates the entry point of a Python program.

A py_binary target will be created, named [package]_bin.

Developing on the extension

Gazelle extensions are written in Go. Ours is a hybrid, which also spawns a Python interpreter as a subprocess to parse python files.

The Go dependencies are managed by the go.mod file. After changing that file, run go mod tidy to get a go.sum file, then run bazel run //:update_go_deps to convert that to the gazelle/deps.bzl file. The latter is loaded in our /WORKSPACE to define the external repos that we can load Go dependencies from.

Then after editing Go code, run bazel run //:gazelle to generate/update go_* rules in the BUILD.bazel files in our repo.