| commit | afc40f018b931a0abaa5497aa4484c7a3cda0b63 | [log] [tgz] |
|---|---|---|
| author | Richard Levasseur <rlevasseur@google.com> | Mon Jul 31 13:33:48 2023 -0700 |
| committer | GitHub <noreply@github.com> | Mon Jul 31 20:33:48 2023 +0000 |
| tree | c84fa4b54948852f6c91ed24def5a496aff38019 | |
| parent | bb8c4859950ecea29e794e85df579558c9d893fd [diff] |
fix: Don't require default Python version for pip hubs (#1344)
This fixes the issue where a sub-module was required to always have a
pip.parse() call configured for the default Python version if it used
any pip.parse() call. Such a
requirement puts sub-modules in an impossible situation:
* If they don't have the default version, they'll get an error.
* If they register the default version, but also register a specific
version,
they'll potentially cause an error if a root module changes the default
to
match their specific version (because two pip.parse() calls for the same
version
are made, which is an error).
The requirement to have the default version registered for a pip hub was
only present to satisfy the `whl_library_alias` repository rule, which
needed a Python version to map `//conditions:default` to.
To fix, the `whl_library_alias` rule's `default_version` arg is made
optional. When None is passed, the `//conditions:default` condition is
replaced with a `no_match_error` setting. This prevents the pip hub from
being used with the version-unaware rules, but that makes sense: no
wheels were setup for that version, so it's not like there is something
that
can be used anyways.
Fixes #1320
This repository is the home of the core Python rules -- py_library, py_binary, py_test, py_proto_library, and related symbols that provide the basis for Python support in Bazel. It also contains package installation rules for integrating with PyPI and other indices.
Documentation for rules_python lives in the docs/ directory and in the Bazel Build Encyclopedia.
Examples live in the examples directory.
Currently, the core rules build into the Bazel binary, and the symbols in this repository are simple aliases. However, we are migrating the rules to Starlark and removing them from the Bazel binary. Therefore, the future-proof way to depend on Python rules is via this repository. SeeMigrating from the Bundled Rules below.
The core rules are stable. Their implementation in Bazel is subject to Bazel's backward compatibility policy. Once migrated to rules_python, they may evolve at a different rate, but this repository will still follow semantic versioning.
The Bazel community maintains this repository. Neither Google nor the Bazel team provides support for the code. However, this repository is part of the test suite used to vet new Bazel releases. See How to contribute page for information on our development workflow.
See Bzlmod support for more details.
The following two sections cover using rules_python with bzlmod and the older way of configuring bazel with a WORKSPACE file.
IMPORTANT: bzlmod support is still in Beta; APIs are subject to change.
A default toolchain is automatically configured depending on rules_python. Note, however, the version used tracks the most recent Python release and will change often.
If you want to register specific Python versions, then use python.toolchain() for each version you need:
# Update the version "0.0.0" to the release found here: # https://github.com/bazelbuild/rules_python/releases. bazel_dep(name = "rules_python", version = "0.0.0") python = use_extension("@rules_python//python/extensions:python.bzl", "python") python.toolchain( python_version = "3.11", ) use_repo(python, "python_3_11", "python_aliases")
The use_repo statement above is essential as it imports one or more repositories into the current module's scope. The two repositories python_3_11 and python_aliases are created internally by the python extension. The name python_versions is a constant and is always imported. The identifier python_3_11 was created by using "python_{}".format("3.11".replace(".","_")). This rule takes the Python version and creates the repository name using the version.
For more documentation, see the bzlmod examples under the examples folder. Look for the examples that contain a MODULE.bazel file.
To import rules_python in your project, you first need to add it to your WORKSPACE file, using the snippet provided in the release you choose
To depend on a particular unreleased version, you can do the following:
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") # Update the SHA and VERSION to the lastest version available here: # https://github.com/bazelbuild/rules_python/releases. SHA="84aec9e21cc56fbc7f1335035a71c850d1b9b5cc6ff497306f84cced9a769841" VERSION="0.23.1" http_archive( name = "rules_python", sha256 = SHA, strip_prefix = "rules_python-{}".format(VERSION), url = "https://github.com/bazelbuild/rules_python/releases/download/{}/rules_python-{}.tar.gz".format(VERSION,VERSION), ) load("@rules_python//python:repositories.bzl", "py_repositories") py_repositories()
To register a hermetic Python toolchain rather than rely on a system-installed interpreter for runtime execution, you can add to the WORKSPACE file:
load("@rules_python//python:repositories.bzl", "python_register_toolchains") python_register_toolchains( name = "python_3_11", # Available versions are listed in @rules_python//python:versions.bzl. # We recommend using the same version your team is already standardized on. python_version = "3.11", ) load("@python_3_11//:defs.bzl", "interpreter") load("@rules_python//python:pip.bzl", "pip_parse") pip_parse( ... python_interpreter_target = interpreter, ... )
After registration, your Python targets will use the toolchain's interpreter during execution, but a system-installed interpreter is still used to ‘bootstrap’ Python targets (see https://github.com/bazelbuild/rules_python/issues/691). You may also find some quirks while using this toolchain. Please refer to python-build-standalone documentation's Quirks section.
Python toolchains can be utilized in other bazel rules, such as genrule(), by adding the toolchains=["@rules_python//python:current_py_toolchain"] attribute. You can obtain the path to the Python interpreter using the $(PYTHON2) and $(PYTHON3) “Make” Variables. See the test_current_py_toolchain target for an example.
Once you've imported the rule set into your WORKSPACE using any of these methods, you can then load the core rules in your BUILD files with the following:
load("@rules_python//python:defs.bzl", "py_binary") py_binary( name = "main", srcs = ["main.py"], )
Using PyPI packages (aka “pip install”) involves two main steps.
To add pip dependencies to your MODULE.bazel file, use the pip.parse extension, and call it to create the central external repo and individual wheel external repos. Include in the MODULE.bazel the toolchain extension as shown in the first bzlmod example above.
pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip") pip.parse( hub_name = "my_deps", python_version = "3.11", requirements_lock = "//:requirements_lock_3_11.txt", ) use_repo(pip, "my_deps")
For more documentation, including how the rules can update/create a requirements file, see the bzlmod examples under the examples folder.
To add pip dependencies to your WORKSPACE, load the pip_parse function and call it to create the central external repo and individual wheel external repos.
load("@rules_python//python:pip.bzl", "pip_parse") # Create a central repo that knows about the dependencies needed from # requirements_lock.txt. pip_parse( name = "my_deps", requirements_lock = "//path/to:requirements_lock.txt", ) # Load the starlark macro, which will define your dependencies. load("@my_deps//:requirements.bzl", "install_deps") # Call it to define repos for your requirements. install_deps()
Note that since pip_parse is a repository rule and therefore executes pip at WORKSPACE-evaluation time, Bazel has no information about the Python toolchain and cannot enforce that the interpreter used to invoke pip matches the interpreter used to run py_binary targets. By default, pip_parse uses the system command "python3". To override this, pass in the python_interpreter attribute or python_interpreter_target attribute to pip_parse.
You can have multiple pip_parses in the same workspace. Or use the pip extension multiple times when using bzlmod. This configuration will create multiple external repos that have no relation to one another and may result in downloading the same wheels numerous times.
As with any repository rule, if you would like to ensure that pip_parse is re-executed to pick up a non-hermetic change to your environment (e.g., updating your system python interpreter), you can force it to re-execute by running bazel sync --only [pip_parse name].
Note: The pip_install rule is deprecated. pip_parse offers identical functionality, and both pip_install and pip_parse now have the same implementation. The name pip_install may be removed in a future version of the rules.
The maintainers have made all reasonable efforts to facilitate a smooth transition. Still, some users of pip_install will need to replace their existing requirements.txt with a fully resolved set of dependencies using a tool such as pip-tools or the compile_pip_requirements repository rule.
Each extracted wheel repo contains a py_library target representing the wheel‘s contents. There are two ways to access this library. The first uses the requirement() function defined in the central repo’s //:requirements.bzl file. This function maps a pip package name to a label:
load("@my_deps//:requirements.bzl", "requirement") py_library( name = "mylib", srcs = ["mylib.py"], deps = [ ":myotherlib", requirement("some_pip_dep"), requirement("another_pip_dep"), ] )
The reason requirement() exists is that the pattern for the labels, while not expected to change frequently, is not guaranteed to be stable. Using requirement() ensures you do not have to refactor your BUILD files if the pattern changes.
On the other hand, using requirement() has several drawbacks; see this issue for an enumeration. If you don't want to use requirement(), you can use the library labels directly instead. For pip_parse, the labels are of the following form:
@{name}_{package}//:pkg
Here name is the name attribute that was passed to pip_parse and package is the pip package name with characters that are illegal in Bazel label names (e.g. -, .) replaced with _. If you need to update name from “old” to “new”, then you can run the following buildozer command:
buildozer 'substitute deps @old_([^/]+)//:pkg @new_${1}//:pkg' //...:*
For pip_install, the labels are instead of the form:
@{name}//pypi__{package}
Any ‘extras’ specified in the requirements lock file will be automatically added as transitive dependencies of the package. In the example above, you'd just put requirement("useful_dep").
If you need to depend on the wheel dists themselves, for instance, to pass them to some other packaging tool, you can get a handle to them with the whl_requirement macro. For example:
filegroup( name = "whl_files", data = [ whl_requirement("boto3"), ] )
Gazelle is a build file generator for Bazel projects. It can create new BUILD.bazel files for a project that follows language conventions and update existing build files to include new sources, dependencies, and options.
Bazel may run Gazelle using the Gazelle rule, or it may be installed and run as a command line tool.
See the documentation for Gazelle with rules_python here.
The core rules are currently available in Bazel as built-in symbols, but this form is deprecated. Instead, you should depend on rules_python in your WORKSPACE file and load the Python rules from @rules_python//python:defs.bzl.
A buildifier fix is available to automatically migrate BUILD and .bzl files to add the appropriate load() statements and rewrite uses of native.py_*.
# Also consider using the -r flag to modify an entire workspace. buildifier --lint=fix --warnings=native-py <files>
Currently, the WORKSPACE file needs to be updated manually as per Getting started above.
Note that Starlark-defined bundled symbols underneath @bazel_tools//tools/python are also deprecated. These are not yet rewritten by buildifier.