tree ec94bbba133022a80a8db0336557915ba5d7f8fc
parent bfd62ef45bedf02a4f61c08bba134a2eb06c0b47
author Christian Duerr <chrisduerr@users.noreply.github.com> 1530568984 +0000
committer GitHub <noreply@github.com> 1530568984 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJbOqEYCRBK7hj4Ov3rIwAAdHIIACKoNl2hi639FXb5o4Rp7aka
 cj7vKGbf75QyaykDi2sOyGevAhky+1bOq/ALBpKQFkAyeetKQJVqKSZgZBqNLmaX
 irYrK/5O5Z7DgTNXRI1YpFF+10vHx9HJqnRKIj885v56Nts3/i6EZKJ7cbgM9pPc
 X64XWB1OciTptp86aduwbjZYP54+qe9FUX3Mpjr45xCkWDuyR9M7eHIzAuMYpIFN
 79t/yVG+kcFlNzmg8cgtsc0hfqF+IJk138qx//8RE5nu9n4VPtRt5uavEQFrmV96
 J0DLJm6xGWWQUcX2CK8EBqVvdvOMVozOBCL+s5QBe9ZFEQcmjRDcGVsaPX/6ZOE=
 =XDgu
 -----END PGP SIGNATURE-----
 

Fix scrollback accessing indices out of bounds

There have been two instances of the scrollback trying to access indices
which were moved out of bounds due to new lines (`yes` command). These
have both been fixed.

The first instance was during semantic selection, since the logic of
limiting the selection start point was moved outside of `compute_index`,
it was necessary to add this to semantic selection too. Now semantic
selection, line selection and normal selection should all work without
crashing when new lines are shoving the selection out of bounds.

The other error was with the viewport being outside of the scrollback
history. Since the default is to keep the scrollback buffer at its
current position when new lines are added, it is possible that the
position the scrollback buffer is at is suddenly shoved out of the
visible area. To fix this the `display_offset` is now limited to always
be an allowed value.
If a single line of the viewport is moved out of the history now, the
viewport should move down a single line now, so only valid content is
displayed, with multiple lines this process is repeated.

This fixes #1400.

There was another error where the iterator would attempt to iterate
before the first line in the history buffer, this was because the bounds
of the `prev` iterator weren't setup correctly. The iterator should now
properly iterate from the first cell in the terminal until the last one.

This also fixes #1406, since these semantic selection errors were
partiall related to indexing.