tree ca82ae11bbb94f1022770a00739c4bc219d53612
parent d421274e3e11a0e6480358faa8a8e5cf48d7b3c2
author Brad King <brad.king@kitware.com> 1595445372 -0400
committer Brad King <brad.king@kitware.com> 1595445591 -0400

cmake-gui: Fix crash when built with Qt 5.14 or later

In commit d7679f6427 (QCMakeCacheView: use non-deprecated List and Set
constructions, 2020-06-10, v3.18.0-rc2~13^2) the conversion of the
`this->properties()` value to QSet is incorrect for Qt 5.14+.  The
problem is that `this->properties()` returns by value, so the range
`this->properties().begin(), this->properties().end()` provides
iterators to two different instances.  Use an intermediate temporary
copy of the value to get a consistent iterator range.

Fixes: #20981