)]}'
{
  "commit": "3b1c19f00a0973d1d70e823cf54a9047d20cb80a",
  "tree": "a5bb5263dc7661d236a5adae878f1661ca458294",
  "parents": [
    "e2be23a2b39f4380f32fe65ba770addc154579c7"
  ],
  "author": {
    "name": "Kefu Chai",
    "email": "tchaikov@gmail.com",
    "time": "Tue Dec 20 11:38:27 2022 +0800"
  },
  "committer": {
    "name": "Brad King",
    "email": "brad.king@kitware.com",
    "time": "Fri Jan 20 10:14:39 2023 -0500"
  },
  "message": "FindOpenSP: Use pkg-config only as hints for main code path\n\nbefore this change, pkg_check_modules(.. IMPORTED_TARGET GLOBAL)\nis used for creating an imported target from which another imported\ninterface library named OpenSP::OpenSP is created. but pkg-config\ndoes not account for all of CMake\u0027s other search behavior controls,\nsuch as CMAKE_FIND_ROOT_PATH. neither does it export the full path\nwith OpenSP_LIBRARY.\n\nafter this change, the paths found by pkg-config are only used\nas hints for the find_*() commands. and some cleanup are included:\n\n* be QUIET when calling find_package(PkgConfig ..) and\n  pkg_check_modules(..) as they are distracting from user\u0027s point of\n  view. what matters is the output of find_package_handle_standard_args()\n* parse the version and check for the existance of symbol as long as\n  header path is found. because they only use header files.\n* define OpenSP_LIBRARY as long as it exists. this just follows\n  the convention. as OpenSP_FOUND implies a valid OpenSP_LIBRARY.\n* wrap and intent multi-line command calls for better readability\n* check OpenSP_FOUND before adding OpenSP::OpenSP, it\u0027s more\n  idiomatic.\n\nFixes: #24313\nSigned-off-by: Kefu Chai \u003ctchaikov@gmail.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "655dd6572f960ee5cea18a9e1b4c8aadafb08b12",
      "old_mode": 33188,
      "old_path": "Modules/FindOpenSP.cmake",
      "new_id": "25d0e6fb781130488fca817ac7de460e7f68cfd2",
      "new_mode": 33188,
      "new_path": "Modules/FindOpenSP.cmake"
    }
  ]
}
