Google Git
Sign in
fuchsia / third_party / github.com / GNOME / glib / refs/heads/upstream/th/gobject-notify-queue-2
commit67f6162c51d8cd48d1e268a676b7a9ff36925b56[log] [tgz]
authorThomas Haller <thaller@redhat.com>Mon Jan 29 15:41:40 2024 +0100
committerThomas Haller <thaller@redhat.com>Mon Jan 29 18:17:37 2024 +0100
tree45cf70a1a869b826a83a9a87907078333038a35f
parent2b76e8faa72c2ea6bea7fe0bedca73f608ded47f [diff]
gobject: fix race and use datalist_id_update_atomic() for weak refs

The previous code is not thread safe. See how g_object_weak_ref() and
g_object_weak_unref() take OPTIONAL_BIT_LOCK_WEAK_REFS locks. However,
there are various places that call

  g_datalist_id_set_data (&object->qdata, quark_weak_notifies, NULL);

without OPTIONAL_BIT_LOCK_WEAK_REFS lock. That doesn't work.

We would have there also to take a OPTIONAL_BIT_LOCK_WEAK_REFS lock.
Instead, use datalist_id_update_atomic() to perform all operations under
the GData lock.
1 file changed
tree: 45cf70a1a869b826a83a9a87907078333038a35f
  1. .gitlab-ci/
  2. .reuse/
  3. docs/
  4. fuzzing/
  5. gio/
  6. girepository/
  7. glib/
  8. gmodule/
  9. gobject/
  10. gthread/
  11. introspection/
  12. LICENSES/
  13. m4macros/
  14. po/
  15. subprojects/
  16. tests/
  17. tools/
  18. COPYING ⇨ LICENSES/LGPL-2.1-or-later.txt
  19. .clang-format
  20. .dir-locals.el
  21. .editorconfig
  22. .gitignore
  23. .gitlab-ci.yml
  24. .gitmodules
  25. .lcovrc
  26. CODE_OF_CONDUCT.md
  27. CONTRIBUTING.md
  28. glib.doap
  29. INSTALL.md
  30. meson.build
  31. meson_options.txt
  32. NEWS
  33. README.md
  34. SECURITY.md
README.md

GLib

GLib is the low-level core library that forms the basis for projects such as GTK and GNOME. It provides data structure handling for C, portability wrappers, and interfaces for such runtime functionality as an event loop, threads, dynamic loading, and an object system.

The official download locations are: https://download.gnome.org/sources/glib

The official web site is: https://www.gtk.org/

Installation

See the file ‘INSTALL.md’. There is separate and more in-depth documentation for building GLib on Windows.

Supported versions

Upstream GLib only supports the most recent stable release series, the previous stable release series, and the current development release series. All older versions are not supported upstream and may contain bugs, some of which may be exploitable security vulnerabilities.

See SECURITY.md for more details.

Documentation

API documentation is available online for GLib for the:

Discussion

If you have a question about how to use GLib, seek help on GNOME’s Discourse instance. Alternatively, ask a question on StackOverflow and tag it glib.

Reporting bugs

Bugs should be reported to the GNOME issue tracking system. You will need to create an account for yourself. You may also submit bugs by e-mail (without an account) by e-mailing incoming+gnome-glib-658-issue-@gitlab.gnome.org, but this will give you a degraded experience.

Bugs are for reporting problems in GLib itself, not for asking questions about how to use it. To ask questions, use one of our discussion forums.

In bug reports please include:

  • Information about your system. For instance:
    • What operating system and version
    • For Linux, what version of the C library
    • And anything else you think is relevant.
  • How to reproduce the bug.
    • If you can reproduce it with one of the test programs that are built in the tests/ subdirectory, that will be most convenient. Otherwise, please include a short test program that exhibits the behavior. As a last resort, you can also provide a pointer to a larger piece of software that can be downloaded.
  • If the bug was a crash, the exact text that was printed out when the crash occurred.
  • Further information such as stack traces may be useful, but is not necessary.

Contributing to GLib

Please follow the contribution guide to know how to start contributing to GLib.

Patches should be submitted as merge requests to gitlab.gnome.org. If the patch fixes an existing issue, please refer to the issue in your commit message with the following notation (for issue 123):

Closes: #123

Otherwise, create a new merge request that introduces the change. Filing a separate issue is not required.