WIP: gobject: use per-object bit-lock instead of global RWLock for GWeakRef WIP: tests still failing. Replace the global RWLock with a per-object locking. g_object_unref() needs to take a lock for GWeakRef while decrementing the reference count to zero. That is also the case, when no weak refs actually are registered. Replace the global RWLock with a per-object bit lock. There are actually two locks. The per-object lock OPTIONAL2_BIT_LOCK_G_WEAK_REF and a bit lock WEAK_REF_LOCK on `&weak_ref->priv.p`. The object lock OPTIONAL2_BIT_LOCK_G_WEAK_REF must be taken first, we cannot take it after having a WEAK_REF_LOCK lock. Otherwise there would be deadlocks. Unfortunately, this requires us to add another guint field optional2_flags for locking. This increases the size of all GObject by 16 bytes (on x86-64) That's because while holding _weak_ref_lock(), we need to be able to call g_object_ref(). g_object_ref() locks on OPTIONAL_BIT_LOCK_TOGGLE_REFS. If OPTIONAL2_BIT_LOCK_G_WEAK_REF were on the same "optional_flags" as OPTIONAL_BIT_LOCK_TOGGLE_REFS, it would mean we have cases where we take OPTIONAL2_BIT_LOCK_G_WEAK_REF && _weak_ref_lock() and cases where we take _weak_ref_lock() && OPTIONAL_BIT_LOCK_TOGGLE_REFS That would deadlock. We need distinct logs for that, and need another int field in GObjectPrivate for the bitlock OPTIONAL2_BIT_LOCK_G_WEAK_REF. New and noteworthy is that `g_weak_ref_set()` now calls old_object = g_weak_ref_get (weak_ref); ... g_object_unref (old_object); It wouldn't work otherwise, to get a OPTIONAL2_BIT_LOCK_G_WEAK_REF on old_object. Because we can only access weak_ref->priv.p when having a _weak_ref_lock(), but also, we cannot take an object lock OPTIONAL2_BIT_LOCK_G_WEAK_REF while holding a _weak_ref_lock().
GLib is the low-level core library that forms the basis for projects such as GTK and GNOME. It provides data structure handling for C, portability wrappers, and interfaces for such runtime functionality as an event loop, threads, dynamic loading, and an object system.
The official download locations are: https://download.gnome.org/sources/glib
The official web site is: https://www.gtk.org/
See the file ‘INSTALL.md’. There is separate and more in-depth documentation for building GLib on Windows.
Upstream GLib only supports the most recent stable release series, the previous stable release series, and the current development release series. All older versions are not supported upstream and may contain bugs, some of which may be exploitable security vulnerabilities.
See SECURITY.md for more details.
API documentation is available online for GLib for the:
If you have a question about how to use GLib, seek help on GNOME’s Discourse instance. Alternatively, ask a question on StackOverflow and tag it glib.
Bugs should be reported to the GNOME issue tracking system. You will need to create an account for yourself. You may also submit bugs by e-mail (without an account) by e-mailing incoming+gnome-glib-658-issue-@gitlab.gnome.org, but this will give you a degraded experience.
Bugs are for reporting problems in GLib itself, not for asking questions about how to use it. To ask questions, use one of our discussion forums.
In bug reports please include:
tests/ subdirectory, that will be most convenient. Otherwise, please include a short test program that exhibits the behavior. As a last resort, you can also provide a pointer to a larger piece of software that can be downloaded.Please follow the contribution guide to know how to start contributing to GLib.
Patches should be submitted as merge requests to gitlab.gnome.org. If the patch fixes an existing issue, please refer to the issue in your commit message with the following notation (for issue 123):
Closes: #123
Otherwise, create a new merge request that introduces the change. Filing a separate issue is not required.