Google Git
Sign in
fuchsia / third_party / ffmpeg / 0fcf74f4357e949f5971d39b04a128103b8949bb
commit0fcf74f4357e949f5971d39b04a128103b8949bb[log] [tgz]
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>Tue Apr 14 04:30:59 2020 +0200
committerAndreas Rheinhardt <andreas.rheinhardt@gmail.com>Mon Apr 20 18:43:53 2020 +0200
tree99c651cf5aa9ed75c0b82958dc8fcb4321ec0287
parentd026fef999f7e2491721b3878bea6e6da8b9f92e [diff]
avformat/oggenc: Don't free AVStream's priv_data, fix memleak

For FLAC, Speex, Opus and VP8 the Ogg muxer allocates two buffers
for building the headers: The first for extradata in an Ogg-specific
format and the second contains a Vorbiscomment. These buffers are
reachable via pointers in the corresponding AVStream's priv_data.

If an error happens during building the headers, the AVStream's
priv_data would be freed. This is pointless in general as it would be
freed generically anyway, but here it is actively harmful: If the second
of the aforementioned allocations fails, the first buffer would leak
upon freeing priv_data.

This commit stops freeing priv_data manually, which allows the muxer to
properly clean up in the deinit function.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
1 file changed
tree: 99c651cf5aa9ed75c0b82958dc8fcb4321ec0287
  1. compat/
  2. doc/
  3. ffbuild/
  4. fftools/
  5. libavcodec/
  6. libavdevice/
  7. libavfilter/
  8. libavformat/
  9. libavresample/
  10. libavutil/
  11. libpostproc/
  12. libswresample/
  13. libswscale/
  14. presets/
  15. tests/
  16. tools/
  17. .gitattributes
  18. .gitignore
  19. .mailmap
  20. .travis.yml
  21. Changelog
  22. configure
  23. CONTRIBUTING.md
  24. COPYING.GPLv2
  25. COPYING.GPLv3
  26. COPYING.LGPLv2.1
  27. COPYING.LGPLv3
  28. CREDITS
  29. INSTALL.md
  30. LICENSE.md
  31. MAINTAINERS
  32. Makefile
  33. README.md
  34. RELEASE
README.md

FFmpeg README

FFmpeg is a collection of libraries and tools to process multimedia content such as audio, video, subtitles and related metadata.

Libraries

  • libavcodec provides implementation of a wider range of codecs.
  • libavformat implements streaming protocols, container formats and basic I/O access.
  • libavutil includes hashers, decompressors and miscellaneous utility functions.
  • libavfilter provides a mean to alter decoded Audio and Video through chain of filters.
  • libavdevice provides an abstraction to access capture and playback devices.
  • libswresample implements audio mixing and resampling routines.
  • libswscale implements color conversion and scaling routines.

Tools

  • ffmpeg is a command line toolbox to manipulate, convert and stream multimedia content.
  • ffplay is a minimalistic multimedia player.
  • ffprobe is a simple analysis tool to inspect multimedia content.
  • Additional small tools such as aviocat, ismindex and qt-faststart.

Documentation

The offline documentation is available in the doc/ directory.

The online documentation is available in the main website and in the wiki.

Examples

Coding examples are available in the doc/examples directory.

License

FFmpeg codebase is mainly LGPL-licensed with optional components licensed under GPL. Please refer to the LICENSE file for detailed information.

Contributing

Patches should be submitted to the ffmpeg-devel mailing list using git format-patch or git send-email. Github pull requests should be avoided because they are not part of our review process and will be ignored.