|author||Laszlo Ersek <email@example.com>||Tue Jul 02 00:35:18 2019 +0200|
|committer||Laszlo Ersek <firstname.lastname@example.org>||Tue Jul 16 23:24:38 2019 +0200|
MdePkg/BaseLib: rewrite Base64Decode() Rewrite Base64Decode() from scratch, due to reasons listed in the second reference below. Implement Base64Decode() according to the specification added in the previous patch. The decoder scans the input buffer once, it has no inner loop(s), and it spills each output byte as soon as the output byte is complete. The intent is to only strengthen the checks (sanity and input) relative to the previous implementation, hence the MAX_ADDRESS checks are reinstated. Cc: Liming Gao <email@example.com> Cc: Marvin Häuser <firstname.lastname@example.org> Cc: Michael D Kinney <email@example.com> Cc: Philippe Mathieu-Daudé <firstname.lastname@example.org> Cc: Zhichao Gao <email@example.com> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1891 Ref: http://firstname.lastname@example.org Signed-off-by: Laszlo Ersek <email@example.com> Reviewed-by: Liming Gao <firstname.lastname@example.org> Tested-by: Zhichao Gao <email@example.com> Reviewed-by: Philippe Mathieu-Daude <firstname.lastname@example.org> [email@example.com: add last para to commit msg per talks w/ Marvin & Phil]
A modern, feature-rich, cross-platform firmware development environment for the UEFI and PI specifications from www.uefi.org.
The majority of the content in the EDK II open source project uses a BSD-2-Clause Plus Patent License. The EDK II open source project contains the following components that are covered by additional licenses:
The EDK II Project is composed of packages. The maintainers for each package are listed in Maintainers.txt.
To make a contribution to a TianoCore project, follow these steps.
Create a change description in the format specified below to use in the source control commit log.
Your commit message must include your
Submit your code to the TianoCore project using the process that the project documents on its web page. If the process is not documented, then submit the code on development email list for the project.
It is preferred that contributions are submitted using the same copyright license as the base project. When that is not possible, then contributions using the following licenses can be accepted:
Contributions of code put into the public domain can also be accepted.
Contributions using other licenses might be accepted, but further review will be required.
Your change description should use the standard format for a commit message, and must include your
In order to keep track of who did what, all patches contributed must include a statement that to the best of the contributor's knowledge they have the right to contribute it under the specified license.
The test for this is as specified in the Developer's Certificate of Origin (DCO) 1.1. The contributor certifies compliance by adding a line saying
Signed-off-by: Developer Name firstname.lastname@example.org
Developer Name is the contributor's real name, and the email address is one the developer is reachable through at the time of contributing.
Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.
From: Contributor Name <email@example.com> Subject: [Repository/Branch PATCH] Pkg-Module: Brief-single-line-summary Full-commit-message Signed-off-by: Contributor Name <firstname.lastname@example.org>
[Repository/Branch PATCH]. The remaining portion of the commit message is the email’s content.
git format-patchis one way to create this format
Repositoryis the identifier of the repository the patch applies. This identifier should only be provided for repositories other than
edk2. For example
Branchis the identifier of the branch the patch applies. This identifier should only be provided for branches other than
edk2/master. For example
Moduleis a short identifier for the affected code or documentation. For example
EDK II INF File Format.
Brief-single-line-summaryis a short summary of the change.
Full-commit-messagea verbose multiple line comment describing the change. Each line should be less than ~70 characters.
Signed-off-byis the contributor's signature identifying them by their real/legal name and their email address.