commit f7d5e47913356b8b6706b4897c14ca40bc5da81b
author Dangyi Liu <dangyi@google.com> Fri Apr 16 21:29:33 2021 +0000
committer Copybara-Service <copybara-worker@google.com> Fri Apr 16 15:07:12 2021 -0700
tree fac30d67411d5183f5a5909a6e931aa4b267c80f
parent 959d6d9ef9816bc2cb27af1eb46758184d0022e6

fix -Wconversion issues in util tests

Change-Id: I66e7c7eeafa97b12649dba413b6fc7c62af8fee0
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2832209
Reviewed-by: Francois Rousseau <frousseau@google.com>
Commit-Queue: Scott Graham <scottmg@chromium.org>
GitOrigin-RevId: 2c1261fca7029beabb848be94cba68e3f7d22c22

util/net/http_body_gzip_test.cc

diff --git a/util/net/http_body_gzip_test.cc b/util/net/http_body_gzip_test.cc
index 9dafb37..926dfca 100644
--- a/util/net/http_body_gzip_test.cc
+++ b/util/net/http_body_gzip_test.cc
@@ -133,7 +133,7 @@
 std::string MakeString(size_t size) {
   std::string string;
   for (size_t i = 0; i < size; ++i) {
-    string.append(1, (i % 256) ^ ((i >> 8) % 256));
+    string.append(1, static_cast<char>((i % 256) ^ ((i >> 8) % 256)));
   }
   return string;
 }

util/process/process_memory_test.cc

diff --git a/util/process/process_memory_test.cc b/util/process/process_memory_test.cc
index 3e3e058..f00a6b9 100644
--- a/util/process/process_memory_test.cc
+++ b/util/process/process_memory_test.cc
@@ -104,7 +104,7 @@
   *region_size = 4 * base::GetPageSize();
   region->reset(new char[*region_size]);
   for (size_t index = 0; index < *region_size; ++index) {
-    (*region)[index] = index % 256;
+    (*region)[index] = static_cast<char>(index % 256);
   }
 }
 
@@ -367,7 +367,7 @@
 void DoReadUnmappedChildMainSetup(void* page) {
   char* region = reinterpret_cast<char*>(page);
   for (size_t index = 0; index < base::GetPageSize(); ++index) {
-    region[index] = index % 256;
+    region[index] = static_cast<char>(index % 256);
   }
 }