| commit | 8e2f9b64cafda091c7b32e0a98ef77baa8532c5f | [log] [tgz] |
|---|---|---|
| author | Mark Mentovai <mark@chromium.org> | Tue Sep 01 01:19:06 2020 -0400 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Jan 19 07:14:43 2021 -0800 |
| tree | b2551a89e629295a62e1a1cfc1692a3036ab4dff | |
| parent | 12ba8342db97efb136a5eced8b16ca1abb901ac5 [diff] |
mac-arm64: Omit the cl_kernels workaround on this platform
cl_kernels modules have appeared since OS X 10.10 as MH_BUNDLE modules
with a __TEXT segment, one section of which claims to belong to the __LD
segment. They are produced when OpenCL is asked to compile an OpenCL
kernel for the CPU, but this currently appears impossible on arm64.
The workaround is omitted as it appears to be unnecessary, but the test
still attempts to create an OpenCL kernel for the CPU. If this ever
becomes possible, and the modules are malformed, the test will fail as
an indication that the workaround must be reinstated for arm64.
Bug: crashpad:345
Test: crashpad_snapshot_test ProcessReaderMac.{Self,Child}Modules
Change-Id: If26f58b609fc6b7db587894881fd4c890aef3258
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2386466
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
GitOrigin-RevId: f8563cb8626ac6d1d416edb545ef20bd8f4fc133
Crashpad is a crash-reporting system.
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.