commit c98638dc89166e4e71a54ef9094278909721100e
author Peter Kasting <pkasting@chromium.org> Wed Jun 09 07:01:18 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Jun 09 07:56:18 2021 -0700
tree b0a2667f1b3739f405305c52a0957c988bc25486
parent 2fd219ea3436d73f97a1519da89d164d6651fd17

Fix -Wc++11-narrowing in crashpad.

timeval's first member's type is __kernel_old_time_t on at least
Windows; this is a 32-bit type as opposed to time_t, which is a 64-bit
type.  As a result, casting directly to time_t results in a truncation,
triggering the warning.

It's not possible to cast directly to __kernel_old_time_t, since that
type is not exposed here.  Instead, cast to the underlying type, long,
which should work correctly on all platforms.

This has Year 2038 problems (which is why time_t is switching to
64-bit), which I suspect would be best fixed by a larger change like
moving away from using timeval anywhere (?).  I'm not really certain
what all would be involved in trying to make this whole pipeline
Y2038-safe, so I haven't attempted to tackle this.

Bug: chromium:1216696
Change-Id: Ie911ad2eb8b84374d57cff07c775ff4c5cbf000f
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2949650
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
GitOrigin-RevId: 8804387c75b5ea6b2ac7ef978104972996c721d1

minidump/minidump_misc_info_writer_test.cc

diff --git a/minidump/minidump_misc_info_writer_test.cc b/minidump/minidump_misc_info_writer_test.cc
index 10d5c9e..18ac296 100644
--- a/minidump/minidump_misc_info_writer_test.cc
+++ b/minidump/minidump_misc_info_writer_test.cc
@@ -774,12 +774,12 @@
           debug_build_string_utf16.c_str(),
           base::size(expect_misc_info.DbgBldStr));
 
-  const timeval kStartTime =
-      { static_cast<time_t>(expect_misc_info.ProcessCreateTime), 0 };
-  const timeval kUserCPUTime =
-      { static_cast<time_t>(expect_misc_info.ProcessUserTime), 0 };
-  const timeval kSystemCPUTime =
-      { static_cast<time_t>(expect_misc_info.ProcessKernelTime), 0 };
+  const timeval kStartTime = {
+      static_cast<long>(expect_misc_info.ProcessCreateTime), 0};
+  const timeval kUserCPUTime = {
+      static_cast<long>(expect_misc_info.ProcessUserTime), 0};
+  const timeval kSystemCPUTime = {
+      static_cast<long>(expect_misc_info.ProcessKernelTime), 0};
 
   TestProcessSnapshot process_snapshot;
   process_snapshot.SetProcessID(expect_misc_info.ProcessId);