| commit | 35692c69dcdbe604b040c79119aaa4e426b950d0 | [log] [tgz] |
|---|---|---|
| author | Scott Graham <scottmg@chromium.org> | Tue Nov 12 12:08:54 2019 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Jan 19 06:42:03 2021 -0800 |
| tree | b7291586bed4ca66d1abe21814a2d93d861add6f | |
| parent | 2b949cb1ba2cfb0a228fb25e2d1ece2f136360af [diff] |
fuchsia: Don't capture incorrect/unreasonably large stacks In a stack overflow test from the Fuchsia tree, an intentional crash was being induced that at the point it was reported to Crashpad resulted in a stack pointer outside of the stack. This caused two problems: - Crashpad attempted to capture that whole "thing" which could have been anything, and in the failing test was a 1G guard region - The whole wrong thing could be very large, resulting in OOM when trying to write the minidump, which was the symptom of the bug. Don't attempt to continue of SP isn't at least in a mapping, and don't capture too-large regions for the stack as nothing useful can come of that anyway. New test added: ProcessSnapshotFuchsiaTest.InvalidStackPointer. Bug: fuchsia:41212 Change-Id: I4eab699534680e4dae8a4ddbe3c87919afc10ac2 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1912942 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Francois Rousseau <frousseau@google.com> GitOrigin-RevId: 0208c1a175e12480698f3befcabf604f45812b20
Crashpad is a crash-reporting system.
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.