commit 2175fc535c14c49688a0e7284f63b13095ba2fe9
author Mark Mentovai <mark@chromium.org> Wed Jul 08 00:00:18 2020 -0400
committer Copybara-Service <copybara-worker@google.com> Tue Jan 19 07:11:19 2021 -0800
tree f73db33a2af4ea8b965d2cf1be9b0c83aec460a0
parent f26b6abf44299a5d25e214bf3daa55fc82b85f18

android: Fix “gn analyze”

On Android, the compat library built compat/android/sys/mman.cc, which
provides a fallback for mmap, and compat/linux/sys/mman.cc, which
provides a fallback for memfd_create. This can result in two object
files colliding in the library, which is flagged as a “gn analyze”
error:

> ERROR at //crashpad/compat/BUILD.gn:62:5: Duplicate object file
>     static_library(target_name) {
>     ^----------------------------
> The target //crashpad/compat:compat
> generates two object files with the same name:
>   obj/crashpad/compat/compat/mman.o
>
> It could be you accidentally have a file listed twice in the
> sources. Or, depending on how your toolchain maps sources to
> object files, two source files with the same name in different
> directories could map to the same object file.
>
> In the latter case, either rename one of the files or move one of
> the sources to a separate source_set to avoid them both being in
> the same target.

The files are renamed to avoid this collision. The associated headers
cannot be renamed because they need to shadow the SDK’s copies. There is
no “gn analyze” conflict reported for headers with the same name.

Change-Id: I186f72cf9f87b617c29a04b00a9ed3cc3bdc2b30
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2285965
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
GitOrigin-RevId: b9c828ea838d0104e72ce1bca090d8dab3183a18