commit 1acdf90f4399e5b47fa781761c4e2488298ff759
author Mark Mentovai <mark@chromium.org> Wed Sep 09 22:35:13 2020 -0400
committer Copybara-Service <copybara-worker@google.com> Tue Jan 19 07:15:11 2021 -0800
tree d7bd815cd15ea9dc769a2c5bb645e2f318643850
parent cb54208531cbbcac2076b6b2f28552eabe42364b

mac: Fix MacOSVersionNumber for 10.12.0 < version < 10.13.4

In 5412beb63386, I asserted (via my code) that the kern.osproductversion
sysctl was introduced in 10.12.0, but this was utterly wrong. It’s not
available until 10.13.4. Compare 10.13.3
xnu-4570.41.2/bsd/kern/kern_sysctl.c to 10.13.4
xnu-4570.51.1/bsd/kern/kern_sysctl.c, look for osproductversion.

https://pbs.twimg.com/media/EU0GDTVU4AY73KC.jpg

Failures appeared starting at
https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/37499
(https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8869605548532164608/+/steps/crashpad_tests_on_Intel_GPU_on_Mac_on_Mac-10.12.6/0/stdout).

This fixes expectations to not require kern.osproductversion to exist
until 10.13.4.

VM-tested on 10.12.6, 10.13.3, 10.13.4, and 10.14.0.

Bug: crashpad:347
Test: crashpad_util_test MacUtil.MacOSVersionNumber
Change-Id: I90124b22774f7fac3dce88c06500a71ad7a71cb2
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2402248
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
GitOrigin-RevId: 9a5a789123d7528d1c1cb71e66134fe0d7a9d37a