| commit | 4fc500aa1596a40bd080e1c5aaeea6c1da1b0e51 | [log] [tgz] |
|---|---|---|
| author | Mark Mentovai <mark@chromium.org> | Tue Apr 21 11:56:57 2020 -0400 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Jan 19 06:51:44 2021 -0800 |
| tree | cf07d78f43605ef937e248574077a5ec89efa41d | |
| parent | de3ecd910a6812de864a7e97c550d57d61af883c [diff] |
ios: Run mig with the correct SDK and architecture mig was being invoked without any -arch argument, causing it to assume the build system’s native architecture, which would be x86_64. This is not correct for iOS device builds, which use arm64. The -arch argument must be plumbed to mig for correct behavior. When building for iOS, mig was being invoked without any -isysroot argument, causing it to use the root for the build system, which runs macOS and not iOS. The macOS SDK doesn’t include the ARM definitions needed for iOS device builds. <mach/exc.defs> and <mach/mach_exc.defs> depend on a small number of other .defs files to provide definitions of standard types. All .defs files are absent from the iOS SDK. These .defs files are borrowed from xnu and placed in third_party/xnu. An additional --include argument is added to allow mig to locate these files. Bug: crashpad:31 Change-Id: I2072a744c560683ed440421fb7e12156ccb3b5ab Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2159291 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> GitOrigin-RevId: 1bfd7d06ed6080861a23206e65ecd65c5b56c10f
Crashpad is a crash-reporting system.
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.