commit 14cdd65dd256b5734cef5c15ba645e72665ef6f3
author Catena cyber <35799796+catenacyber@users.noreply.github.com> Sun Jun 03 16:26:12 2018 +0200
committer Nguyen Anh Quynh <aquynh@gmail.com> Sun Jun 03 22:26:11 2018 +0800
tree 1b5d33c56440b29b7a3ee8abe537c51f96255014
parent 3f1141452e9afb51dbf85e231fdf9672edb7ca3b

fix undefined shift in countLeadingZeros (#1157)

MathExtras.h

diff --git a/MathExtras.h b/MathExtras.h
index db98a2f..2be6e08 100644
--- a/MathExtras.h
+++ b/MathExtras.h
@@ -425,14 +425,17 @@
 ///   valid arguments.
 static inline unsigned int countLeadingZeros(int x)
 {
-	unsigned count = 0;
 	int i;
 	const unsigned bits = sizeof(x) * 8;
+	unsigned count = bits;
 
+	if (x < 0) {
+		return 0;
+	}
 	for (i = bits; --i; ) {
-		if (x < 0) break;
-		count++;
-		x <<= 1;
+		if (x == 0) break;
+		count--;
+		x >>= 1;
 	}
 
 	return count;