Google Git
Sign in
fuchsia / third_party / android / platform / system / tools / aidl / 5376b50a13e8f5ffdb03494ca5ee7e3d33e824e0
commit5376b50a13e8f5ffdb03494ca5ee7e3d33e824e0[log] [tgz]
authorJiyong Park <jiyong@google.com>Thu Jul 09 23:04:34 2020 +0900
committerTreehugger Robot <treehugger-gerrit@google.com>Thu Jul 09 19:10:48 2020 +0000
tree1530e8db6ff726a24a9234dfc601fb567b2b75bf
parentcef2266197ea23a48c2931b2b082bfaa2b3d284f [diff]
Optimize checkDuplicatedVersions

Previously, the checkDuplicatedVersions mutator visited a node multiple
times. When the mutator is running for a module, the mutator visited all
of the transitive depmendencies of the module. As a result, modules that
are at the bottom of the dependency tree were visited a lot of times.

This change optimizes the behavior; now, each module visited only once.
When the mutator is running for a module, it gathers AIDL interface
modules that the module directly depends on. If there is any, the info
is recorded and is used in the later runs of the mutator.

Bug: 160855603
Test: measure the time spent for running the mutator by inserting some
time check routines around the runMutator function in blueprint.
1680ms -> 330ms in AOSP/aosp_arm64 target
Change-Id: Ib9b583a0ce01cd858652d0de650ca76c18c5b9cf
2 files changed
tree: 1530e8db6ff726a24a9234dfc601fb567b2b75bf
  1. build/
  2. metadata/
  3. tests/
  4. trace/
  5. .clang-format
  6. aidl.cpp
  7. aidl.h
  8. aidl_checkapi.cpp
  9. aidl_checkapi.h
  10. aidl_const_expressions.cpp
  11. aidl_language.cpp
  12. aidl_language.h
  13. aidl_language_l.ll
  14. aidl_language_y-module.h
  15. aidl_language_y.yy
  16. aidl_to_cpp.cpp
  17. aidl_to_cpp.h
  18. aidl_to_cpp_common.cpp
  19. aidl_to_cpp_common.h
  20. aidl_to_java.cpp
  21. aidl_to_java.h
  22. aidl_to_ndk.cpp
  23. aidl_to_ndk.h
  24. aidl_typenames.cpp
  25. aidl_typenames.h
  26. aidl_unittest.cpp
  27. Android.bp
  28. ast_cpp.cpp
  29. ast_cpp.h
  30. ast_cpp_unittest.cpp
  31. ast_java.cpp
  32. ast_java.h
  33. ast_java_unittest.cpp
  34. code_writer.cpp
  35. code_writer.h
  36. code_writer_unittest.cpp
  37. generate_aidl_mappings.cpp
  38. generate_aidl_mappings.h
  39. generate_cpp.cpp
  40. generate_cpp.h
  41. generate_cpp_unittest.cpp
  42. generate_java.cpp
  43. generate_java.h
  44. generate_java_binder.cpp
  45. generate_ndk.cpp
  46. generate_ndk.h
  47. hiddenapi-greylist
  48. import_resolver.cpp
  49. import_resolver.h
  50. io_delegate.cpp
  51. io_delegate.h
  52. io_delegate_unittest.cpp
  53. line_reader.cpp
  54. line_reader.h
  55. logging.h
  56. main.cpp
  57. NOTICE
  58. options.cpp
  59. options.h
  60. options_unittest.cpp
  61. os.h
  62. OWNERS
  63. parser.cpp
  64. parser.h
  65. PREUPLOAD.cfg
  66. README.md
  67. run_integration_tests.sh
  68. TEST_MAPPING
README.md

Documentation for this project is currently maintained here:

https://source.android.com/devices/architecture/aidl/overview