Google Git
Sign in
fuchsia / third_party / android.googlesource.com / platform / system / tools / hidl / 5538cccb766edb9259750efb8c57ec3e2b9a35b2
commit5538cccb766edb9259750efb8c57ec3e2b9a35b2[log] [tgz]
authorCole Faust <colefaust@google.com>Sat Oct 15 21:33:28 2022 -0700
committerCole Faust <colefaust@google.com>Sat Oct 15 21:38:43 2022 -0700
treeb87071c3bbe29ded20fa7539c557bee41dccd8ce
parent6df49244108ed0688be2860b309b467bbaa1cada [diff]
Fix errorprone warnings that should be errors

This commit is part of a large scale change to fix errorprone
errors that have been downgraded to warnings in the android
source tree, so that they can be promoted to errors again.
The full list of changes include the following, but not all
will be present in any one individual commit:

BadAnnotationImplementation
BadShiftAmount
BanJNDI
BoxedPrimitiveEquality
ComparableType
ComplexBooleanConstant
CollectionToArraySafeParameter
ConditionalExpressionNumericPromotion
DangerousLiteralNull
DoubleBraceInitialization
DurationFrom
DurationTemporalUnit
EmptyTopLevelDeclaration
EqualsNull
EqualsReference
FormatString
FromTemporalAccessor
GetClassOnAnnotation
GetClassOnClass
HashtableContains
IdentityBinaryExpression
IdentityHashMapBoxing
InstantTemporalUnit
InvalidTimeZoneID
InvalidZoneId
IsInstanceIncompatibleType
JUnitParameterMethodNotFound
LockOnBoxedPrimitive
MathRoundIntLong
MislabeledAndroidString
MisusedDayOfYear
MissingSuperCall
MisusedWeekYear
ModifyingCollectionWithItself
NoCanIgnoreReturnValueOnClasses
NonRuntimeAnnotation
NullableOnContainingClass
NullTernary
OverridesJavaxInjectableMethod
ParcelableCreator
PeriodFrom
PreconditionsInvalidPlaceholder
ProtoBuilderReturnValueIgnored
ProtoFieldNullComparison
RandomModInteger
RectIntersectReturnValueIgnored
ReturnValueIgnored
SelfAssignment
SelfComparison
SelfEquals
SizeGreaterThanOrEqualsZero
StringBuilderInitWithChar
TreeToString
TryFailThrowable
UnnecessaryCheckNotNull
UnusedCollectionModifiedInPlace
XorPower

See https://errorprone.info/bugpatterns for more
information on the checks.

Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: I0584059c6195f18e8a602ae5924ae4d76373535d
2 files changed
tree: b87071c3bbe29ded20fa7539c557bee41dccd8ce
  1. build/
  2. c2hal/
  3. hashing/
  4. hidl2aidl/
  5. host_utils/
  6. lint/
  7. metadata/
  8. scripts/
  9. test/
  10. utils/
  11. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format
  12. Android.bp
  13. Annotation.cpp
  14. Annotation.h
  15. ArrayType.cpp
  16. ArrayType.h
  17. AST.cpp
  18. AST.h
  19. CleanSpec.mk
  20. CompoundType.cpp
  21. CompoundType.h
  22. ConstantExpression.cpp
  23. ConstantExpression.h
  24. Coordinator.cpp
  25. Coordinator.h
  26. DeathRecipientType.cpp
  27. DeathRecipientType.h
  28. DocComment.cpp
  29. DocComment.h
  30. EnumType.cpp
  31. EnumType.h
  32. FmqType.cpp
  33. FmqType.h
  34. FormattingConstants.h
  35. generateCpp.cpp
  36. generateCppImpl.cpp
  37. generateDependencies.cpp
  38. generateFormattedHidl.cpp
  39. generateInheritanceHierarchy.cpp
  40. generateJava.cpp
  41. generateJavaImpl.cpp
  42. generateVts.cpp
  43. HandleType.cpp
  44. HandleType.h
  45. hidl-gen_l.h
  46. hidl-gen_l.ll
  47. hidl-gen_y-helpers.h
  48. hidl-gen_y.yy
  49. HidlTypeAssertion.cpp
  50. HidlTypeAssertion.h
  51. Interface.cpp
  52. Interface.h
  53. Location.cpp
  54. Location.h
  55. main.cpp
  56. MemoryType.cpp
  57. MemoryType.h
  58. Method.cpp
  59. Method.h
  60. NamedType.cpp
  61. NamedType.h
  62. NOTICE
  63. OWNERS
  64. PointerType.cpp
  65. PointerType.h
  66. PREUPLOAD.cfg
  67. README.md
  68. Reference.h
  69. ScalarType.cpp
  70. ScalarType.h
  71. Scope.cpp
  72. Scope.h
  73. StringType.cpp
  74. StringType.h
  75. TEST_MAPPING
  76. Type.cpp
  77. Type.h
  78. TypeDef.cpp
  79. TypeDef.h
  80. update-all-google-makefiles.sh
  81. update-makefiles-helper.sh
  82. VectorType.cpp
  83. VectorType.h
README.md

hidl-gen

Full documentation can be found here: https://source.android.com/devices/architecture/hidl/

hidl-gen is a compiler for the HIDL (HAL Interface Design Language) which generates C++ and Java endpoints for RPC mechanisms. The main userspace libraries which this compiler uses can be found at system/libhidl.

1. Build

m hidl-gen

2. Run

Note that options for hidl-gen expected to be invoked by the build system are marked with ‘internal’ in the help menu.

hidl-gen -h

hidl-gen -o output -L c++-impl -r android.hardware:hardware/interfaces -r android.hidl:system/libhidl/transport android.hardware.nfc@1.0

Some defaults for package roots are also provided

hidl-gen -o output -L c++-impl android.hardware.nfc@1.0
hidl-gen -o output -L vts android.hardware.nfc@1.0
hidl-gen -L hash android.hardware.nfc@1.0

Example command for vendor project

hidl-gen -L c++-impl -r vendor.foo:vendor/foo/interfaces vendor.foo.nfc@1.0

See update-makefiles-helper.sh and update-all-google-makefiles.sh for examples of how to generate HIDL makefiles (using the -Landroidbp option).

NOTE: When using the -Landroidbp option, you can force generated modules to be installed in /system_ext rather than other partition by putting a marker file .hidl_for_system_ext alongside *.hal files.

NOTE: You can also install the vendor variant of the generated modules to be installed in /odm rather than /vendor by putting a marker file .hidl_for_odm alongside *.hal files.

c2hal

This is a helper tool to convert C headers to valid .hal files.

m c2hal && c2hal -h