commit 1059af8ae14e0fc1679da43ca047152d2fc4de94
author Aleksandr Krasavin <akrasav@google.com> Tue Dec 17 01:19:04 2024 -0800
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Dec 17 01:19:04 2024 -0800
tree d70fb1bc18fb31fdf47be6784e35d2ebce66b3ee
parent 57506c9ad6e6081f947914b7c8601747b648b7e7
parent 17388679ee60432138327c65bbbf8337ae69234b

Merge "Fix pointer arithmetics in libufdt" into main

ufdt_overlay.c

diff --git a/ufdt_overlay.c b/ufdt_overlay.c
index 6fa8c31..9f23c57 100644
--- a/ufdt_overlay.c
+++ b/ufdt_overlay.c
@@ -290,6 +290,12 @@
 
     const char *fixups_paths = ufdt_node_get_fdt_prop_data(fixups, &len);
 
+    if (len == 0 || !fixups_paths || fixups_paths[len - 1] != 0) {
+      dto_error("Format error for %s: fixups are not null terminated\n",
+                ufdt_node_name(fixups));
+      return -1;
+    }
+
     if (ufdt_do_one_fixup(overlay_tree, fixups_paths, len, phandle) < 0) {
       dto_error("Failed one fixup in ufdt_do_one_fixup\n");
       return -1;