Google Git
Sign in
fuchsia / third_party / android.googlesource.com / platform / system / libbase / refs/heads/main
commit5701ebb8a162c3168673e54399572f2d192b2387[log] [tgz]
authorCaslyn Tonelli <caslyn@google.com>Wed Nov 08 19:04:06 2023 +0000
committerCaslyn Tonelli <caslyn@google.com>Wed Nov 08 19:56:15 2023 +0000
treea9a4dea1efa7bfa4a39678aaee392eeca0877000
parent63dee67277ed5d67441b5102d239a8c6e5aba5f8 [diff]
Revert "[third_party][android] Add -Wno-vla-cxx-extension"

This reverts commit 63dee67277ed5d67441b5102d239a8c6e5aba5f8.

Reason for revert: Did not resolve Clang errors - the cflags need to be specified elsewhere.

Original change's description:
> [third_party][android] Add -Wno-vla-cxx-extension
>
> Clang now warns for uses of variable length arrays (VLA) in C++.
> Suppress this warning for libbase/logging_splitters.h use of VLA.
>
> Bug: 135694
> Change-Id: Ic39be124458e4d516c595465e5d5ee384ccf6f3b
> Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/android.googlesource.com/platform/system/libbase/+/942518
> Reviewed-by: Petr Hosek <phosek@google.com>

Bug: 135694
Change-Id: Ie8e8bd268947e44ea5d25f5e55218696dc773e81
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/android.googlesource.com/platform/system/libbase/+/943518
Reviewed-by: RubberStamper 🤖 <android-build-ayeaye@system.gserviceaccount.com>
1 file changed
tree: a9a4dea1efa7bfa4a39678aaee392eeca0877000
  1. include/
  2. tidy/
  3. .clang-format ⇨ ../../build/soong/scripts/system-clang-format-2
  4. abi_compatibility.cpp
  5. Android.bp
  6. BUILD.gn
  7. chrono_utils.cpp
  8. chrono_utils_test.cpp
  9. cmsg.cpp
  10. cmsg_test.cpp
  11. CPPLINT.cfg
  12. endian_test.cpp
  13. errors_test.cpp
  14. errors_unix.cpp
  15. errors_windows.cpp
  16. expected_test.cpp
  17. file.cpp
  18. file_benchmark.cpp
  19. file_test.cpp
  20. format_benchmark.cpp
  21. function_ref_benchmark.cpp
  22. function_ref_test.cpp
  23. hex.cpp
  24. hex_test.cpp
  25. logging.cpp
  26. logging_splitters.h
  27. logging_splitters_test.cpp
  28. logging_test.cpp
  29. macros_test.cpp
  30. mapped_file.cpp
  31. mapped_file_test.cpp
  32. no_destructor_test.cpp
  33. NOTICE
  34. OWNERS
  35. parsebool.cpp
  36. parsebool_test.cpp
  37. parsedouble_test.cpp
  38. parseint_test.cpp
  39. parsenetaddress.cpp
  40. parsenetaddress_fuzzer.cpp
  41. parsenetaddress_fuzzer.dict
  42. parsenetaddress_test.cpp
  43. posix_strerror_r.cpp
  44. PREUPLOAD.cfg
  45. process.cpp
  46. process_test.cpp
  47. properties.cpp
  48. properties_test.cpp
  49. README.md
  50. result_test.cpp
  51. result_test_constraint.cpp
  52. scopeguard_test.cpp
  53. stringprintf.cpp
  54. stringprintf_test.cpp
  55. strings.cpp
  56. strings_test.cpp
  57. test_main.cpp
  58. TEST_MAPPING
  59. test_utils.cpp
  60. test_utils_test.cpp
  61. threads.cpp
  62. utf8.cpp
  63. utf8_test.cpp
README.md

libbase

Who is this library for?

This library is a collection of convenience functions to make common tasks easier and less error-prone.

In this context, “error-prone” covers both “hard to do correctly” and “hard to do with good performance”, but as a general purpose library, libbase's primary focus is on making it easier to do things easily and correctly when a compromise has to be made between “simplest API” on the one hand and “fastest implementation” on the other. Though obviously the ideal is to have both.

Should my routine be added?

The intention is to cover the 80% use cases, not be all things to all users.

If you have a routine that‘s really useful in your project, congratulations. But that doesn’t mean it should be here rather than just in your project.

The question for libbase is “should everyone be doing this?”/“does this make everyone's code cleaner/safer?”. Historically we've considered the bar for inclusion to be “are there at least three unrelated projects that would be cleaned up by doing so”.

If your routine is actually something from a future C++ standard (that isn‘t yet in libc++), or it’s widely used in another library, that helps show that there's precedent. Being able to say “so-and-so has used this API for n years” is a good way to reduce concerns about API choices.

Any other restrictions?

Unlike most Android code, code in libbase has to build for Mac and Windows too.

Code here is also expected to have good test coverage.

By its nature, it‘s difficult to change libbase API. It’s often best to start using your routine just in your project, and let it “graduate” after you're certain that the API is solid.