commit | 6216488884f4efef1b70ce9738b0926d9999bce2 | [log] [tgz] |
---|---|---|
author | Krzysztof Kosiński <krzysio@google.com> | Sat Jun 20 04:20:37 2020 -0700 |
committer | Krzysztof Kosiński <krzysio@google.com> | Tue Jun 23 11:38:21 2020 -0700 |
tree | a66dddab2881a43e03e5a1a8b688fddbcfcd28c3 | |
parent | 3976d637ee882c993c16359fa3f80fd7e051453c [diff] |
Improve the implementation of CHECK() macro. CHECK_EQ() currently does not work with smart pointers and nullptr. This is an attempt to improve the situation by improving the EagerEvaluator template. As a side benefit, the new implementation no longer uses macros to generate template specializations. The primary motivation of this change is to improve compatibility with logging macros from google3 (Google's internal monorepo) and make it easier to export code that was developed there to Android. Bug: 151119760 Test: atest --host libbase_test Change-Id: I9c957d5ddf2afb87a88304b1e4d7ceebea0fa2f8
This library is a collection of convenience functions to make common tasks easier and less error-prone.
In this context, “error-prone” covers both “hard to do correctly” and “hard to do with good performance”, but as a general purpose library, libbase's primary focus is on making it easier to do things easily and correctly when a compromise has to be made between “simplest API” on the one hand and “fastest implementation” on the other. Though obviously the ideal is to have both.
The intention is to cover the 80% use cases, not be all things to all users.
If you have a routine that‘s really useful in your project, congratulations. But that doesn’t mean it should be here rather than just in your project.
The question for libbase is “should everyone be doing this?”/“does this make everyone's code cleaner/safer?”. Historically we've considered the bar for inclusion to be “are there at least three unrelated projects that would be cleaned up by doing so”.
If your routine is actually something from a future C++ standard (that isn‘t yet in libc++), or it’s widely used in another library, that helps show that there's precedent. Being able to say “so-and-so has used this API for n years” is a good way to reduce concerns about API choices.
Unlike most Android code, code in libbase has to build for Mac and Windows too.
Code here is also expected to have good test coverage.
By its nature, it‘s difficult to change libbase API. It’s often best to start using your routine just in your project, and let it “graduate” after you're certain that the API is solid.