Google Git
Sign in
fuchsia / third_party / android.googlesource.com / platform / external / perfetto / 63ad74ac51b7de1a305c80c5766f21f94641dc10
commit63ad74ac51b7de1a305c80c5766f21f94641dc10[log] [tgz]
authorDeepanjan Roy <dproy@google.com>Fri Aug 20 11:17:13 2021 -0400
committerDeepanjan Roy <dproy@google.com>Fri Aug 20 11:17:13 2021 -0400
tree93f270ad9dd3766524a08e12fe7b01565688eb81
parent4328da9e58df9915a3c5097fc0da53f39e6aa3da [diff]
Do not use ScopedResource for FindFirstFile handle

The current usage of ScopedResource does not work for Android Studio
Profiler, because INVALID_HANDLE_VALUE under their compile configuration
is defined as ((HANDLE)(LONG_PTR)-1), which is a reinterpret_cast, and
reinterpret_casts cannot be used in constexpr. Template arguments are
required to be constexprs.

Since there is just one use case of this, it's easier to call FindClose
directly. If we have many more uses of FindFirstFile handle in the
future, we can look into defining a different scoped object for it.

Bug: 182165266
Change-Id: I27bc917643b1b13d4bfd4c1ad9299ee3324a2b08
2 files changed
tree: 93f270ad9dd3766524a08e12fe7b01565688eb81
  1. .github/
  2. bazel/
  3. build_overrides/
  4. buildtools/
  5. debian/
  6. docs/
  7. examples/
  8. gn/
  9. include/
  10. infra/
  11. protos/
  12. src/
  13. test/
  14. tools/
  15. ui/
  16. .clang-format
  17. .clang-tidy
  18. .gitattributes
  19. .gitignore
  20. .gn
  21. .style.yapf
  22. Android.bp
  23. Android.bp.extras
  24. BUILD
  25. BUILD.extras
  26. BUILD.gn
  27. CHANGELOG
  28. codereview.settings
  29. DIR_METADATA
  30. heapprofd.rc
  31. LICENSE
  32. meson.build
  33. METADATA
  34. MODULE_LICENSE_APACHE2
  35. OWNERS
  36. perfetto.rc
  37. PerfettoIntegrationTests.xml
  38. PRESUBMIT.py
  39. README.chromium
  40. README.md
  41. TEST_MAPPING
  42. traced_perf.rc
  43. WORKSPACE
README.md

Perfetto - System profiling, app tracing and trace analysis

Perfetto is a production-grade open-source stack for performance instrumentation and trace analysis. It offers services and libraries and for recording system-level and app-level traces, native + java heap profiling, a library for analyzing traces using SQL and a web-based UI to visualize and explore multi-GB traces.

See https://perfetto.dev/docs or the /docs/ directory for documentation.