| /* Copyright (c) 2015-2022 The Khronos Group Inc. |
| * Copyright (c) 2015-2022 Valve Corporation |
| * Copyright (c) 2015-2022 LunarG, Inc. |
| * Copyright (C) 2015-2022 Google Inc. |
| * |
| * Licensed under the Apache License, Version 2.0 (the "License"); |
| * you may not use this file except in compliance with the License. |
| * You may obtain a copy of the License at |
| * |
| * http://www.apache.org/licenses/LICENSE-2.0 |
| * |
| * Unless required by applicable law or agreed to in writing, software |
| * distributed under the License is distributed on an "AS IS" BASIS, |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| * See the License for the specific language governing permissions and |
| * limitations under the License. |
| * |
| * Author: Tobin Ehlis <tobine@google.com> |
| * John Zulauf <jzulauf@lunarg.com> |
| * Jeremy Kniager <jeremyk@lunarg.com> |
| * Jeremy Gebben <jeremyg@lunarg.com> |
| */ |
| |
| #include "core_validation_error_enums.h" |
| #include "core_validation.h" |
| #include "descriptor_sets.h" |
| |
| using DescriptorSet = cvdescriptorset::DescriptorSet; |
| using DescriptorSetLayout = cvdescriptorset::DescriptorSetLayout; |
| using DescriptorSetLayoutDef = cvdescriptorset::DescriptorSetLayoutDef; |
| using DescriptorSetLayoutId = cvdescriptorset::DescriptorSetLayoutId; |
| |
| // TODO: Find a way to add smarts to the autogenerated version of this |
| static std::string smart_string_VkShaderStageFlags(VkShaderStageFlags stage_flags) { |
| if (stage_flags == VK_SHADER_STAGE_ALL) { |
| return string_VkShaderStageFlagBits(VK_SHADER_STAGE_ALL); |
| } |
| |
| return string_VkShaderStageFlags(stage_flags); |
| } |
| |
| template <typename DSLayoutBindingA, typename DSLayoutBindingB> |
| bool ImmutableSamplersAreEqual(const DSLayoutBindingA &b1, const DSLayoutBindingB &b2) { |
| if (b1.pImmutableSamplers == b2.pImmutableSamplers) { |
| return true; |
| } else if (b1.pImmutableSamplers && b2.pImmutableSamplers) { |
| if ((b1.descriptorType == b2.descriptorType) && |
| ((b1.descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) || (b1.descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE)) && |
| (b1.descriptorCount == b2.descriptorCount)) { |
| for (uint32_t i = 0; i < b1.descriptorCount; ++i) { |
| if (b1.pImmutableSamplers[i] != b2.pImmutableSamplers[i]) { |
| return false; |
| } |
| } |
| return true; |
| } else { |
| return false; |
| } |
| } else { |
| // One pointer is null, the other is not |
| return false; |
| } |
| } |
| |
| // If our layout is compatible with bound_dsl, return true, |
| // else return false and fill in error_msg will description of what causes incompatibility |
| bool CoreChecks::VerifySetLayoutCompatibility(const DescriptorSetLayout &layout_dsl, const DescriptorSetLayout &bound_dsl, |
| std::string &error_msg) const { |
| // Short circuit the detailed check. |
| if (layout_dsl.IsCompatible(&bound_dsl)) return true; |
| |
| // Do a detailed compatibility check of this lhs def (referenced by layout_dsl), vs. the rhs (layout and def) |
| // Should only be run if trivial accept has failed, and in that context should return false. |
| VkDescriptorSetLayout layout_dsl_handle = layout_dsl.GetDescriptorSetLayout(); |
| VkDescriptorSetLayout bound_dsl_handle = bound_dsl.GetDescriptorSetLayout(); |
| DescriptorSetLayoutDef const *layout_ds_layout_def = layout_dsl.GetLayoutDef(); |
| DescriptorSetLayoutDef const *bound_ds_layout_def = bound_dsl.GetLayoutDef(); |
| |
| // Check descriptor counts |
| const auto bound_total_count = bound_ds_layout_def->GetTotalDescriptorCount(); |
| if (layout_ds_layout_def->GetTotalDescriptorCount() != bound_ds_layout_def->GetTotalDescriptorCount()) { |
| std::stringstream error_str; |
| error_str << report_data->FormatHandle(layout_dsl_handle) << " from pipeline layout has " |
| << layout_ds_layout_def->GetTotalDescriptorCount() << " total descriptors, but " |
| << report_data->FormatHandle(bound_dsl_handle) << ", which is bound, has " << bound_total_count |
| << " total descriptors."; |
| error_msg = error_str.str(); |
| return false; // trivial fail case |
| } |
| |
| // Descriptor counts match so need to go through bindings one-by-one |
| // and verify that type and stageFlags match |
| for (const auto &layout_binding : layout_ds_layout_def->GetBindings()) { |
| const auto bound_binding = bound_ds_layout_def->GetBindingInfoFromBinding(layout_binding.binding); |
| if (layout_binding.descriptorCount != bound_binding->descriptorCount) { |
| std::stringstream error_str; |
| error_str << "Binding " << layout_binding.binding << " for " << report_data->FormatHandle(layout_dsl_handle) |
| << " from pipeline layout has a descriptorCount of " << layout_binding.descriptorCount << " but binding " |
| << layout_binding.binding << " for " << report_data->FormatHandle(bound_dsl_handle) |
| << ", which is bound, has a descriptorCount of " << bound_binding->descriptorCount; |
| error_msg = error_str.str(); |
| return false; |
| } else if (layout_binding.descriptorType != bound_binding->descriptorType) { |
| std::stringstream error_str; |
| error_str << "Binding " << layout_binding.binding << " for " << report_data->FormatHandle(layout_dsl_handle) |
| << " from pipeline layout is type '" << string_VkDescriptorType(layout_binding.descriptorType) |
| << "' but binding " << layout_binding.binding << " for " << report_data->FormatHandle(bound_dsl_handle) |
| << ", which is bound, is type '" << string_VkDescriptorType(bound_binding->descriptorType) << "'"; |
| error_msg = error_str.str(); |
| return false; |
| } else if (layout_binding.stageFlags != bound_binding->stageFlags) { |
| std::stringstream error_str; |
| error_str << "Binding " << layout_binding.binding << " for " << report_data->FormatHandle(layout_dsl_handle) |
| << " from pipeline layout has stageFlags " << smart_string_VkShaderStageFlags(layout_binding.stageFlags) |
| << " but binding " << layout_binding.binding << " for " << report_data->FormatHandle(bound_dsl_handle) |
| << ", which is bound, has stageFlags " << smart_string_VkShaderStageFlags(bound_binding->stageFlags); |
| error_msg = error_str.str(); |
| return false; |
| } else if (!ImmutableSamplersAreEqual(layout_binding, *bound_binding)) { |
| error_msg = "Immutable samplers from binding " + std::to_string(layout_binding.binding) + " in pipeline layout " + |
| report_data->FormatHandle(layout_dsl_handle) + |
| " do not match the immutable samplers in the layout currently bound (" + |
| report_data->FormatHandle(bound_dsl_handle) + ")"; |
| return false; |
| } |
| } |
| |
| const auto &ds_layout_flags = layout_ds_layout_def->GetBindingFlags(); |
| const auto &bound_layout_flags = bound_ds_layout_def->GetBindingFlags(); |
| if (bound_layout_flags != ds_layout_flags) { |
| std::stringstream error_str; |
| assert(ds_layout_flags.size() == bound_layout_flags.size()); |
| size_t i; |
| for (i = 0; i < ds_layout_flags.size(); i++) { |
| if (ds_layout_flags[i] != bound_layout_flags[i]) break; |
| } |
| error_str << report_data->FormatHandle(layout_dsl_handle) |
| << " from pipeline layout does not have the same binding flags at binding " << i << " ( " |
| << string_VkDescriptorBindingFlagsEXT(ds_layout_flags[i]) << " ) as " |
| << report_data->FormatHandle(bound_dsl_handle) << " ( " |
| << string_VkDescriptorBindingFlagsEXT(bound_layout_flags[i]) << " ), which is bound"; |
| error_msg = error_str.str(); |
| return false; |
| } |
| |
| // No detailed check should succeed if the trivial check failed -- or the dictionary has failed somehow. |
| bool compatible = true; |
| assert(!compatible); |
| return compatible; |
| } |
| |
| // For given cvdescriptorset::DescriptorSet, verify that its Set is compatible w/ the setLayout corresponding to |
| // pipelineLayout[layoutIndex] |
| bool CoreChecks::VerifySetLayoutCompatibility(const cvdescriptorset::DescriptorSet &descriptor_set, |
| const PIPELINE_LAYOUT_STATE &pipeline_layout, const uint32_t layoutIndex, |
| std::string &errorMsg) const { |
| auto num_sets = pipeline_layout.set_layouts.size(); |
| if (layoutIndex >= num_sets) { |
| std::stringstream error_str; |
| error_str << report_data->FormatHandle(pipeline_layout.layout()) << ") only contains " << num_sets |
| << " setLayouts corresponding to sets 0-" << num_sets - 1 << ", but you're attempting to bind set to index " |
| << layoutIndex; |
| errorMsg = error_str.str(); |
| return false; |
| } |
| if (descriptor_set.IsPushDescriptor()) return true; |
| const auto *layout_node = pipeline_layout.set_layouts[layoutIndex].get(); |
| if (layout_node && (descriptor_set.GetBindingCount() > 0) && (layout_node->GetBindingCount() > 0)) { |
| return VerifySetLayoutCompatibility(*layout_node, *descriptor_set.GetLayout(), errorMsg); |
| } else { |
| // It's possible the DSL is null when creating a graphics pipeline library, in which case we can't verify compatibility |
| // here. |
| return true; |
| } |
| } |
| |
| bool CoreChecks::PreCallValidateCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, |
| VkPipelineLayout layout, uint32_t firstSet, uint32_t setCount, |
| const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, |
| const uint32_t *pDynamicOffsets) const { |
| auto cb_state = GetRead<CMD_BUFFER_STATE>(commandBuffer); |
| assert(cb_state); |
| bool skip = false; |
| skip |= ValidateCmd(cb_state.get(), CMD_BINDDESCRIPTORSETS); |
| // Track total count of dynamic descriptor types to make sure we have an offset for each one |
| uint32_t total_dynamic_descriptors = 0; |
| std::string error_string = ""; |
| |
| auto pipeline_layout = Get<PIPELINE_LAYOUT_STATE>(layout); |
| for (uint32_t set_idx = 0; set_idx < setCount; set_idx++) { |
| auto descriptor_set = Get<cvdescriptorset::DescriptorSet>(pDescriptorSets[set_idx]); |
| if (descriptor_set) { |
| // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout |
| if (!VerifySetLayoutCompatibility(*descriptor_set, *pipeline_layout, set_idx + firstSet, error_string)) { |
| skip |= LogError(pDescriptorSets[set_idx], "VUID-vkCmdBindDescriptorSets-pDescriptorSets-00358", |
| "vkCmdBindDescriptorSets(): descriptorSet #%u being bound is not compatible with overlapping " |
| "descriptorSetLayout at index %u of " |
| "%s due to: %s.", |
| set_idx, set_idx + firstSet, report_data->FormatHandle(layout).c_str(), error_string.c_str()); |
| } |
| |
| auto set_dynamic_descriptor_count = descriptor_set->GetDynamicDescriptorCount(); |
| if (set_dynamic_descriptor_count) { |
| // First make sure we won't overstep bounds of pDynamicOffsets array |
| if ((total_dynamic_descriptors + set_dynamic_descriptor_count) > dynamicOffsetCount) { |
| // Test/report this here, such that we don't run past the end of pDynamicOffsets in the else clause |
| skip |= |
| LogError(pDescriptorSets[set_idx], "VUID-vkCmdBindDescriptorSets-dynamicOffsetCount-00359", |
| "vkCmdBindDescriptorSets(): descriptorSet #%u (%s) requires %u dynamicOffsets, but only %u " |
| "dynamicOffsets are left in " |
| "pDynamicOffsets array. There must be one dynamic offset for each dynamic descriptor being bound.", |
| set_idx, report_data->FormatHandle(pDescriptorSets[set_idx]).c_str(), |
| descriptor_set->GetDynamicDescriptorCount(), (dynamicOffsetCount - total_dynamic_descriptors)); |
| // Set the number found to the maximum to prevent duplicate messages, or subsquent descriptor sets from |
| // testing against the "short tail" we're skipping below. |
| total_dynamic_descriptors = dynamicOffsetCount; |
| } else { // Validate dynamic offsets and Dynamic Offset Minimums |
| // offset for all sets (pDynamicOffsets) |
| uint32_t cur_dyn_offset = total_dynamic_descriptors; |
| // offset into this descriptor set |
| uint32_t set_dyn_offset = 0; |
| const auto &dsl = descriptor_set->GetLayout(); |
| const auto binding_count = dsl->GetBindingCount(); |
| const auto &limits = phys_dev_props.limits; |
| for (uint32_t i = 0; i < binding_count; i++) { |
| const auto *binding = dsl->GetDescriptorSetLayoutBindingPtrFromIndex(i); |
| // skip checking binding if not needed |
| if (cvdescriptorset::IsDynamicDescriptor(binding->descriptorType) == false) { |
| continue; |
| } |
| |
| // If a descriptor set has only binding 0 and 2 the binding_index will be 0 and 2 |
| const uint32_t binding_index = binding->binding; |
| const uint32_t descriptorCount = binding->descriptorCount; |
| |
| // Need to loop through each descriptor count inside the binding |
| // if descriptorCount is zero the binding with a dynamic descriptor type does not count |
| for (uint32_t j = 0; j < descriptorCount; j++) { |
| const uint32_t offset = pDynamicOffsets[cur_dyn_offset]; |
| if (offset == 0) { |
| // offset of zero is equivalent of not having the dynamic offset |
| cur_dyn_offset++; |
| set_dyn_offset++; |
| continue; |
| } |
| |
| // Validate alignment with limit |
| if ((binding->descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) && |
| (SafeModulo(offset, limits.minUniformBufferOffsetAlignment) != 0)) { |
| skip |= LogError(commandBuffer, "VUID-vkCmdBindDescriptorSets-pDynamicOffsets-01971", |
| "vkCmdBindDescriptorSets(): pDynamicOffsets[%u] is %u, but must be a multiple of " |
| "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".", |
| cur_dyn_offset, offset, limits.minUniformBufferOffsetAlignment); |
| } |
| if ((binding->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) && |
| (SafeModulo(offset, limits.minStorageBufferOffsetAlignment) != 0)) { |
| skip |= LogError(commandBuffer, "VUID-vkCmdBindDescriptorSets-pDynamicOffsets-01972", |
| "vkCmdBindDescriptorSets(): pDynamicOffsets[%u] is %u, but must be a multiple of " |
| "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".", |
| cur_dyn_offset, offset, limits.minStorageBufferOffsetAlignment); |
| } |
| |
| auto *descriptor = descriptor_set->GetDescriptorFromDynamicOffsetIndex(set_dyn_offset); |
| assert(descriptor != nullptr); |
| // Currently only GeneralBuffer are dynamic and need to be checked |
| if (descriptor->GetClass() == cvdescriptorset::DescriptorClass::GeneralBuffer) { |
| const auto *buffer_descriptor = static_cast<const cvdescriptorset::BufferDescriptor *>(descriptor); |
| const VkDeviceSize bound_range = buffer_descriptor->GetRange(); |
| const VkDeviceSize bound_offset = buffer_descriptor->GetOffset(); |
| // NOTE: null / invalid buffers may show up here, errors are raised elsewhere for this. |
| auto buffer_state = buffer_descriptor->GetBufferState(); |
| |
| // Validate offset didn't go over buffer |
| if ((bound_range == VK_WHOLE_SIZE) && (offset > 0)) { |
| LogObjectList objlist(commandBuffer); |
| objlist.add(pDescriptorSets[set_idx]); |
| objlist.add(buffer_descriptor->GetBuffer()); |
| skip |= |
| LogError(objlist, "VUID-vkCmdBindDescriptorSets-pDescriptorSets-06715", |
| "vkCmdBindDescriptorSets(): pDynamicOffsets[%u] is 0x%x, but must be zero since " |
| "the buffer descriptor's range is VK_WHOLE_SIZE in descriptorSet #%u binding #%u " |
| "descriptor[%u].", |
| cur_dyn_offset, offset, set_idx, binding_index, j); |
| |
| } else if (buffer_state && (bound_range != VK_WHOLE_SIZE) && |
| ((offset + bound_range + bound_offset) > buffer_state->createInfo.size)) { |
| LogObjectList objlist(commandBuffer); |
| objlist.add(pDescriptorSets[set_idx]); |
| objlist.add(buffer_descriptor->GetBuffer()); |
| skip |= |
| LogError(objlist, "VUID-vkCmdBindDescriptorSets-pDescriptorSets-01979", |
| "vkCmdBindDescriptorSets(): pDynamicOffsets[%u] is 0x%x which when added to the " |
| "buffer descriptor's range (0x%" PRIxLEAST64 |
| ") is greater than the size of the buffer (0x%" PRIxLEAST64 |
| ") in descriptorSet #%u binding #%u descriptor[%u].", |
| cur_dyn_offset, offset, bound_range, buffer_state->createInfo.size, set_idx, |
| binding_index, j); |
| } |
| } |
| cur_dyn_offset++; |
| set_dyn_offset++; |
| } // descriptorCount loop |
| } // bindingCount loop |
| // Keep running total of dynamic descriptor count to verify at the end |
| total_dynamic_descriptors += set_dynamic_descriptor_count; |
| } |
| } |
| if (descriptor_set->GetPoolState()->createInfo.flags & VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_EXT) { |
| skip |= LogError(pDescriptorSets[set_idx], "VUID-vkCmdBindDescriptorSets-pDescriptorSets-04616", |
| "vkCmdBindDescriptorSets(): pDescriptorSets[%" PRIu32 |
| "] was allocated from a pool that was created with VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_EXT.", |
| set_idx); |
| } |
| } else { |
| if (!IsExtEnabled(device_extensions.vk_ext_graphics_pipeline_library)) { |
| skip |= LogError(pDescriptorSets[set_idx], "VUID-vkCmdBindDescriptorSets-pDescriptorSets-06563", |
| "vkCmdBindDescriptorSets(): Attempt to bind pDescriptorSets[%" PRIu32 |
| "] (%s) that does not exist, and %s is not enabled.", |
| set_idx, report_data->FormatHandle(pDescriptorSets[set_idx]).c_str(), |
| VK_EXT_GRAPHICS_PIPELINE_LIBRARY_EXTENSION_NAME); |
| } else if (!enabled_features.graphics_pipeline_library_features.graphicsPipelineLibrary) { |
| skip |= LogError(pDescriptorSets[set_idx], "VUID-vkCmdBindDescriptorSets-graphicsPipelineLibrary-06754", |
| "vkCmdBindDescriptorSets(): Attempt to bind pDescriptorSets[%" PRIu32 |
| "] (%s) that does not exist, and the layout was not created " |
| "VK_PIPELINE_LAYOUT_CREATE_INDEPENDENT_SETS_BIT_EXT.", |
| set_idx, report_data->FormatHandle(pDescriptorSets[set_idx]).c_str()); |
| } |
| } |
| } |
| // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound |
| if (total_dynamic_descriptors != dynamicOffsetCount) { |
| skip |= LogError(cb_state->commandBuffer(), "VUID-vkCmdBindDescriptorSets-dynamicOffsetCount-00359", |
| "vkCmdBindDescriptorSets(): Attempting to bind %u descriptorSets with %u dynamic descriptors, but " |
| "dynamicOffsetCount is %u. It should " |
| "exactly match the number of dynamic descriptors.", |
| setCount, total_dynamic_descriptors, dynamicOffsetCount); |
| } |
| // firstSet and descriptorSetCount sum must be less than setLayoutCount |
| if ((firstSet + setCount) > static_cast<uint32_t>(pipeline_layout->set_layouts.size())) { |
| skip |= LogError(cb_state->commandBuffer(), "VUID-vkCmdBindDescriptorSets-firstSet-00360", |
| "vkCmdBindDescriptorSets(): Sum of firstSet (%u) and descriptorSetCount (%u) is greater than " |
| "VkPipelineLayoutCreateInfo::setLayoutCount " |
| "(%zu) when pipeline layout was created", |
| firstSet, setCount, pipeline_layout->set_layouts.size()); |
| } |
| |
| static const std::map<VkPipelineBindPoint, std::string> bindpoint_errors = { |
| std::make_pair(VK_PIPELINE_BIND_POINT_GRAPHICS, "VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00361"), |
| std::make_pair(VK_PIPELINE_BIND_POINT_COMPUTE, "VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00361"), |
| std::make_pair(VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR, "VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00361")}; |
| skip |= ValidatePipelineBindPoint(cb_state.get(), pipelineBindPoint, "vkCmdBindPipeline()", bindpoint_errors); |
| |
| return skip; |
| } |
| |
| bool CoreChecks::PreCallValidateCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, |
| VkDescriptorSetLayout *pSetLayout) const { |
| bool skip = false; |
| layer_data::unordered_set<uint32_t> bindings; |
| uint64_t total_descriptors = 0; |
| |
| const auto *flags_pCreateInfo = LvlFindInChain<VkDescriptorSetLayoutBindingFlagsCreateInfo>(pCreateInfo->pNext); |
| const bool push_descriptor_set = (pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR) != 0; |
| |
| uint32_t max_binding = 0; |
| |
| uint32_t update_after_bind = pCreateInfo->bindingCount; |
| uint32_t uniform_buffer_dynamic = pCreateInfo->bindingCount; |
| uint32_t storage_buffer_dynamic = pCreateInfo->bindingCount; |
| |
| for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) { |
| const auto &binding_info = pCreateInfo->pBindings[i]; |
| max_binding = std::max(max_binding, binding_info.binding); |
| |
| if (!bindings.insert(binding_info.binding).second) { |
| skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-binding-00279", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] has duplicated binding number (%u).", i, |
| binding_info.binding); |
| } |
| |
| if (binding_info.descriptorType == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT) { |
| if (!enabled_features.core13.inlineUniformBlock) { |
| skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-04604", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] is creating VkDescriptorSetLayout with " |
| "descriptor type VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT " |
| "but the inlineUniformBlock feature is not enabled", |
| i); |
| } else if (push_descriptor_set) { |
| skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-02208", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] is creating VkDescriptorSetLayout with descriptor " |
| "type VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT but " |
| "VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR flag is set", |
| i); |
| } else { |
| if ((binding_info.descriptorCount % 4) != 0) { |
| skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-02209", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] has descriptorCount =(%" PRIu32 |
| ") but must be a multiple of 4", |
| i, binding_info.descriptorCount); |
| } |
| if (binding_info.descriptorCount > phys_dev_ext_props.inline_uniform_block_props.maxInlineUniformBlockSize) { |
| skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-02210", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] has descriptorCount =(%" PRIu32 |
| ") but must be less than or equal to maxInlineUniformBlockSize (%u)", |
| i, binding_info.descriptorCount, |
| phys_dev_ext_props.inline_uniform_block_props.maxInlineUniformBlockSize); |
| } |
| } |
| } else if (binding_info.descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { |
| uniform_buffer_dynamic = i; |
| if (push_descriptor_set) { |
| skip |= LogError( |
| device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-00280", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] is creating VkDescriptorSetLayout with descriptor type " |
| "VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT but VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC flag is set", |
| i); |
| } |
| } else if (binding_info.descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { |
| storage_buffer_dynamic = i; |
| if (push_descriptor_set) { |
| skip |= LogError( |
| device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-00280", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] is creating VkDescriptorSetLayout with descriptor type " |
| "VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT but VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC flag is set", |
| i); |
| } |
| } |
| |
| if ((binding_info.descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER || |
| binding_info.descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) && |
| binding_info.pImmutableSamplers && IsExtEnabled(device_extensions.vk_ext_custom_border_color)) { |
| for (uint32_t j = 0; j < binding_info.descriptorCount; j++) { |
| auto sampler_state = Get<SAMPLER_STATE>(binding_info.pImmutableSamplers[j]); |
| if (sampler_state && (sampler_state->createInfo.borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT || |
| sampler_state->createInfo.borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT)) { |
| skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-pImmutableSamplers-04009", |
| "vkCreateDescriptorSetLayout(): pBindings[%u].pImmutableSamplers[%u] has VkSampler %s" |
| " presented as immutable has a custom border color", |
| i, j, report_data->FormatHandle(binding_info.pImmutableSamplers[j]).c_str()); |
| } |
| } |
| } |
| |
| if (binding_info.descriptorType == VK_DESCRIPTOR_TYPE_MUTABLE_EXT && binding_info.pImmutableSamplers != nullptr) { |
| skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-04605", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] has descriptorType " |
| "VK_DESCRIPTOR_TYPE_MUTABLE_EXT but pImmutableSamplers is not NULL.", |
| i); |
| } |
| |
| total_descriptors += binding_info.descriptorCount; |
| } |
| |
| if (flags_pCreateInfo) { |
| if (flags_pCreateInfo->bindingCount != 0 && flags_pCreateInfo->bindingCount != pCreateInfo->bindingCount) { |
| skip |= LogError(device, "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-bindingCount-03002", |
| "vkCreateDescriptorSetLayout(): VkDescriptorSetLayoutCreateInfo::bindingCount (%d) != " |
| "VkDescriptorSetLayoutBindingFlagsCreateInfo::bindingCount (%d)", |
| pCreateInfo->bindingCount, flags_pCreateInfo->bindingCount); |
| } |
| |
| if (flags_pCreateInfo->bindingCount == pCreateInfo->bindingCount) { |
| for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) { |
| const auto &binding_info = pCreateInfo->pBindings[i]; |
| |
| if (flags_pCreateInfo->pBindingFlags[i] & VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT) { |
| update_after_bind = i; |
| if ((pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT) == 0) { |
| skip |= LogError( |
| device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-03000", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] has VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT but the " |
| "set layout does not have the VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT flag set.", |
| i); |
| } |
| |
| if (binding_info.descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER && |
| !enabled_features.core12.descriptorBindingUniformBufferUpdateAfterBind) { |
| skip |= LogError( |
| device, |
| "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-" |
| "descriptorBindingUniformBufferUpdateAfterBind-03005", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] can't have VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT " |
| "for %s since descriptorBindingUniformBufferUpdateAfterBind is not enabled.", |
| i, string_VkDescriptorType(binding_info.descriptorType)); |
| } |
| if ((binding_info.descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER || |
| binding_info.descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER || |
| binding_info.descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) && |
| !enabled_features.core12.descriptorBindingSampledImageUpdateAfterBind) { |
| skip |= LogError( |
| device, |
| "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-" |
| "descriptorBindingSampledImageUpdateAfterBind-03006", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] can't have VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT " |
| "for %s since descriptorBindingSampledImageUpdateAfterBind is not enabled.", |
| i, string_VkDescriptorType(binding_info.descriptorType)); |
| } |
| if (binding_info.descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE && |
| !enabled_features.core12.descriptorBindingStorageImageUpdateAfterBind) { |
| skip |= LogError( |
| device, |
| "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-" |
| "descriptorBindingStorageImageUpdateAfterBind-03007", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] can't have VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT " |
| "for %s since descriptorBindingStorageImageUpdateAfterBind is not enabled.", |
| i, string_VkDescriptorType(binding_info.descriptorType)); |
| } |
| if (binding_info.descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER && |
| !enabled_features.core12.descriptorBindingStorageBufferUpdateAfterBind) { |
| skip |= LogError( |
| device, |
| "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-" |
| "descriptorBindingStorageBufferUpdateAfterBind-03008", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] can't have VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT " |
| "for %s since descriptorBindingStorageBufferUpdateAfterBind is not enabled.", |
| i, string_VkDescriptorType(binding_info.descriptorType)); |
| } |
| if (binding_info.descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER && |
| !enabled_features.core12.descriptorBindingUniformTexelBufferUpdateAfterBind) { |
| skip |= LogError( |
| device, |
| "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-" |
| "descriptorBindingUniformTexelBufferUpdateAfterBind-03009", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] can't have VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT " |
| "for %s since descriptorBindingUniformTexelBufferUpdateAfterBind is not enabled.", |
| i, string_VkDescriptorType(binding_info.descriptorType)); |
| } |
| if (binding_info.descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER && |
| !enabled_features.core12.descriptorBindingStorageTexelBufferUpdateAfterBind) { |
| skip |= LogError( |
| device, |
| "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-" |
| "descriptorBindingStorageTexelBufferUpdateAfterBind-03010", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] can't have VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT " |
| "for %s since descriptorBindingStorageTexelBufferUpdateAfterBind is not enabled.", |
| i, string_VkDescriptorType(binding_info.descriptorType)); |
| } |
| if ((binding_info.descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT || |
| binding_info.descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC || |
| binding_info.descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { |
| skip |= LogError(device, "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-None-03011", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] can't have " |
| "VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT for %s.", |
| i, string_VkDescriptorType(binding_info.descriptorType)); |
| } |
| |
| if (binding_info.descriptorType == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT && |
| !enabled_features.core13.descriptorBindingInlineUniformBlockUpdateAfterBind) { |
| skip |= LogError( |
| device, |
| "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-" |
| "descriptorBindingInlineUniformBlockUpdateAfterBind-02211", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] can't have VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT " |
| "for %s since descriptorBindingInlineUniformBlockUpdateAfterBind is not enabled.", |
| i, string_VkDescriptorType(binding_info.descriptorType)); |
| } |
| if ((binding_info.descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR || |
| binding_info.descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV) && |
| !enabled_features.ray_tracing_acceleration_structure_features |
| .descriptorBindingAccelerationStructureUpdateAfterBind) { |
| skip |= LogError(device, |
| "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-" |
| "descriptorBindingAccelerationStructureUpdateAfterBind-03570", |
| "vkCreateDescriptorSetLayout(): pBindings[%" PRIu32 |
| "] can't have VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT " |
| "for %s if " |
| "VkPhysicalDeviceAccelerationStructureFeaturesKHR::" |
| "descriptorBindingAccelerationStructureUpdateAfterBind is not enabled.", |
| i, string_VkDescriptorType(binding_info.descriptorType)); |
| } |
| } |
| |
| if (flags_pCreateInfo->pBindingFlags[i] & VK_DESCRIPTOR_BINDING_UPDATE_UNUSED_WHILE_PENDING_BIT) { |
| if (!enabled_features.core12.descriptorBindingUpdateUnusedWhilePending) { |
| skip |= LogError( |
| device, |
| "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-descriptorBindingUpdateUnusedWhilePending-03012", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] can't have " |
| "VK_DESCRIPTOR_BINDING_UPDATE_UNUSED_WHILE_PENDING_BIT for %s since " |
| "descriptorBindingUpdateUnusedWhilePending is not enabled.", |
| i, string_VkDescriptorType(binding_info.descriptorType)); |
| } |
| } |
| |
| if (flags_pCreateInfo->pBindingFlags[i] & VK_DESCRIPTOR_BINDING_PARTIALLY_BOUND_BIT) { |
| if (!enabled_features.core12.descriptorBindingPartiallyBound) { |
| skip |= LogError( |
| device, "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-descriptorBindingPartiallyBound-03013", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] can't have VK_DESCRIPTOR_BINDING_PARTIALLY_BOUND_BIT for " |
| "%s since descriptorBindingPartiallyBound is not enabled.", |
| i, string_VkDescriptorType(binding_info.descriptorType)); |
| } |
| } |
| |
| if (flags_pCreateInfo->pBindingFlags[i] & VK_DESCRIPTOR_BINDING_VARIABLE_DESCRIPTOR_COUNT_BIT) { |
| if (binding_info.binding != max_binding) { |
| skip |= LogError( |
| device, "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-pBindingFlags-03004", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] has VK_DESCRIPTOR_BINDING_VARIABLE_DESCRIPTOR_COUNT_BIT " |
| "but %u is the largest value of all the bindings.", |
| i, binding_info.binding); |
| } |
| |
| if (!enabled_features.core12.descriptorBindingVariableDescriptorCount) { |
| skip |= LogError( |
| device, |
| "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-descriptorBindingVariableDescriptorCount-03014", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] can't have " |
| "VK_DESCRIPTOR_BINDING_VARIABLE_DESCRIPTOR_COUNT_BIT for %s since " |
| "descriptorBindingVariableDescriptorCount is not enabled.", |
| i, string_VkDescriptorType(binding_info.descriptorType)); |
| } |
| if ((binding_info.descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) || |
| (binding_info.descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { |
| skip |= LogError(device, "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-pBindingFlags-03015", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] can't have " |
| "VK_DESCRIPTOR_BINDING_VARIABLE_DESCRIPTOR_COUNT_BIT for %s.", |
| i, string_VkDescriptorType(binding_info.descriptorType)); |
| } |
| } |
| |
| if (push_descriptor_set && |
| (flags_pCreateInfo->pBindingFlags[i] & |
| (VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT | VK_DESCRIPTOR_BINDING_UPDATE_UNUSED_WHILE_PENDING_BIT | |
| VK_DESCRIPTOR_BINDING_VARIABLE_DESCRIPTOR_COUNT_BIT))) { |
| skip |= LogError( |
| device, "VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-flags-03003", |
| "vkCreateDescriptorSetLayout(): pBindings[%u] can't have VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT, " |
| "VK_DESCRIPTOR_BINDING_UPDATE_UNUSED_WHILE_PENDING_BIT, or " |
| "VK_DESCRIPTOR_BINDING_VARIABLE_DESCRIPTOR_COUNT_BIT for with " |
| "VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR.", |
| i); |
| } |
| } |
| } |
| } |
| |
| if (update_after_bind < pCreateInfo->bindingCount) { |
| if (uniform_buffer_dynamic < pCreateInfo->bindingCount) { |
| skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-descriptorType-03001", |
| "vkCreateDescriptorSetLayout(): binding (%" PRIi32 |
| ") has VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT " |
| "flag, but binding (%" PRIi32 ") has descriptor type VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC.", |
| update_after_bind, uniform_buffer_dynamic); |
| } |
| if (storage_buffer_dynamic < pCreateInfo->bindingCount) { |
| skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-descriptorType-03001", |
| "vkCreateDescriptorSetLayout(): binding (%" PRIi32 |
| ") has VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT " |
| "flag, but binding (%" PRIi32 ") has descriptor type VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC.", |
| update_after_bind, storage_buffer_dynamic); |
| } |
| } |
| |
| if ((push_descriptor_set) && (total_descriptors > phys_dev_ext_props.push_descriptor_props.maxPushDescriptors)) { |
| skip |= |
| LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-00281", |
| "vkCreateDescriptorSetLayout(): for push descriptor, total descriptor count in layout (%" PRIu64 |
| ") must not be greater than VkPhysicalDevicePushDescriptorPropertiesKHR::maxPushDescriptors (%" PRIu32 ").", |
| total_descriptors, phys_dev_ext_props.push_descriptor_props.maxPushDescriptors); |
| } |
| |
| return skip; |
| } |
| |
| static std::string StringDescriptorReqViewType(DescriptorReqFlags req) { |
| std::string result(""); |
| for (unsigned i = 0; i <= VK_IMAGE_VIEW_TYPE_CUBE_ARRAY; i++) { |
| if (req & (1 << i)) { |
| if (result.size()) result += ", "; |
| result += string_VkImageViewType(VkImageViewType(i)); |
| } |
| } |
| |
| if (!result.size()) result = "(none)"; |
| |
| return result; |
| } |
| |
| static char const *StringDescriptorReqComponentType(DescriptorReqFlags req) { |
| if (req & DESCRIPTOR_REQ_COMPONENT_TYPE_SINT) return "SINT"; |
| if (req & DESCRIPTOR_REQ_COMPONENT_TYPE_UINT) return "UINT"; |
| if (req & DESCRIPTOR_REQ_COMPONENT_TYPE_FLOAT) return "FLOAT"; |
| return "(none)"; |
| } |
| |
| unsigned DescriptorRequirementsBitsFromFormat(VkFormat fmt) { |
| if (FormatIsSINT(fmt)) return DESCRIPTOR_REQ_COMPONENT_TYPE_SINT; |
| if (FormatIsUINT(fmt)) return DESCRIPTOR_REQ_COMPONENT_TYPE_UINT; |
| // Formats such as VK_FORMAT_D16_UNORM_S8_UINT are both |
| if (FormatIsDepthAndStencil(fmt)) return DESCRIPTOR_REQ_COMPONENT_TYPE_FLOAT | DESCRIPTOR_REQ_COMPONENT_TYPE_UINT; |
| if (fmt == VK_FORMAT_UNDEFINED) return 0; |
| // everything else -- UNORM/SNORM/FLOAT/USCALED/SSCALED is all float in the shader. |
| return DESCRIPTOR_REQ_COMPONENT_TYPE_FLOAT; |
| } |
| |
| // Validate that the state of this set is appropriate for the given bindings and dynamic_offsets at Draw time |
| // This includes validating that all descriptors in the given bindings are updated, |
| // that any update buffers are valid, and that any dynamic offsets are within the bounds of their buffers. |
| // Return true if state is acceptable, or false and write an error message into error string |
| bool CoreChecks::ValidateDrawState(const DescriptorSet *descriptor_set, const BindingReqMap &bindings, |
| const std::vector<uint32_t> &dynamic_offsets, const CMD_BUFFER_STATE *cb_node, |
| const std::vector<IMAGE_VIEW_STATE *> *attachments, const std::vector<SUBPASS_INFO> *subpasses, |
| const char *caller, const DrawDispatchVuid &vuids) const { |
| layer_data::optional<layer_data::unordered_map<VkImageView, VkImageLayout>> checked_layouts; |
| if (descriptor_set->GetTotalDescriptorCount() > cvdescriptorset::PrefilterBindRequestMap::kManyDescriptors_) { |
| checked_layouts.emplace(); |
| } |
| bool result = false; |
| VkFramebuffer framebuffer = cb_node->activeFramebuffer ? cb_node->activeFramebuffer->framebuffer() : VK_NULL_HANDLE; |
| DescriptorContext context{caller, vuids, cb_node, descriptor_set, attachments, |
| subpasses, framebuffer, true, dynamic_offsets, checked_layouts}; |
| |
| for (const auto &binding_pair : bindings) { |
| const auto *binding = descriptor_set->GetBinding(binding_pair.first); |
| if (!binding) { // End at construction is the condition for an invalid binding. |
| auto set = descriptor_set->GetSet(); |
| result |= LogError(set, vuids.descriptor_valid, |
| "%s encountered the following validation error at %s time: Attempting to " |
| "validate DrawState for binding #%u which is an invalid binding for this descriptor set.", |
| report_data->FormatHandle(set).c_str(), caller, binding_pair.first); |
| return result; |
| } |
| |
| if (binding->IsBindless()) { |
| // Can't validate the descriptor because it may not have been updated, |
| // or the view could have been destroyed |
| continue; |
| } |
| result |= ValidateDescriptorSetBindingData(context, binding_pair, *binding); |
| } |
| return result; |
| } |
| |
| template <typename T> |
| bool CoreChecks::ValidateDescriptors(const DescriptorContext &context, const DescriptorBindingInfo &binding_info, |
| const T &binding) const { |
| bool skip = false; |
| for (uint32_t index = 0; !skip && index < binding.count; index++) { |
| const auto &descriptor = binding.descriptors[index]; |
| |
| if (!binding.updated[index]) { |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor in binding " |
| "#%" PRIu32 " index %" PRIu32 |
| " is being used in draw but has never been updated via vkUpdateDescriptorSets() or a similar call.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding_info.first, index); |
| } |
| skip = ValidateDescriptor(context, binding_info, index, binding.type, descriptor); |
| } |
| return skip; |
| } |
| |
| bool CoreChecks::ValidateDescriptorSetBindingData(const DescriptorContext &context, const DescriptorBindingInfo &binding_info, |
| const cvdescriptorset::DescriptorBinding &binding) const { |
| using DescriptorClass = cvdescriptorset::DescriptorClass; |
| bool skip = false; |
| switch (binding.descriptor_class) { |
| case DescriptorClass::InlineUniform: |
| // Can't validate the descriptor because it may not have been updated. |
| break; |
| case DescriptorClass::GeneralBuffer: |
| skip = ValidateDescriptors(context, binding_info, static_cast<const cvdescriptorset::BufferBinding &>(binding)); |
| break; |
| case DescriptorClass::ImageSampler: |
| skip = ValidateDescriptors(context, binding_info, static_cast<const cvdescriptorset::ImageSamplerBinding &>(binding)); |
| break; |
| case DescriptorClass::Image: |
| skip = ValidateDescriptors(context, binding_info, static_cast<const cvdescriptorset::ImageBinding &>(binding)); |
| break; |
| case DescriptorClass::PlainSampler: |
| skip = ValidateDescriptors(context, binding_info, static_cast<const cvdescriptorset::SamplerBinding &>(binding)); |
| break; |
| case DescriptorClass::TexelBuffer: |
| skip = ValidateDescriptors(context, binding_info, static_cast<const cvdescriptorset::TexelBinding &>(binding)); |
| break; |
| case DescriptorClass::AccelerationStructure: |
| skip = ValidateDescriptors(context, binding_info, |
| static_cast<const cvdescriptorset::AccelerationStructureBinding &>(binding)); |
| break; |
| default: |
| break; |
| } |
| return skip; |
| } |
| |
| bool CoreChecks::ValidateDescriptor(const DescriptorContext &context, const DescriptorBindingInfo &binding_info, uint32_t index, |
| VkDescriptorType descriptor_type, const cvdescriptorset::BufferDescriptor &descriptor) const { |
| // Verify that buffers are valid |
| auto buffer = descriptor.GetBuffer(); |
| auto buffer_node = descriptor.GetBufferState(); |
| if ((!buffer_node && !enabled_features.robustness2_features.nullDescriptor) || (buffer_node && buffer_node->Destroyed())) { |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor in " |
| "binding #%" PRIu32 " index %" PRIu32 " is using buffer %s that is invalid or has been destroyed.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding_info.first, index, |
| report_data->FormatHandle(buffer).c_str()); |
| } |
| if (buffer) { |
| if (buffer_node /* && !buffer_node->sparse*/) { |
| for (const auto &binding : buffer_node->GetInvalidMemory()) { |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor in " |
| "binding #%" PRIu32 " index %" PRIu32 " is uses buffer %s that references invalid memory %s.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding_info.first, index, |
| report_data->FormatHandle(buffer).c_str(), report_data->FormatHandle(binding->mem()).c_str()); |
| } |
| } |
| if (enabled_features.core11.protectedMemory == VK_TRUE) { |
| if (ValidateProtectedBuffer(context.cb_node, buffer_node, context.caller, context.vuids.unprotected_command_buffer, |
| "Buffer is in a descriptorSet")) { |
| return true; |
| } |
| if (binding_info.second.is_writable && |
| ValidateUnprotectedBuffer(context.cb_node, buffer_node, context.caller, context.vuids.protected_command_buffer, |
| "Buffer is in a descriptorSet")) { |
| return true; |
| } |
| } |
| } |
| return false; |
| } |
| |
| bool CoreChecks::ValidateDescriptor(const DescriptorContext &context, const DescriptorBindingInfo &binding_info, uint32_t index, |
| VkDescriptorType descriptor_type, const cvdescriptorset::ImageDescriptor &image_descriptor) const { |
| std::vector<const SAMPLER_STATE *> sampler_states; |
| VkImageView image_view = image_descriptor.GetImageView(); |
| const IMAGE_VIEW_STATE *image_view_state = image_descriptor.GetImageViewState(); |
| const auto binding = binding_info.first; |
| |
| if (image_descriptor.GetClass() == cvdescriptorset::DescriptorClass::ImageSampler) { |
| sampler_states.emplace_back( |
| static_cast<const cvdescriptorset::ImageSamplerDescriptor &>(image_descriptor).GetSamplerState()); |
| } else { |
| if (binding_info.second.samplers_used_by_image.size() > index) { |
| for (const auto &desc_index : binding_info.second.samplers_used_by_image[index]) { |
| const auto *desc = |
| context.descriptor_set->GetDescriptorFromBinding(desc_index.sampler_slot.binding, desc_index.sampler_index); |
| // NOTE: This check _shouldn't_ be necessary due to the checks made in IsSpecificDescriptorType in |
| // shader_validation.cpp. However, without this check some traces still crash. |
| if (desc && (desc->GetClass() == cvdescriptorset::DescriptorClass::PlainSampler)) { |
| const auto *sampler_state = static_cast<const cvdescriptorset::SamplerDescriptor *>(desc)->GetSamplerState(); |
| if (sampler_state) sampler_states.emplace_back(sampler_state); |
| } |
| } |
| } |
| } |
| |
| if ((!image_view_state && !enabled_features.robustness2_features.nullDescriptor) || |
| (image_view_state && image_view_state->Destroyed())) { |
| // Image view must have been destroyed since initial update. Could potentially flag the descriptor |
| // as "invalid" (updated = false) at DestroyImageView() time and detect this error at bind time |
| |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor in " |
| "binding #%" PRIu32 " index %" PRIu32 " is using imageView %s that is invalid or has been destroyed.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| report_data->FormatHandle(image_view).c_str()); |
| } |
| if (image_view) { |
| const auto reqs = binding_info.second.reqs; |
| const auto &image_view_ci = image_view_state->create_info; |
| |
| if (reqs & DESCRIPTOR_REQ_ALL_VIEW_TYPE_BITS) { |
| if (~reqs & (1 << image_view_ci.viewType)) { |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor " |
| "in binding #%" PRIu32 " index %" PRIu32 " requires an image view of type %s but got %s.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| StringDescriptorReqViewType(reqs).c_str(), string_VkImageViewType(image_view_ci.viewType)); |
| } |
| |
| if (!(reqs & image_view_state->descriptor_format_bits)) { |
| // bad component type |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: " |
| "Descriptor in binding " |
| "#%" PRIu32 " index %" PRIu32 " requires %s component type, but bound descriptor format is %s.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| StringDescriptorReqComponentType(reqs), string_VkFormat(image_view_ci.format)); |
| } |
| } |
| |
| // NOTE: Submit time validation of UPDATE_AFTER_BIND image layout is not possible with the |
| // image layout tracking as currently implemented, so only record_time_validation is done |
| if (!disabled[image_layout_validation] && context.record_time_validate) { |
| VkImageLayout image_layout = image_descriptor.GetImageLayout(); |
| // Verify Image Layout |
| // No "invalid layout" VUID required for this call, since the optimal_layout parameter is UNDEFINED. |
| // The caller provides a checked_layouts map when there are a large number of layouts to check, |
| // making it worthwhile to keep track of verified layouts and not recheck them. |
| bool already_validated = false; |
| if (context.checked_layouts) { |
| auto search = context.checked_layouts->find(image_view); |
| if (search != context.checked_layouts->end() && search->second == image_layout) { |
| already_validated = true; |
| } |
| } |
| if (!already_validated) { |
| bool hit_error = false; |
| VerifyImageLayout(*context.cb_node, *image_view_state, image_layout, context.caller, |
| "VUID-VkDescriptorImageInfo-imageLayout-00344", &hit_error); |
| if (hit_error) { |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: Image layout " |
| "specified " |
| "at vkUpdateDescriptorSet* or vkCmdPushDescriptorSet* time " |
| "doesn't match actual image layout at time descriptor is used. See previous error callback for " |
| "specific details.", |
| report_data->FormatHandle(set).c_str(), context.caller); |
| } |
| if (context.checked_layouts) { |
| context.checked_layouts->emplace(image_view, image_layout); |
| } |
| } |
| } |
| |
| // Verify Sample counts |
| if ((reqs & DESCRIPTOR_REQ_SINGLE_SAMPLE) && image_view_state->samples != VK_SAMPLE_COUNT_1_BIT) { |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor in " |
| "binding #%" PRIu32 " index %" PRIu32 " requires bound image to have VK_SAMPLE_COUNT_1_BIT but got %s.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| string_VkSampleCountFlagBits(image_view_state->samples)); |
| } |
| if ((reqs & DESCRIPTOR_REQ_MULTI_SAMPLE) && image_view_state->samples == VK_SAMPLE_COUNT_1_BIT) { |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor " |
| "in binding #%" PRIu32 " index %" PRIu32 |
| " requires bound image to have multiple samples, but got VK_SAMPLE_COUNT_1_BIT.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index); |
| } |
| |
| // Verify VK_FORMAT_FEATURE_STORAGE_IMAGE_ATOMIC_BIT |
| if ((reqs & DESCRIPTOR_REQ_VIEW_ATOMIC_OPERATION) && (descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) && |
| !(image_view_state->format_features & VK_FORMAT_FEATURE_STORAGE_IMAGE_ATOMIC_BIT)) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(image_view); |
| return LogError(objlist, context.vuids.imageview_atomic, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor " |
| "in binding #%" PRIu32 " index %" PRIu32 |
| ", %s, format %s, doesn't " |
| "contain VK_FORMAT_FEATURE_STORAGE_IMAGE_ATOMIC_BIT.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| report_data->FormatHandle(image_view).c_str(), string_VkFormat(image_view_ci.format)); |
| } |
| |
| // When KHR_format_feature_flags2 is supported, the read/write without |
| // format support is reported per format rather than a single physical |
| // device feature. |
| if (has_format_feature2) { |
| const VkFormatFeatureFlags2 format_features = image_view_state->format_features; |
| |
| if (descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) { |
| if ((reqs & DESCRIPTOR_REQ_IMAGE_READ_WITHOUT_FORMAT) && |
| !(format_features & VK_FORMAT_FEATURE_2_STORAGE_READ_WITHOUT_FORMAT_BIT)) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(image_view); |
| return LogError(objlist, context.vuids.storage_image_read_without_format, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor " |
| "in binding #%" PRIu32 " index %" PRIu32 |
| ", %s, image view format %s feature flags (%s) doesn't " |
| "contain VK_FORMAT_FEATURE_2_STORAGE_READ_WITHOUT_FORMAT_BIT", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| report_data->FormatHandle(image_view).c_str(), string_VkFormat(image_view_ci.format), |
| string_VkFormatFeatureFlags2(format_features).c_str()); |
| } |
| |
| if ((reqs & DESCRIPTOR_REQ_IMAGE_WRITE_WITHOUT_FORMAT) && |
| !(format_features & VK_FORMAT_FEATURE_2_STORAGE_WRITE_WITHOUT_FORMAT_BIT)) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(image_view); |
| return LogError(objlist, context.vuids.storage_image_write_without_format, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor " |
| "in binding #%" PRIu32 " index %" PRIu32 |
| ", %s, image view format %s feature flags (%s) doesn't " |
| "contain VK_FORMAT_FEATURE_2_STORAGE_WRITE_WITHOUT_FORMAT_BIT", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| report_data->FormatHandle(image_view).c_str(), string_VkFormat(image_view_ci.format), |
| string_VkFormatFeatureFlags2(format_features).c_str()); |
| } |
| } |
| |
| if ((reqs & DESCRIPTOR_REQ_IMAGE_DREF) && !(format_features & VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_DEPTH_COMPARISON_BIT)) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(image_view); |
| return LogError(objlist, context.vuids.depth_compare_sample, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor " |
| "in binding #%" PRIu32 " index %" PRIu32 |
| ", %s, image view format %s feature flags (%s) doesn't " |
| "contain VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_DEPTH_COMPARISON_BIT", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| report_data->FormatHandle(image_view).c_str(), string_VkFormat(image_view_ci.format), |
| string_VkFormatFeatureFlags2(format_features).c_str()); |
| } |
| } |
| |
| // Verify if attachments are used in DescriptorSet |
| if (context.attachments && context.attachments->size() > 0 && context.subpasses && |
| (descriptor_type != VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) { |
| for (uint32_t att_index = 0; att_index < context.attachments->size(); ++att_index) { |
| const auto &view_state = (*context.attachments)[att_index]; |
| const SUBPASS_INFO &subpass = (*context.subpasses)[att_index]; |
| if (!view_state || view_state->Destroyed()) { |
| continue; |
| } |
| bool same_view = view_state->image_view() == image_view; |
| bool overlapping_view = image_view_state->OverlapSubresource(*view_state); |
| if (!same_view && !overlapping_view) { |
| continue; |
| } |
| |
| bool descriptor_readable = false; |
| bool descriptor_writable = false; |
| uint32_t set_index = std::numeric_limits<uint32_t>::max(); |
| for (uint32_t i = 0; i < context.cb_node->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].per_set.size(); ++i) { |
| const auto &set = context.cb_node->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].per_set[i]; |
| if (set.bound_descriptor_set.get() == context.descriptor_set) { |
| set_index = i; |
| break; |
| } |
| } |
| assert(set_index != std::numeric_limits<uint32_t>::max()); |
| const auto pipeline = context.cb_node->GetCurrentPipeline(VK_PIPELINE_BIND_POINT_GRAPHICS); |
| for (const auto &stage : pipeline->stage_state) { |
| for (const auto &descriptor : stage.descriptor_uses) { |
| if (descriptor.first.set == set_index && descriptor.first.binding == binding) { |
| descriptor_writable |= descriptor.second.is_writable; |
| descriptor_readable |= |
| descriptor.second.is_readable | descriptor.second.is_sampler_implicitLod_dref_proj; |
| break; |
| } |
| } |
| } |
| |
| bool layout_read_only = IsImageLayoutReadOnly(subpass.layout); |
| bool write_attachment = |
| (subpass.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) > 0 && |
| !layout_read_only; |
| if (write_attachment && descriptor_readable) { |
| if (same_view) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(image_view); |
| objlist.add(context.framebuffer); |
| return LogError( |
| objlist, context.vuids.image_subresources_subpass_read, |
| "Descriptor set %s encountered the following validation error at %s time: %s is being read from in " |
| "Descriptor in binding #%" PRIu32 " index %" PRIu32 |
| " and will be written to as %s attachment # %" PRIu32 ".", |
| report_data->FormatHandle(set).c_str(), context.caller, report_data->FormatHandle(image_view).c_str(), |
| binding, index, report_data->FormatHandle(context.framebuffer).c_str(), att_index); |
| } else if (overlapping_view) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(image_view); |
| objlist.add(context.framebuffer); |
| objlist.add(view_state->image_view()); |
| return LogError(objlist, context.vuids.image_subresources_subpass_read, |
| "Descriptor set %s encountered the following validation error at %s time: " |
| "Image subresources of %s is being read from in " |
| "Descriptor in binding #%" PRIu32 " index %" PRIu32 |
| " and will be written to as %s in %s attachment # %" PRIu32 " overlap.", |
| report_data->FormatHandle(set).c_str(), context.caller, |
| report_data->FormatHandle(image_view).c_str(), binding, index, |
| report_data->FormatHandle(view_state->image_view()).c_str(), |
| report_data->FormatHandle(context.framebuffer).c_str(), att_index); |
| } |
| } |
| bool read_attachment = (subpass.usage & (VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT)) > 0; |
| if (read_attachment && descriptor_writable) { |
| if (same_view) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(image_view); |
| objlist.add(context.framebuffer); |
| return LogError( |
| objlist, context.vuids.image_subresources_subpass_write, |
| "Descriptor set %s encountered the following validation error at %s time: %s is being written to in " |
| "Descriptor in binding #%" PRIu32 " index %" PRIu32 " and read from as %s attachment # %" PRIu32 ".", |
| report_data->FormatHandle(set).c_str(), context.caller, report_data->FormatHandle(image_view).c_str(), |
| binding, index, report_data->FormatHandle(context.framebuffer).c_str(), att_index); |
| } else if (overlapping_view) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(image_view); |
| objlist.add(context.framebuffer); |
| objlist.add(view_state->image_view()); |
| return LogError(objlist, context.vuids.image_subresources_subpass_write, |
| "Descriptor set %s encountered the following validation error at %s time: " |
| "Image subresources of %s is being written to in " |
| "Descriptor in binding #%" PRIu32 " index %" PRIu32 |
| " and will be read from as %s in %s attachment # %" PRIu32 " overlap.", |
| report_data->FormatHandle(set).c_str(), context.caller, |
| report_data->FormatHandle(image_view).c_str(), binding, index, |
| report_data->FormatHandle(view_state->image_view()).c_str(), |
| report_data->FormatHandle(context.framebuffer).c_str(), att_index); |
| } |
| } |
| |
| if (descriptor_writable && !layout_read_only) { |
| if (same_view) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(image_view); |
| objlist.add(context.framebuffer); |
| return LogError( |
| objlist, context.vuids.image_subresources_render_pass_write, |
| "Descriptor set %s encountered the following validation error at %s time: %s is used in " |
| "Descriptor in binding #%" PRIu32 " index %" PRIu32 " as writable and %s attachment # %" PRIu32 ".", |
| report_data->FormatHandle(set).c_str(), context.caller, report_data->FormatHandle(image_view).c_str(), |
| binding, index, report_data->FormatHandle(context.framebuffer).c_str(), att_index); |
| } else if (overlapping_view) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(image_view); |
| objlist.add(context.framebuffer); |
| objlist.add(view_state->image_view()); |
| return LogError(objlist, context.vuids.image_subresources_render_pass_write, |
| "Descriptor set %s encountered the following validation error at %s time: " |
| "Image subresources of %s in " |
| "writable Descriptor in binding #%" PRIu32 " index %" PRIu32 |
| " and %s in %s attachment # %" PRIu32 " overlap.", |
| report_data->FormatHandle(set).c_str(), context.caller, |
| report_data->FormatHandle(image_view).c_str(), binding, index, |
| report_data->FormatHandle(view_state->image_view()).c_str(), |
| report_data->FormatHandle(context.framebuffer).c_str(), att_index); |
| } |
| } |
| } |
| if (enabled_features.core11.protectedMemory == VK_TRUE) { |
| if (ValidateProtectedImage(context.cb_node, image_view_state->image_state.get(), context.caller, |
| context.vuids.unprotected_command_buffer, "Image is in a descriptorSet")) { |
| return true; |
| } |
| if (binding_info.second.is_writable && |
| ValidateUnprotectedImage(context.cb_node, image_view_state->image_state.get(), context.caller, |
| context.vuids.protected_command_buffer, "Image is in a descriptorSet")) { |
| return true; |
| } |
| } |
| } |
| |
| for (const auto *sampler_state : sampler_states) { |
| if (!sampler_state || sampler_state->Destroyed()) { |
| continue; |
| } |
| |
| // TODO: Validate 04015 for DescriptorClass::PlainSampler |
| if ((sampler_state->createInfo.borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT || |
| sampler_state->createInfo.borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT) && |
| (sampler_state->customCreateInfo.format == VK_FORMAT_UNDEFINED)) { |
| if (image_view_state->create_info.format == VK_FORMAT_B4G4R4A4_UNORM_PACK16 || |
| image_view_state->create_info.format == VK_FORMAT_B5G6R5_UNORM_PACK16 || |
| image_view_state->create_info.format == VK_FORMAT_B5G5R5A1_UNORM_PACK16) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(sampler_state->sampler()); |
| objlist.add(image_view_state->image_view()); |
| return LogError(objlist, "VUID-VkSamplerCustomBorderColorCreateInfoEXT-format-04015", |
| "Descriptor set %s encountered the following validation error at %s time: Sampler %s in " |
| "binding #%" PRIu32 " index %" PRIu32 |
| " has a custom border color with format = VK_FORMAT_UNDEFINED and is used to " |
| "sample an image view %s with format %s", |
| report_data->FormatHandle(set).c_str(), context.caller, |
| report_data->FormatHandle(sampler_state->sampler()).c_str(), binding, index, |
| report_data->FormatHandle(image_view_state->image_view()).c_str(), |
| string_VkFormat(image_view_state->create_info.format)); |
| } |
| } |
| const VkFilter sampler_mag_filter = sampler_state->createInfo.magFilter; |
| const VkFilter sampler_min_filter = sampler_state->createInfo.minFilter; |
| const VkBool32 sampler_compare_enable = sampler_state->createInfo.compareEnable; |
| if ((sampler_compare_enable == VK_FALSE) && |
| !(image_view_state->format_features & VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT)) { |
| if (sampler_mag_filter == VK_FILTER_LINEAR || sampler_min_filter == VK_FILTER_LINEAR) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(sampler_state->sampler()); |
| objlist.add(image_view_state->image_view()); |
| return LogError(objlist, context.vuids.linear_filter_sampler, |
| "Descriptor set %s encountered the following validation error at %s time: Sampler " |
| "(%s) is set to use VK_FILTER_LINEAR with " |
| "compareEnable is set to VK_FALSE, but image view's (%s) format (%s) does not " |
| "contain VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT in its format features.", |
| report_data->FormatHandle(set).c_str(), context.caller, |
| report_data->FormatHandle(sampler_state->sampler()).c_str(), |
| report_data->FormatHandle(image_view_state->image_view()).c_str(), |
| string_VkFormat(image_view_state->create_info.format)); |
| } |
| if (sampler_state->createInfo.mipmapMode == VK_SAMPLER_MIPMAP_MODE_LINEAR) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(sampler_state->sampler()); |
| objlist.add(image_view_state->image_view()); |
| return LogError(objlist, context.vuids.linear_mipmap_sampler, |
| "Descriptor set %s encountered the following validation error at %s time: Sampler " |
| "(%s) is set to use VK_SAMPLER_MIPMAP_MODE_LINEAR with " |
| "compareEnable is set to VK_FALSE, but image view's (%s) format (%s) does not " |
| "contain VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT in its format features.", |
| report_data->FormatHandle(set).c_str(), context.caller, |
| report_data->FormatHandle(sampler_state->sampler()).c_str(), |
| report_data->FormatHandle(image_view_state->image_view()).c_str(), |
| string_VkFormat(image_view_state->create_info.format)); |
| } |
| } |
| |
| if (sampler_mag_filter == VK_FILTER_CUBIC_EXT || sampler_min_filter == VK_FILTER_CUBIC_EXT) { |
| if (!(image_view_state->format_features & VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_CUBIC_BIT_EXT)) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(sampler_state->sampler()); |
| objlist.add(image_view_state->image_view()); |
| return LogError(objlist, context.vuids.cubic_sampler, |
| "Descriptor set %s encountered the following validation error at %s time: " |
| "Sampler (%s) is set to use VK_FILTER_CUBIC_EXT, then " |
| "image view's (%s) format (%s) MUST contain " |
| "VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_CUBIC_BIT_EXT in its format features.", |
| report_data->FormatHandle(set).c_str(), context.caller, |
| report_data->FormatHandle(sampler_state->sampler()).c_str(), |
| report_data->FormatHandle(image_view_state->image_view()).c_str(), |
| string_VkFormat(image_view_state->create_info.format)); |
| } |
| |
| if (IsExtEnabled(device_extensions.vk_ext_filter_cubic)) { |
| const auto reduction_mode_info = |
| LvlFindInChain<VkSamplerReductionModeCreateInfo>(sampler_state->createInfo.pNext); |
| if (reduction_mode_info && |
| (reduction_mode_info->reductionMode == VK_SAMPLER_REDUCTION_MODE_MIN || |
| reduction_mode_info->reductionMode == VK_SAMPLER_REDUCTION_MODE_MAX) && |
| !image_view_state->filter_cubic_props.filterCubicMinmax) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(sampler_state->sampler()); |
| objlist.add(image_view_state->image_view()); |
| return LogError(objlist, context.vuids.filter_cubic_min_max, |
| "Descriptor set %s encountered the following validation error at %s time: " |
| "Sampler (%s) is set to use VK_FILTER_CUBIC_EXT & %s, " |
| "but image view (%s) doesn't support filterCubicMinmax.", |
| report_data->FormatHandle(set).c_str(), context.caller, |
| report_data->FormatHandle(sampler_state->sampler()).c_str(), |
| string_VkSamplerReductionMode(reduction_mode_info->reductionMode), |
| report_data->FormatHandle(image_view_state->image_view()).c_str()); |
| } |
| |
| if (!image_view_state->filter_cubic_props.filterCubic) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(sampler_state->sampler()); |
| objlist.add(image_view_state->image_view()); |
| return LogError(objlist, context.vuids.filter_cubic, |
| "Descriptor set %s encountered the following validation error at %s time: " |
| "Sampler (%s) is set to use VK_FILTER_CUBIC_EXT, " |
| "but image view (%s) doesn't support filterCubic.", |
| report_data->FormatHandle(set).c_str(), context.caller, |
| report_data->FormatHandle(sampler_state->sampler()).c_str(), |
| report_data->FormatHandle(image_view_state->image_view()).c_str()); |
| } |
| } |
| |
| if (IsExtEnabled(device_extensions.vk_img_filter_cubic)) { |
| if (image_view_state->create_info.viewType == VK_IMAGE_VIEW_TYPE_3D || |
| image_view_state->create_info.viewType == VK_IMAGE_VIEW_TYPE_CUBE || |
| image_view_state->create_info.viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(sampler_state->sampler()); |
| objlist.add(image_view_state->image_view()); |
| return LogError(objlist, context.vuids.img_filter_cubic, |
| "Descriptor set %s encountered the following validation error at %s time: Sampler " |
| "(%s)is set to use VK_FILTER_CUBIC_EXT while the VK_IMG_filter_cubic extension " |
| "is enabled, but image view (%s) has an invalid imageViewType (%s).", |
| report_data->FormatHandle(set).c_str(), context.caller, |
| report_data->FormatHandle(sampler_state->sampler()).c_str(), |
| report_data->FormatHandle(image_view_state->image_view()).c_str(), |
| string_VkImageViewType(image_view_state->create_info.viewType)); |
| } |
| } |
| } |
| const auto image_state = image_view_state->image_state.get(); |
| if ((image_state->createInfo.flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) && |
| (sampler_state->createInfo.addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE || |
| sampler_state->createInfo.addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE || |
| sampler_state->createInfo.addressModeW != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE)) { |
| std::string address_mode_letter = |
| (sampler_state->createInfo.addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) |
| ? "U" |
| : (sampler_state->createInfo.addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ? "V" : "W"; |
| VkSamplerAddressMode address_mode = |
| (sampler_state->createInfo.addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) |
| ? sampler_state->createInfo.addressModeU |
| : (sampler_state->createInfo.addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) |
| ? sampler_state->createInfo.addressModeV |
| : sampler_state->createInfo.addressModeW; |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(sampler_state->sampler()); |
| objlist.add(image_state->image()); |
| objlist.add(image_view_state->image_view()); |
| return LogError(objlist, context.vuids.corner_sampled_address_mode, |
| "Descriptor set %s encountered the following validation error at %s time: Image " |
| "(%s) in image view (%s) is created with flag " |
| "VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and can only be sampled using " |
| "VK_SAMPLER_ADDRESS_MODE_CLAMP_EDGE, but sampler (%s) has " |
| "createInfo.addressMode%s set to %s.", |
| report_data->FormatHandle(set).c_str(), context.caller, |
| report_data->FormatHandle(image_state->image()).c_str(), |
| report_data->FormatHandle(image_view_state->image_view()).c_str(), |
| report_data->FormatHandle(sampler_state->sampler()).c_str(), address_mode_letter.c_str(), |
| string_VkSamplerAddressMode(address_mode)); |
| } |
| |
| // UnnormalizedCoordinates sampler validations |
| // only check if sampled as could have a texelFetch on a combined image sampler |
| if (sampler_state->createInfo.unnormalizedCoordinates && (reqs & DESCRIPTOR_REQ_SAMPLER_SAMPLED)) { |
| // If ImageView is used by a unnormalizedCoordinates sampler, it needs to check ImageView type |
| if (image_view_ci.viewType == VK_IMAGE_VIEW_TYPE_3D || image_view_ci.viewType == VK_IMAGE_VIEW_TYPE_CUBE || |
| image_view_ci.viewType == VK_IMAGE_VIEW_TYPE_1D_ARRAY || |
| image_view_ci.viewType == VK_IMAGE_VIEW_TYPE_2D_ARRAY || |
| image_view_ci.viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(image_view); |
| objlist.add(sampler_state->sampler()); |
| return LogError(objlist, context.vuids.sampler_imageview_type, |
| "Descriptor set %s encountered the following validation error at %s time: %s, type: %s in " |
| "Descriptor in binding #%" PRIu32 " index %" PRIu32 "is used by %s.", |
| report_data->FormatHandle(set).c_str(), context.caller, |
| report_data->FormatHandle(image_view).c_str(), string_VkImageViewType(image_view_ci.viewType), |
| binding, index, report_data->FormatHandle(sampler_state->sampler()).c_str()); |
| } |
| |
| // sampler must not be used with any of the SPIR-V OpImageSample* or OpImageSparseSample* |
| // instructions with ImplicitLod, Dref or Proj in their name |
| if (reqs & DESCRIPTOR_REQ_SAMPLER_IMPLICITLOD_DREF_PROJ) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(image_view); |
| objlist.add(sampler_state->sampler()); |
| return LogError( |
| objlist, context.vuids.sampler_implicitLod_dref_proj, |
| "Descriptor set %s encountered the following validation error at %s time: %s in " |
| "Descriptor in binding #%" PRIu32 " index %" PRIu32 " is used by %s that uses invalid operator.", |
| report_data->FormatHandle(set).c_str(), context.caller, report_data->FormatHandle(image_view).c_str(), |
| binding, index, report_data->FormatHandle(sampler_state->sampler()).c_str()); |
| } |
| |
| // sampler must not be used with any of the SPIR-V OpImageSample* or OpImageSparseSample* |
| // instructions that includes a LOD bias or any offset values |
| if (reqs & DESCRIPTOR_REQ_SAMPLER_BIAS_OFFSET) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(image_view); |
| objlist.add(sampler_state->sampler()); |
| return LogError(objlist, context.vuids.sampler_bias_offset, |
| "Descriptor set %s encountered the following validation error at %s time: %s in " |
| "Descriptor in binding #%" PRIu32 " index %" PRIu32 |
| " is used by %s that uses invalid bias or offset operator.", |
| report_data->FormatHandle(set).c_str(), context.caller, |
| report_data->FormatHandle(image_view).c_str(), binding, index, |
| report_data->FormatHandle(sampler_state->sampler()).c_str()); |
| } |
| } |
| } |
| } |
| return false; |
| } |
| |
| bool CoreChecks::ValidateDescriptor(const DescriptorContext &context, const DescriptorBindingInfo &binding_info, uint32_t index, |
| VkDescriptorType descriptor_type, const cvdescriptorset::ImageSamplerDescriptor &descriptor) const { |
| bool skip = ValidateDescriptor(context, binding_info, index, descriptor_type, static_cast<const cvdescriptorset::ImageDescriptor &>(descriptor)); |
| if (!skip) { |
| skip = |
| ValidateSamplerDescriptor(context.caller, context.vuids, context.cb_node, context.descriptor_set, binding_info, index, |
| descriptor.GetSampler(), descriptor.IsImmutableSampler(), descriptor.GetSamplerState()); |
| } |
| return skip; |
| } |
| |
| bool CoreChecks::ValidateDescriptor(const DescriptorContext &context, const DescriptorBindingInfo &binding_info, uint32_t index, |
| VkDescriptorType descriptor_type, const cvdescriptorset::TexelDescriptor &texel_descriptor) const { |
| auto buffer_view = texel_descriptor.GetBufferView(); |
| auto buffer_view_state = texel_descriptor.GetBufferViewState(); |
| const auto binding = binding_info.first; |
| const auto reqs = binding_info.second.reqs; |
| if ((!buffer_view_state && !enabled_features.robustness2_features.nullDescriptor) || |
| (buffer_view_state && buffer_view_state->Destroyed())) { |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor in " |
| "binding #%" PRIu32 " index %" PRIu32 " is using bufferView %s that is invalid or has been destroyed.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| report_data->FormatHandle(buffer_view).c_str()); |
| } |
| if (buffer_view && buffer_view_state) { |
| auto buffer = buffer_view_state->create_info.buffer; |
| const auto *buffer_state = buffer_view_state->buffer_state.get(); |
| const VkFormat buffer_view_format = buffer_view_state->create_info.format; |
| if (buffer_state->Destroyed()) { |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor in " |
| "binding #%" PRIu32 " index %" PRIu32 " is using buffer %s that has been destroyed.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| report_data->FormatHandle(buffer).c_str()); |
| } |
| const auto format_bits = DescriptorRequirementsBitsFromFormat(buffer_view_format); |
| |
| if (!(reqs & format_bits)) { |
| // bad component type |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor in " |
| "binding #%" PRIu32 " index %" PRIu32 " requires %s component type, but bound descriptor format is %s.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| StringDescriptorReqComponentType(reqs), string_VkFormat(buffer_view_format)); |
| } |
| |
| const VkFormatFeatureFlags2KHR buf_format_features = buffer_view_state->buf_format_features; |
| const VkDescriptorType descriptor_type = context.descriptor_set->GetBinding(binding)->type; |
| |
| // Verify VK_FORMAT_FEATURE_STORAGE_TEXEL_BUFFER_ATOMIC_BIT |
| if ((reqs & DESCRIPTOR_REQ_VIEW_ATOMIC_OPERATION) && (descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER) && |
| !(buf_format_features & VK_FORMAT_FEATURE_STORAGE_TEXEL_BUFFER_ATOMIC_BIT)) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(buffer_view); |
| return LogError(objlist, "UNASSIGNED-None-MismatchAtomicBufferFeature", |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor " |
| "in binding #%" PRIu32 " index %" PRIu32 |
| ", %s, format %s, doesn't " |
| "contain VK_FORMAT_FEATURE_STORAGE_IMAGE_ATOMIC_BIT.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| report_data->FormatHandle(buffer_view).c_str(), string_VkFormat(buffer_view_format)); |
| } |
| |
| // When KHR_format_feature_flags2 is supported, the read/write without |
| // format support is reported per format rather than a single physical |
| // device feature. |
| if (has_format_feature2) { |
| if (descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER) { |
| if ((reqs & DESCRIPTOR_REQ_IMAGE_READ_WITHOUT_FORMAT) && |
| !(buf_format_features & VK_FORMAT_FEATURE_2_STORAGE_READ_WITHOUT_FORMAT_BIT_KHR)) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(buffer_view); |
| return LogError(objlist, context.vuids.storage_texel_buffer_read_without_format, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor " |
| "in binding #%" PRIu32 " index %" PRIu32 |
| ", %s, buffer view format %s feature flags (%s) doesn't " |
| "contain VK_FORMAT_FEATURE_2_STORAGE_READ_WITHOUT_FORMAT_BIT_KHR", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| report_data->FormatHandle(buffer_view).c_str(), string_VkFormat(buffer_view_format), |
| string_VkFormatFeatureFlags2KHR(buf_format_features).c_str()); |
| } |
| |
| if ((reqs & DESCRIPTOR_REQ_IMAGE_WRITE_WITHOUT_FORMAT) && |
| !(buf_format_features & VK_FORMAT_FEATURE_2_STORAGE_WRITE_WITHOUT_FORMAT_BIT_KHR)) { |
| auto set = context.descriptor_set->GetSet(); |
| LogObjectList objlist(set); |
| objlist.add(buffer_view); |
| return LogError(objlist, context.vuids.storage_texel_buffer_write_without_format, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor " |
| "in binding #%" PRIu32 " index %" PRIu32 |
| ", %s, buffer view format %s feature flags (%s) doesn't " |
| "contain VK_FORMAT_FEATURE_2_STORAGE_WRITE_WITHOUT_FORMAT_BIT_KHR", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| report_data->FormatHandle(buffer_view).c_str(), string_VkFormat(buffer_view_format), |
| string_VkFormatFeatureFlags2KHR(buf_format_features).c_str()); |
| } |
| } |
| } |
| |
| if (enabled_features.core11.protectedMemory == VK_TRUE) { |
| if (ValidateProtectedBuffer(context.cb_node, buffer_view_state->buffer_state.get(), context.caller, |
| context.vuids.unprotected_command_buffer, "Buffer is in a descriptorSet")) { |
| return true; |
| } |
| if (binding_info.second.is_writable && |
| ValidateUnprotectedBuffer(context.cb_node, buffer_view_state->buffer_state.get(), context.caller, |
| context.vuids.protected_command_buffer, "Buffer is in a descriptorSet")) { |
| return true; |
| } |
| } |
| } |
| return false; |
| } |
| |
| bool CoreChecks::ValidateDescriptor(const DescriptorContext &context, const DescriptorBindingInfo &binding_info, uint32_t index, |
| VkDescriptorType descriptor_type, const cvdescriptorset::AccelerationStructureDescriptor &descriptor) const { |
| // Verify that acceleration structures are valid |
| const auto binding = binding_info.first; |
| if (descriptor.is_khr()) { |
| auto acc = descriptor.GetAccelerationStructure(); |
| auto acc_node = descriptor.GetAccelerationStructureStateKHR(); |
| if (!acc_node || acc_node->Destroyed()) { |
| if (acc != VK_NULL_HANDLE || !enabled_features.robustness2_features.nullDescriptor) { |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: " |
| "Descriptor in binding #%" PRIu32 " index %" PRIu32 |
| " is using acceleration structure %s that is invalid or has been destroyed.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| report_data->FormatHandle(acc).c_str()); |
| } |
| } else { |
| for (const auto &mem_binding : acc_node->buffer_state->GetInvalidMemory()) { |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor in " |
| "binding #%" PRIu32 " index %" PRIu32 |
| " is using acceleration structure %s that references invalid memory %s.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| report_data->FormatHandle(acc).c_str(), report_data->FormatHandle(mem_binding->mem()).c_str()); |
| } |
| } |
| } else { |
| auto acc = descriptor.GetAccelerationStructureNV(); |
| auto acc_node = descriptor.GetAccelerationStructureStateNV(); |
| if (!acc_node || acc_node->Destroyed()) { |
| if (acc != VK_NULL_HANDLE || !enabled_features.robustness2_features.nullDescriptor) { |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: " |
| "Descriptor in binding #%" PRIu32 " index %" PRIu32 |
| " is using acceleration structure %s that is invalid or has been destroyed.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| report_data->FormatHandle(acc).c_str()); |
| } |
| } else { |
| for (const auto &mem_binding : acc_node->GetInvalidMemory()) { |
| auto set = context.descriptor_set->GetSet(); |
| return LogError(set, context.vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor in " |
| "binding #%" PRIu32 " index %" PRIu32 |
| " is using acceleration structure %s that references invalid memory %s.", |
| report_data->FormatHandle(set).c_str(), context.caller, binding, index, |
| report_data->FormatHandle(acc).c_str(), report_data->FormatHandle(mem_binding->mem()).c_str()); |
| } |
| } |
| } |
| return false; |
| } |
| |
| // If the validation is related to both of image and sampler, |
| // please leave it in (descriptor_class == DescriptorClass::ImageSampler || descriptor_class == |
| // DescriptorClass::Image) Here is to validate for only sampler. |
| bool CoreChecks::ValidateSamplerDescriptor(const char *caller, const DrawDispatchVuid &vuids, const CMD_BUFFER_STATE *cb_node, |
| const cvdescriptorset::DescriptorSet *descriptor_set, |
| const std::pair<const uint32_t, DescriptorRequirement> &binding_info, uint32_t index, |
| VkSampler sampler, bool is_immutable, const SAMPLER_STATE *sampler_state) const { |
| // Verify Sampler still valid |
| if (!sampler_state || sampler_state->Destroyed()) { |
| auto set = descriptor_set->GetSet(); |
| return LogError(set, vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: Descriptor in " |
| "binding #%" PRIu32 " index %" PRIu32 " is using sampler %s that is invalid or has been destroyed.", |
| report_data->FormatHandle(set).c_str(), caller, binding_info.first, index, |
| report_data->FormatHandle(sampler).c_str()); |
| } else { |
| if (sampler_state->samplerConversion && !is_immutable) { |
| auto set = descriptor_set->GetSet(); |
| return LogError(set, vuids.descriptor_valid, |
| "Descriptor set %s encountered the following validation error at %s time: sampler (%s) " |
| "in the descriptor set (%s) contains a YCBCR conversion (%s), then the sampler MUST " |
| "also exist as an immutable sampler.", |
| report_data->FormatHandle(set).c_str(), caller, report_data->FormatHandle(sampler).c_str(), |
| report_data->FormatHandle(descriptor_set->GetSet()).c_str(), |
| report_data->FormatHandle(sampler_state->samplerConversion).c_str()); |
| } |
| } |
| return false; |
| } |
| |
| bool CoreChecks::ValidateDescriptor(const DescriptorContext &context, const DescriptorBindingInfo &binding_info, uint32_t index, |
| VkDescriptorType descriptor_type, const cvdescriptorset::SamplerDescriptor &descriptor) const { |
| return ValidateSamplerDescriptor(context.caller, context.vuids, context.cb_node, context.descriptor_set, binding_info, index, |
| descriptor.GetSampler(), descriptor.IsImmutableSampler(), descriptor.GetSamplerState()); |
| } |
| |
| // Starting at offset descriptor of given binding, parse over update_count |
| // descriptor updates and verify that for any binding boundaries that are crossed, the next binding(s) are all consistent |
| // Consistency means that their type, stage flags, and whether or not they use immutable samplers matches |
| // If so, return true. If not, fill in error_msg and return false |
| static bool VerifyUpdateConsistency(debug_report_data *report_data, const DescriptorSet &set, uint32_t binding, uint32_t offset, |
| uint32_t update_count, const char *type, std::string *error_msg) { |
| auto current_iter = set.FindBinding(binding); |
| bool pass = true; |
| // Verify consecutive bindings match (if needed) |
| auto &orig_binding = **current_iter; |
| while (pass && update_count) { |
| // First, it's legal to offset beyond your own binding so handle that case |
| if (offset > 0) { |
| // index_range.start + offset is which descriptor is needed to update. If it > index_range.end, it means the descriptor |
| // isn't in this binding, maybe in next binding. |
| if (offset > (*current_iter)->count) { |
| // Advance to next binding, decrement offset by binding size |
| offset -= (*current_iter)->count; |
| ++current_iter; |
| // Verify next consecutive binding matches type, stage flags & immutable sampler use and if AtEnd |
| if (current_iter == set.end() || !orig_binding.IsConsistent(**current_iter)) { |
| pass = false; |
| } |
| continue; |
| } |
| } |
| |
| update_count -= std::min(update_count, (*current_iter)->count - offset); |
| if (update_count) { |
| // Starting offset is beyond the current binding. Check consistency, update counters and advance to the next binding, |
| // looking for the start point. All bindings (even those skipped) must be consistent with the update and with the |
| // original binding. |
| offset = 0; |
| ++current_iter; |
| // Verify next consecutive binding matches type, stage flags & immutable sampler use and if AtEnd |
| if (current_iter == set.end() || !orig_binding.IsConsistent(**current_iter)) { |
| pass = false; |
| } |
| } |
| } |
| |
| if (!pass) { |
| std::stringstream error_str; |
| error_str << "Attempting " << type; |
| if (set.IsPushDescriptor()) { |
| error_str << " push descriptors"; |
| } else { |
| error_str << " descriptor set " << report_data->FormatHandle(set.Handle()); |
| } |
| error_str << " binding #" << orig_binding.binding << " with #" << update_count |
| << " descriptors being updated but this update oversteps the bounds of this binding and the next binding is " |
| "not consistent with current binding"; |
| if (current_iter == set.end()) { |
| error_str << " (update past the end of the descriptor set)"; |
| } else { |
| auto current_binding = current_iter->get(); |
| // Get what was not consistent in IsConsistent() as a more detailed error message |
| if (current_binding->type != orig_binding.type) { |
| error_str << " (" << string_VkDescriptorType(current_binding->type) |
| << " != " << string_VkDescriptorType(orig_binding.type) << ")"; |
| } else if (current_binding->stage_flags != orig_binding.stage_flags) { |
| error_str << " (" << string_VkShaderStageFlags(current_binding->stage_flags) |
| << " != " << string_VkShaderStageFlags(orig_binding.stage_flags) << ")"; |
| } else if (current_binding->has_immutable_samplers != orig_binding.has_immutable_samplers) { |
| error_str << " (pImmutableSamplers don't match)"; |
| } else if (current_binding->binding_flags != orig_binding.binding_flags) { |
| error_str << " (" << string_VkDescriptorBindingFlags(current_binding->binding_flags) |
| << " != " << string_VkDescriptorBindingFlags(orig_binding.binding_flags) << ")"; |
| } |
| } |
| |
| error_str << " so this update is invalid"; |
| *error_msg = error_str.str(); |
| } |
| return pass; |
| } |
| |
| // Validate Copy update |
| bool CoreChecks::ValidateCopyUpdate(const VkCopyDescriptorSet *update, const DescriptorSet *dst_set, const DescriptorSet *src_set, |
| const char *func_name, std::string *error_code, std::string *error_msg) const { |
| const auto *dst_layout = dst_set->GetLayout().get(); |
| const auto *src_layout = src_set->GetLayout().get(); |
| |
| // Verify dst layout still valid |
| if (dst_layout->Destroyed()) { |
| *error_code = "VUID-VkCopyDescriptorSet-dstSet-parameter"; |
| std::ostringstream str; |
| str << "Cannot call " << func_name << " to perform copy update on dstSet " << report_data->FormatHandle(dst_set->GetSet()) |
| << " created with destroyed " << report_data->FormatHandle(dst_layout->GetDescriptorSetLayout()) << "."; |
| *error_msg = str.str(); |
| return false; |
| } |
| |
| // Verify src layout still valid |
| if (src_layout->Destroyed()) { |
| *error_code = "VUID-VkCopyDescriptorSet-srcSet-parameter"; |
| std::ostringstream str; |
| str << "Cannot call " << func_name << " to perform copy update on dstSet " << report_data->FormatHandle(dst_set->GetSet()) |
| << " from srcSet " << report_data->FormatHandle(src_set->GetSet()) << " created with destroyed " |
| << report_data->FormatHandle(src_layout->GetDescriptorSetLayout()) << "."; |
| *error_msg = str.str(); |
| return false; |
| } |
| |
| if (!dst_layout->HasBinding(update->dstBinding)) { |
| *error_code = "VUID-VkCopyDescriptorSet-dstBinding-00347"; |
| std::stringstream error_str; |
| error_str << "DescriptorSet " << report_data->FormatHandle(dst_set->GetSet()) |
| << " does not have copy update dest binding of " << update->dstBinding; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| if (!src_set->HasBinding(update->srcBinding)) { |
| *error_code = "VUID-VkCopyDescriptorSet-srcBinding-00345"; |
| std::stringstream error_str; |
| error_str << "DescriptorSet " << report_data->FormatHandle(src_set->GetSet()) |
| << " does not have copy update src binding of " << update->srcBinding; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| // Verify idle ds |
| if (dst_set->InUse() && |
| !(dst_layout->GetDescriptorBindingFlagsFromBinding(update->dstBinding) & |
| (VK_DESCRIPTOR_BINDING_UPDATE_UNUSED_WHILE_PENDING_BIT | VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT))) { |
| *error_code = "VUID-vkUpdateDescriptorSets-None-03047"; |
| std::stringstream error_str; |
| error_str << "Cannot call " << func_name << " to perform copy update on descriptor set " |
| << report_data->FormatHandle(dst_set->GetSet()) << " that is in use by a command buffer"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| // src & dst set bindings are valid |
| // Check bounds of src & dst |
| auto src_start_idx = src_set->GetGlobalIndexRangeFromBinding(update->srcBinding).start + update->srcArrayElement; |
| if ((src_start_idx + update->descriptorCount) > src_set->GetTotalDescriptorCount()) { |
| // SRC update out of bounds |
| *error_code = "VUID-VkCopyDescriptorSet-srcArrayElement-00346"; |
| std::stringstream error_str; |
| error_str << "Attempting copy update from descriptorSet " << report_data->FormatHandle(update->srcSet) << " binding#" |
| << update->srcBinding << " with offset index of " |
| << src_set->GetGlobalIndexRangeFromBinding(update->srcBinding).start << " plus update array offset of " |
| << update->srcArrayElement << " and update of " << update->descriptorCount |
| << " descriptors oversteps total number of descriptors in set: " << src_set->GetTotalDescriptorCount(); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| auto dst_start_idx = dst_layout->GetGlobalIndexRangeFromBinding(update->dstBinding).start + update->dstArrayElement; |
| if ((dst_start_idx + update->descriptorCount) > dst_layout->GetTotalDescriptorCount()) { |
| // DST update out of bounds |
| *error_code = "VUID-VkCopyDescriptorSet-dstArrayElement-00348"; |
| std::stringstream error_str; |
| error_str << "Attempting copy update to descriptorSet " << report_data->FormatHandle(dst_set->GetSet()) << " binding#" |
| << update->dstBinding << " with offset index of " |
| << dst_layout->GetGlobalIndexRangeFromBinding(update->dstBinding).start << " plus update array offset of " |
| << update->dstArrayElement << " and update of " << update->descriptorCount |
| << " descriptors oversteps total number of descriptors in set: " << dst_layout->GetTotalDescriptorCount(); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| // Check that types match |
| // TODO : Base default error case going from here is "VUID-VkAcquireNextImageInfoKHR-semaphore-parameter" 2ba which covers all |
| // consistency issues, need more fine-grained error codes |
| *error_code = "VUID-VkCopyDescriptorSet-srcSet-00349"; |
| auto src_type = src_layout->GetTypeFromBinding(update->srcBinding); |
| auto dst_type = dst_layout->GetTypeFromBinding(update->dstBinding); |
| if (src_type != VK_DESCRIPTOR_TYPE_MUTABLE_EXT && dst_type != VK_DESCRIPTOR_TYPE_MUTABLE_EXT && src_type != dst_type) { |
| *error_code = "VUID-VkCopyDescriptorSet-dstBinding-02632"; |
| std::stringstream error_str; |
| error_str << "Attempting copy update to descriptorSet " << report_data->FormatHandle(dst_set->GetSet()) << " binding #" |
| << update->dstBinding << " with type " << string_VkDescriptorType(dst_type) << " from descriptorSet " |
| << report_data->FormatHandle(src_set->GetSet()) << " binding #" << update->srcBinding << " with type " |
| << string_VkDescriptorType(src_type) << ". Types do not match"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| // Verify consistency of src & dst bindings if update crosses binding boundaries |
| if ((!VerifyUpdateConsistency(report_data, *src_set, update->srcBinding, update->srcArrayElement, update->descriptorCount, |
| "copy update from", error_msg)) || |
| (!VerifyUpdateConsistency(report_data, *dst_set, update->dstBinding, update->dstArrayElement, update->descriptorCount, |
| "copy update to", error_msg))) { |
| return false; |
| } |
| |
| if ((src_layout->GetCreateFlags() & VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT) && |
| !(dst_layout->GetCreateFlags() & VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT)) { |
| *error_code = "VUID-VkCopyDescriptorSet-srcSet-01918"; |
| std::stringstream error_str; |
| error_str << "If pname:srcSet's (" << report_data->FormatHandle(update->srcSet) |
| << ") layout was created with the " |
| "ename:VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT flag " |
| "set, then pname:dstSet's (" |
| << report_data->FormatHandle(update->dstSet) |
| << ") layout must: also have been created with the " |
| "ename:VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT flag set"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| |
| if (IsExtEnabled(device_extensions.vk_valve_mutable_descriptor_type) || |
| IsExtEnabled(device_extensions.vk_ext_mutable_descriptor_type)) { |
| if (!(src_layout->GetCreateFlags() & (VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT | |
| VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_EXT)) && |
| (dst_layout->GetCreateFlags() & VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT)) { |
| *error_code = "VUID-VkCopyDescriptorSet-srcSet-04885"; |
| std::stringstream error_str; |
| error_str << "If pname:srcSet's (" << report_data->FormatHandle(update->srcSet) |
| << ") layout was created with neither ename:VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT nor " |
| "ename:VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_EXT flags set, then pname:dstSet's (" |
| << report_data->FormatHandle(update->dstSet) |
| << ") layout must: have been created without the " |
| "ename:VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT flag set"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } else { |
| if (!(src_layout->GetCreateFlags() & VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT) && |
| (dst_layout->GetCreateFlags() & VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT)) { |
| *error_code = "VUID-VkCopyDescriptorSet-srcSet-04886"; |
| std::stringstream error_str; |
| error_str << "If pname:srcSet's (" << report_data->FormatHandle(update->srcSet) |
| << ") layout was created without the ename:VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT flag " |
| "set, then pname:dstSet's (" |
| << report_data->FormatHandle(update->dstSet) |
| << ") layout must: also have been created without the " |
| "ename:VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT flag set"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| |
| if ((src_set->GetPoolState()->createInfo.flags & VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT) && |
| !(dst_set->GetPoolState()->createInfo.flags & VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT)) { |
| *error_code = "VUID-VkCopyDescriptorSet-srcSet-01920"; |
| std::stringstream error_str; |
| error_str << "If the descriptor pool from which pname:srcSet (" << report_data->FormatHandle(update->srcSet) |
| << ") was allocated was created " |
| "with the ename:VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT flag " |
| "set, then the descriptor pool from which pname:dstSet (" |
| << report_data->FormatHandle(update->dstSet) |
| << ") was allocated must: " |
| "also have been created with the ename:VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT flag set"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| |
| if (IsExtEnabled(device_extensions.vk_valve_mutable_descriptor_type) || |
| IsExtEnabled(device_extensions.vk_ext_mutable_descriptor_type)) { |
| if (!(src_set->GetPoolState()->createInfo.flags & |
| (VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT | VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_EXT)) && |
| (dst_set->GetPoolState()->createInfo.flags & VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT)) { |
| *error_code = "VUID-VkCopyDescriptorSet-srcSet-04887"; |
| std::stringstream error_str; |
| error_str << "If the descriptor pool from which pname:srcSet (" << report_data->FormatHandle(update->srcSet) |
| << ") was allocated was created with neither ename:VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT nor " |
| "ename:VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_EXT flags set, then the descriptor pool from which " |
| "pname:dstSet (" |
| << report_data->FormatHandle(update->dstSet) |
| << ") was allocated must: have been created without the " |
| "ename:VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT flag set"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } else { |
| if (!(src_set->GetPoolState()->createInfo.flags & VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT) && |
| (dst_set->GetPoolState()->createInfo.flags & VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT)) { |
| *error_code = "VUID-VkCopyDescriptorSet-srcSet-04888"; |
| std::stringstream error_str; |
| error_str << "If the descriptor pool from which pname:srcSet (" << report_data->FormatHandle(update->srcSet) |
| << ") was allocated was created without the ename:VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT flag set, " |
| "then the descriptor pool from which pname:dstSet (" |
| << report_data->FormatHandle(update->dstSet) |
| << ") was allocated must: also have been created without the " |
| "ename:VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT flag set"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| |
| if (src_type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT) { |
| if ((update->srcArrayElement % 4) != 0) { |
| *error_code = "VUID-VkCopyDescriptorSet-srcBinding-02223"; |
| std::stringstream error_str; |
| error_str << "Attempting copy update to VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT binding with " |
| << "srcArrayElement " << update->srcArrayElement << " not a multiple of 4"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| if ((update->dstArrayElement % 4) != 0) { |
| *error_code = "VUID-VkCopyDescriptorSet-dstBinding-02224"; |
| std::stringstream error_str; |
| error_str << "Attempting copy update to VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT binding with " |
| << "dstArrayElement " << update->dstArrayElement << " not a multiple of 4"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| if ((update->descriptorCount % 4) != 0) { |
| *error_code = "VUID-VkCopyDescriptorSet-srcBinding-02225"; |
| std::stringstream error_str; |
| error_str << "Attempting copy update to VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT binding with " |
| << "descriptorCount " << update->descriptorCount << " not a multiple of 4"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| |
| if (dst_type == VK_DESCRIPTOR_TYPE_MUTABLE_EXT) { |
| if (src_type != VK_DESCRIPTOR_TYPE_MUTABLE_EXT) { |
| if (!dst_layout->IsTypeMutable(src_type, update->dstBinding)) { |
| *error_code = "VUID-VkCopyDescriptorSet-dstSet-04612"; |
| std::stringstream error_str; |
| error_str << "Attempting copy update with dstBinding descriptor type VK_DESCRIPTOR_TYPE_MUTABLE_EXT, but the new " |
| "active descriptor type " |
| << string_VkDescriptorType(src_type) << " is not in the corresponding pMutableDescriptorTypeLists list."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| } else if (src_type == VK_DESCRIPTOR_TYPE_MUTABLE_EXT) { |
| auto src_iter = src_set->FindDescriptor(update->srcBinding, update->srcArrayElement); |
| for (uint32_t i = 0; i < update->descriptorCount; i++, ++src_iter) { |
| const auto &mutable_src = static_cast<const cvdescriptorset::MutableDescriptor &>(*src_iter); |
| if (mutable_src.ActiveType() != dst_type) { |
| *error_code = "VUID-VkCopyDescriptorSet-srcSet-04613"; |
| std::stringstream error_str; |
| error_str << "Attempting copy update with srcBinding descriptor type VK_DESCRIPTOR_TYPE_MUTABLE_EXT, but the " |
| "active descriptor type (" |
| << string_VkDescriptorType(mutable_src.ActiveType()) << ") does not match the dstBinding descriptor type " |
| << string_VkDescriptorType(dst_type) << "."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| } |
| |
| if (dst_type == VK_DESCRIPTOR_TYPE_MUTABLE_EXT) { |
| if (src_type == VK_DESCRIPTOR_TYPE_MUTABLE_EXT) { |
| const auto &mutable_src_types = src_layout->GetMutableTypes(update->srcBinding); |
| const auto &mutable_dst_types = dst_layout->GetMutableTypes(update->dstBinding); |
| bool complete_match = mutable_src_types.size() == mutable_dst_types.size(); |
| if (complete_match) { |
| for (const auto mutable_src_type : mutable_src_types) { |
| if (std::find(mutable_dst_types.begin(), mutable_dst_types.end(), mutable_src_type) == |
| mutable_dst_types.end()) { |
| complete_match = false; |
| break; |
| } |
| } |
| } |
| if (!complete_match) { |
| *error_code = "VUID-VkCopyDescriptorSet-dstSet-04614"; |
| std::stringstream error_str; |
| error_str << "Attempting copy update with dstBinding and new active descriptor type being " |
| "VK_DESCRIPTOR_TYPE_MUTABLE_EXT, but their corresponding pMutableDescriptorTypeLists do not match."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| } |
| |
| // Update mutable types |
| if (src_type == VK_DESCRIPTOR_TYPE_MUTABLE_EXT) { |
| src_type = static_cast<const cvdescriptorset::MutableDescriptor*>(src_set->GetDescriptorFromBinding(update->srcBinding, update->srcArrayElement))->ActiveType(); |
| } |
| if (dst_type == VK_DESCRIPTOR_TYPE_MUTABLE_EXT) { |
| dst_type = static_cast<const cvdescriptorset::MutableDescriptor*>(dst_set->GetDescriptorFromBinding(update->dstBinding, update->dstArrayElement))->ActiveType(); |
| } |
| |
| // Update parameters all look good and descriptor updated so verify update contents |
| if (!VerifyCopyUpdateContents(update, src_set, src_type, src_start_idx, dst_set, dst_type, dst_start_idx, func_name, error_code, |
| error_msg)) { |
| return false; |
| } |
| |
| // All checks passed so update is good |
| return true; |
| } |
| |
| // Validate given sampler. Currently this only checks to make sure it exists in the samplerMap |
| bool CoreChecks::ValidateSampler(const VkSampler sampler) const { return Get<SAMPLER_STATE>(sampler).get() != nullptr; } |
| |
| bool CoreChecks::ValidateImageUpdate(VkImageView image_view, VkImageLayout image_layout, VkDescriptorType type, |
| const char *func_name, std::string *error_code, std::string *error_msg) const { |
| auto iv_state = Get<IMAGE_VIEW_STATE>(image_view); |
| assert(iv_state); |
| |
| // Note that when an imageview is created, we validated that memory is bound so no need to re-check here |
| // Validate that imageLayout is compatible with aspect_mask and image format |
| // and validate that image usage bits are correct for given usage |
| VkImageAspectFlags aspect_mask = iv_state->normalized_subresource_range.aspectMask; |
| VkImage image = iv_state->create_info.image; |
| VkFormat format = VK_FORMAT_MAX_ENUM; |
| VkImageUsageFlags usage = 0; |
| auto *image_node = iv_state->image_state.get(); |
| assert(image_node); |
| |
| format = image_node->createInfo.format; |
| const auto image_view_usage_info = LvlFindInChain<VkImageViewUsageCreateInfo>(iv_state->create_info.pNext); |
| const auto stencil_usage_info = LvlFindInChain<VkImageStencilUsageCreateInfo>(image_node->createInfo.pNext); |
| if (image_view_usage_info) { |
| usage = image_view_usage_info->usage; |
| } else { |
| usage = image_node->createInfo.usage; |
| } |
| if (stencil_usage_info) { |
| bool stencil_aspect = (aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT) > 0; |
| bool depth_aspect = (aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) > 0; |
| if (stencil_aspect && !depth_aspect) { |
| usage = stencil_usage_info->stencilUsage; |
| } else if (stencil_aspect && depth_aspect) { |
| usage &= stencil_usage_info->stencilUsage; |
| } |
| } |
| |
| // Validate that memory is bound to image |
| if (ValidateMemoryIsBoundToImage(image_node, func_name, kVUID_Core_Bound_Resource_FreedMemoryAccess)) { |
| *error_code = kVUID_Core_Bound_Resource_FreedMemoryAccess; |
| *error_msg = "No memory bound to image."; |
| return false; |
| } |
| |
| // KHR_maintenance1 allows rendering into 2D or 2DArray views which slice a 3D image, |
| // but not binding them to descriptor sets. |
| if (iv_state->IsDepthSliced()) { |
| if (!device_extensions.vk_ext_image_2d_view_of_3d) { |
| if (iv_state->create_info.viewType == VK_IMAGE_VIEW_TYPE_2D) { |
| *error_code = "VUID-VkDescriptorImageInfo-imageView-06711"; |
| *error_msg = "ImageView must not be a 2D view of a 3D image"; |
| return false; |
| } |
| } else if (iv_state->create_info.viewType == VK_IMAGE_VIEW_TYPE_2D_ARRAY) { |
| *error_code = "VUID-VkDescriptorImageInfo-imageView-06712"; |
| *error_msg = "ImageView must not be a 2DArray view of a 3D image"; |
| return false; |
| } |
| } |
| |
| // TODO : The various image aspect and format checks here are based on general spec language in 11.5 Image Views section under |
| // vkCreateImageView(). What's the best way to create unique id for these cases? |
| *error_code = kVUID_Core_DrawState_InvalidImageView; |
| bool ds = FormatIsDepthOrStencil(format); |
| switch (image_layout) { |
| case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: |
| // Only Color bit must be set |
| if ((aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT) != VK_IMAGE_ASPECT_COLOR_BIT) { |
| std::stringstream error_str; |
| error_str |
| << "ImageView (" << report_data->FormatHandle(image_view) |
| << ") uses layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL but does not have VK_IMAGE_ASPECT_COLOR_BIT set."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| // format must NOT be DS |
| if (ds) { |
| std::stringstream error_str; |
| error_str << "ImageView (" << report_data->FormatHandle(image_view) |
| << ") uses layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL but the image format is " |
| << string_VkFormat(format) << " which is not a color format."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| break; |
| case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: |
| case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: |
| // Depth or stencil bit must be set, but both must NOT be set |
| if (aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) { |
| if (aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT) { |
| // both must NOT be set |
| std::stringstream error_str; |
| error_str << "ImageView (" << report_data->FormatHandle(image_view) |
| << ") has both STENCIL and DEPTH aspects set"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } else if (!(aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT)) { |
| // Neither were set |
| std::stringstream error_str; |
| error_str << "ImageView (" << report_data->FormatHandle(image_view) << ") has layout " |
| << string_VkImageLayout(image_layout) << " but does not have STENCIL or DEPTH aspects set"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| // format must be DS |
| if (!ds) { |
| std::stringstream error_str; |
| error_str << "ImageView (" << report_data->FormatHandle(image_view) << ") has layout " |
| << string_VkImageLayout(image_layout) << " but the image format is " << string_VkFormat(format) |
| << " which is not a depth/stencil format."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| break; |
| default: |
| // For other layouts if the source is depth/stencil image, both aspect bits must not be set |
| if (ds) { |
| if (aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) { |
| if (aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT) { |
| // both must NOT be set |
| std::stringstream error_str; |
| error_str << "ImageView (" << report_data->FormatHandle(image_view) << ") has layout " |
| << string_VkImageLayout(image_layout) << " and is using depth/stencil image of format " |
| << string_VkFormat(format) |
| << " but it has both STENCIL and DEPTH aspects set, which is illegal. When using a depth/stencil " |
| "image in a descriptor set, please only set either VK_IMAGE_ASPECT_DEPTH_BIT or " |
| "VK_IMAGE_ASPECT_STENCIL_BIT depending on whether it will be used for depth reads or stencil " |
| "reads respectively."; |
| *error_code = "VUID-VkDescriptorImageInfo-imageView-01976"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| } |
| break; |
| } |
| // Now validate that usage flags are correctly set for given type of update |
| // As we're switching per-type, if any type has specific layout requirements, check those here as well |
| // TODO : The various image usage bit requirements are in general spec language for VkImageUsageFlags bit block in 11.3 Images |
| // under vkCreateImage() |
| const char *error_usage_bit = nullptr; |
| switch (type) { |
| case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: |
| if (iv_state->samplerConversion != VK_NULL_HANDLE) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-01946"; |
| std::stringstream error_str; |
| error_str << "ImageView (" << report_data->FormatHandle(image_view) << ")" |
| << "used as a VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE can't be created with VkSamplerYcbcrConversion"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| // drop through |
| case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: { |
| if (!(usage & VK_IMAGE_USAGE_SAMPLED_BIT)) { |
| error_usage_bit = "VK_IMAGE_USAGE_SAMPLED_BIT"; |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00337"; |
| } |
| break; |
| } |
| case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: { |
| if (!(usage & VK_IMAGE_USAGE_STORAGE_BIT)) { |
| error_usage_bit = "VK_IMAGE_USAGE_STORAGE_BIT"; |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00339"; |
| } else if ((VK_IMAGE_LAYOUT_GENERAL != image_layout) && |
| (!IsExtEnabled(device_extensions.vk_khr_shared_presentable_image) || |
| (VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR != image_layout))) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-04152"; |
| std::stringstream error_str; |
| error_str << "Descriptor update with descriptorType VK_DESCRIPTOR_TYPE_STORAGE_IMAGE" |
| << " is being updated with invalid imageLayout " << string_VkImageLayout(image_layout) << " for image " |
| << report_data->FormatHandle(image) << " in imageView " << report_data->FormatHandle(image_view) |
| << ". Allowed layouts are: VK_IMAGE_LAYOUT_GENERAL"; |
| if (IsExtEnabled(device_extensions.vk_khr_shared_presentable_image)) { |
| error_str << " or VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR"; |
| } |
| *error_msg = error_str.str(); |
| return false; |
| } |
| break; |
| } |
| case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT: { |
| if (!(usage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT)) { |
| error_usage_bit = "VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT"; |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00338"; |
| } |
| break; |
| } |
| default: |
| break; |
| } |
| if (error_usage_bit) { |
| std::stringstream error_str; |
| error_str << "ImageView (" << report_data->FormatHandle(image_view) << ") with usage mask " << std::hex << std::showbase |
| << usage << " being used for a descriptor update of type " << string_VkDescriptorType(type) << " does not have " |
| << error_usage_bit << " set."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| |
| // All the following types share the same image layouts |
| // checkf or Storage Images above |
| if ((type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) || (type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) || |
| (type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) { |
| // Test that the layout is compatible with the descriptorType for the two sampled image types |
| const static std::array<VkImageLayout, 3> valid_layouts = { |
| {VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL, VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL, VK_IMAGE_LAYOUT_GENERAL}}; |
| |
| struct ExtensionLayout { |
| VkImageLayout layout; |
| ExtEnabled DeviceExtensions::*extension; |
| }; |
| const static std::array<ExtensionLayout, 8> extended_layouts{{ |
| // Note double brace req'd for aggregate initialization |
| {VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR, &DeviceExtensions::vk_khr_shared_presentable_image}, |
| {VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL, &DeviceExtensions::vk_khr_maintenance2}, |
| {VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_STENCIL_READ_ONLY_OPTIMAL, &DeviceExtensions::vk_khr_maintenance2}, |
| {VK_IMAGE_LAYOUT_READ_ONLY_OPTIMAL_KHR, &DeviceExtensions::vk_khr_synchronization2}, |
| {VK_IMAGE_LAYOUT_ATTACHMENT_OPTIMAL_KHR, &DeviceExtensions::vk_khr_synchronization2}, |
| {VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_OPTIMAL, &DeviceExtensions::vk_khr_separate_depth_stencil_layouts}, |
| {VK_IMAGE_LAYOUT_STENCIL_READ_ONLY_OPTIMAL, &DeviceExtensions::vk_khr_separate_depth_stencil_layouts}, |
| {VK_IMAGE_LAYOUT_ATTACHMENT_FEEDBACK_LOOP_OPTIMAL_EXT, &DeviceExtensions::vk_ext_attachment_feedback_loop_layout}, |
| }}; |
| auto is_layout = [image_layout, this](const ExtensionLayout &ext_layout) { |
| return IsExtEnabled(device_extensions.*(ext_layout.extension)) && (ext_layout.layout == image_layout); |
| }; |
| |
| bool valid_layout = (std::find(valid_layouts.cbegin(), valid_layouts.cend(), image_layout) != valid_layouts.cend()) || |
| std::any_of(extended_layouts.cbegin(), extended_layouts.cend(), is_layout); |
| |
| if (!valid_layout) { |
| // The following works as currently all 3 descriptor types share the same set of valid layouts |
| switch (type) { |
| case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-04149"; |
| break; |
| case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-04150"; |
| break; |
| case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT: |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-04151"; |
| break; |
| default: |
| break; |
| } |
| std::stringstream error_str; |
| error_str << "Descriptor update with descriptorType " << string_VkDescriptorType(type) |
| << " is being updated with invalid imageLayout " << string_VkImageLayout(image_layout) << " for image " |
| << report_data->FormatHandle(image) << " in imageView " << report_data->FormatHandle(image_view) |
| << ". Allowed layouts are: VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL, " |
| << "VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL, VK_IMAGE_LAYOUT_GENERAL"; |
| for (auto &ext_layout : extended_layouts) { |
| if (IsExtEnabled(device_extensions.*(ext_layout.extension))) { |
| error_str << ", " << string_VkImageLayout(ext_layout.layout); |
| } |
| } |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| |
| if ((type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) || (type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) { |
| const VkComponentMapping components = iv_state->create_info.components; |
| if (IsIdentitySwizzle(components) == false) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00336"; |
| std::stringstream error_str; |
| error_str << "ImageView (" << report_data->FormatHandle(image_view) << ") has a non-identiy swizzle component, " |
| << " r swizzle = " << string_VkComponentSwizzle(components.r) << "," |
| << " g swizzle = " << string_VkComponentSwizzle(components.g) << "," |
| << " b swizzle = " << string_VkComponentSwizzle(components.b) << "," |
| << " a swizzle = " << string_VkComponentSwizzle(components.a) << "."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| |
| if ((type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT) && (iv_state->min_lod != 0.0f)) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-06450"; |
| std::stringstream error_str; |
| error_str << "ImageView (" << report_data->FormatHandle(image_view) |
| << ") , written to a descriptor of type VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT with a minLod (" << iv_state->min_lod |
| << ") that is not 0.0"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| |
| if (device_extensions.vk_ext_image_2d_view_of_3d && iv_state->create_info.viewType == VK_IMAGE_VIEW_TYPE_2D && |
| image_node->createInfo.imageType == VK_IMAGE_TYPE_3D) { |
| if ((type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) || (type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) || |
| (type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) { |
| if (!(image_node->createInfo.flags & VK_IMAGE_CREATE_2D_VIEW_COMPATIBLE_BIT_EXT)) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-06710"; |
| std::stringstream error_str; |
| error_str << "ImageView (" << report_data->FormatHandle(image_view) |
| << ") , is a 2D image view created from 3D image (" << report_data->FormatHandle(image) |
| << ") , written to a descriptor of type " << string_VkDescriptorType(type) |
| << " but the image used to create the image view was not created with " |
| "VK_IMAGE_CREATE_2D_VIEW_COMPATIBLE_BIT_EXT set"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| if (type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE && !enabled_features.image_2d_view_of_3d_features.image2DViewOf3D) { |
| *error_code = "VUID-VkDescriptorImageInfo-descriptorType-06713"; |
| std::stringstream error_str; |
| error_str << "ImageView (" << report_data->FormatHandle(image_view) |
| << ") , is a 2D image view created from 3D image (" << report_data->FormatHandle(image) |
| << ") , written to a descriptor of type VK_DESCRIPTOR_TYPE_STORAGE_IMAGE" |
| << " and the image2DViewOf3D feature is not enabled"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| if ((type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE || type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) && |
| !enabled_features.image_2d_view_of_3d_features.sampler2DViewOf3D) { |
| *error_code = "VUID-VkDescriptorImageInfo-descriptorType-06714"; |
| std::stringstream error_str; |
| error_str << "ImageView (" << report_data->FormatHandle(image_view) |
| << ") , is a 2D image view created from 3D image (" << report_data->FormatHandle(image) |
| << ") , written to a descriptor of type " << string_VkDescriptorType(type) |
| << " and the image2DViewOf3D feature is not enabled"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| } |
| |
| return true; |
| } |
| |
| // This is a helper function that iterates over a set of Write and Copy updates, pulls the DescriptorSet* for updated |
| // sets, and then calls their respective Validate[Write|Copy]Update functions. |
| // If the update hits an issue for which the callback returns "true", meaning that the call down the chain should |
| // be skipped, then true is returned. |
| // If there is no issue with the update, then false is returned. |
| bool CoreChecks::ValidateUpdateDescriptorSets(uint32_t write_count, const VkWriteDescriptorSet *p_wds, uint32_t copy_count, |
| const VkCopyDescriptorSet *p_cds, const char *func_name) const { |
| bool skip = false; |
| // Validate Write updates |
| for (uint32_t i = 0; i < write_count; i++) { |
| auto dest_set = p_wds[i].dstSet; |
| auto set_node = Get<cvdescriptorset::DescriptorSet>(dest_set); |
| if (!set_node) { |
| skip |= LogError(dest_set, kVUID_Core_DrawState_InvalidDescriptorSet, |
| "Cannot call %s on %s that has not been allocated in pDescriptorWrites[%u].", func_name, |
| report_data->FormatHandle(dest_set).c_str(), i); |
| } else { |
| std::string error_code; |
| std::string error_str; |
| if (!ValidateWriteUpdate(set_node.get(), &p_wds[i], func_name, &error_code, &error_str, false)) { |
| skip |= |
| LogError(dest_set, error_code, "%s pDescriptorWrites[%u] failed write update validation for %s with error: %s.", |
| func_name, i, report_data->FormatHandle(dest_set).c_str(), error_str.c_str()); |
| } |
| } |
| if (p_wds[i].pNext) { |
| const auto *pnext_struct = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureKHR>(p_wds[i].pNext); |
| if (pnext_struct) { |
| for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) { |
| auto as_state = Get<ACCELERATION_STRUCTURE_STATE_KHR>(pnext_struct->pAccelerationStructures[j]); |
| if (as_state && (as_state->create_infoKHR.sType == VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_CREATE_INFO_KHR && |
| (as_state->create_infoKHR.type != VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && |
| as_state->create_infoKHR.type != VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR))) { |
| skip |= |
| LogError(dest_set, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-pAccelerationStructures-03579", |
| "%s: For pDescriptorWrites[%u] acceleration structure in pAccelerationStructures[%u] must " |
| "have been created with " |
| "VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR or VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR.", |
| func_name, i, j); |
| } |
| } |
| } |
| const auto *pnext_struct_nv = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureNV>(p_wds[i].pNext); |
| if (pnext_struct_nv) { |
| for (uint32_t j = 0; j < pnext_struct_nv->accelerationStructureCount; ++j) { |
| auto as_state = Get<ACCELERATION_STRUCTURE_STATE>(pnext_struct_nv->pAccelerationStructures[j]); |
| if (as_state && (as_state->create_infoNV.sType == VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_CREATE_INFO_NV && |
| as_state->create_infoNV.info.type != VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV)) { |
| skip |= LogError(dest_set, "VUID-VkWriteDescriptorSetAccelerationStructureNV-pAccelerationStructures-03748", |
| "%s: For pDescriptorWrites[%u] acceleration structure in pAccelerationStructures[%u] must " |
| "have been created with" |
| " VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV.", |
| func_name, i, j); |
| } |
| } |
| } |
| } |
| } |
| // Now validate copy updates |
| for (uint32_t i = 0; i < copy_count; ++i) { |
| auto dst_set = p_cds[i].dstSet; |
| auto src_set = p_cds[i].srcSet; |
| auto src_node = Get<cvdescriptorset::DescriptorSet>(src_set); |
| auto dst_node = Get<cvdescriptorset::DescriptorSet>(dst_set); |
| // Object_tracker verifies that src & dest descriptor set are valid |
| assert(src_node); |
| assert(dst_node); |
| std::string error_code; |
| std::string error_str; |
| if (!ValidateCopyUpdate(&p_cds[i], dst_node.get(), src_node.get(), func_name, &error_code, &error_str)) { |
| LogObjectList objlist(dst_set); |
| objlist.add(src_set); |
| skip |= LogError(objlist, error_code, "%s pDescriptorCopies[%u] failed copy update from %s to %s with error: %s.", |
| func_name, i, report_data->FormatHandle(src_set).c_str(), report_data->FormatHandle(dst_set).c_str(), |
| error_str.c_str()); |
| } |
| } |
| return skip; |
| } |
| |
| cvdescriptorset::DecodedTemplateUpdate::DecodedTemplateUpdate(const ValidationStateTracker *device_data, |
| VkDescriptorSet descriptorSet, |
| const UPDATE_TEMPLATE_STATE *template_state, const void *pData, |
| VkDescriptorSetLayout push_layout) { |
| auto const &create_info = template_state->create_info; |
| inline_infos.resize(create_info.descriptorUpdateEntryCount); // Make sure we have one if we need it |
| inline_infos_khr.resize(create_info.descriptorUpdateEntryCount); |
| inline_infos_nv.resize(create_info.descriptorUpdateEntryCount); |
| desc_writes.reserve(create_info.descriptorUpdateEntryCount); // emplaced, so reserved without initialization |
| VkDescriptorSetLayout effective_dsl = create_info.templateType == VK_DESCRIPTOR_UPDATE_TEMPLATE_TYPE_DESCRIPTOR_SET |
| ? create_info.descriptorSetLayout |
| : push_layout; |
| auto layout_obj = device_data->Get<cvdescriptorset::DescriptorSetLayout>(effective_dsl); |
| |
| // Create a WriteDescriptorSet struct for each template update entry |
| for (uint32_t i = 0; i < create_info.descriptorUpdateEntryCount; i++) { |
| auto binding_count = layout_obj->GetDescriptorCountFromBinding(create_info.pDescriptorUpdateEntries[i].dstBinding); |
| auto binding_being_updated = create_info.pDescriptorUpdateEntries[i].dstBinding; |
| auto dst_array_element = create_info.pDescriptorUpdateEntries[i].dstArrayElement; |
| |
| desc_writes.reserve(desc_writes.size() + create_info.pDescriptorUpdateEntries[i].descriptorCount); |
| for (uint32_t j = 0; j < create_info.pDescriptorUpdateEntries[i].descriptorCount; j++) { |
| desc_writes.emplace_back(); |
| auto &write_entry = desc_writes.back(); |
| |
| size_t offset = create_info.pDescriptorUpdateEntries[i].offset + j * create_info.pDescriptorUpdateEntries[i].stride; |
| char *update_entry = (char *)(pData) + offset; |
| |
| if (dst_array_element >= binding_count) { |
| dst_array_element = 0; |
| binding_being_updated = layout_obj->GetNextValidBinding(binding_being_updated); |
| } |
| |
| write_entry.sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET; |
| write_entry.pNext = NULL; |
| write_entry.dstSet = descriptorSet; |
| write_entry.dstBinding = binding_being_updated; |
| write_entry.dstArrayElement = dst_array_element; |
| write_entry.descriptorCount = 1; |
| write_entry.descriptorType = create_info.pDescriptorUpdateEntries[i].descriptorType; |
| |
| switch (create_info.pDescriptorUpdateEntries[i].descriptorType) { |
| case VK_DESCRIPTOR_TYPE_SAMPLER: |
| case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: |
| case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: |
| case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: |
| case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT: |
| write_entry.pImageInfo = reinterpret_cast<VkDescriptorImageInfo *>(update_entry); |
| break; |
| |
| case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: |
| case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: |
| case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: |
| case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: |
| write_entry.pBufferInfo = reinterpret_cast<VkDescriptorBufferInfo *>(update_entry); |
| break; |
| |
| case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: |
| case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: |
| write_entry.pTexelBufferView = reinterpret_cast<VkBufferView *>(update_entry); |
| break; |
| case VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT: { |
| VkWriteDescriptorSetInlineUniformBlockEXT *inline_info = &inline_infos[i]; |
| inline_info->sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET_INLINE_UNIFORM_BLOCK_EXT; |
| inline_info->pNext = nullptr; |
| inline_info->dataSize = create_info.pDescriptorUpdateEntries[i].descriptorCount; |
| inline_info->pData = update_entry; |
| write_entry.pNext = inline_info; |
| // descriptorCount must match the dataSize member of the VkWriteDescriptorSetInlineUniformBlockEXT structure |
| write_entry.descriptorCount = inline_info->dataSize; |
| // skip the rest of the array, they just represent bytes in the update |
| j = create_info.pDescriptorUpdateEntries[i].descriptorCount; |
| break; |
| } |
| case VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR: { |
| VkWriteDescriptorSetAccelerationStructureKHR *inline_info_khr = &inline_infos_khr[i]; |
| inline_info_khr->sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET_ACCELERATION_STRUCTURE_KHR; |
| inline_info_khr->pNext = nullptr; |
| inline_info_khr->accelerationStructureCount = create_info.pDescriptorUpdateEntries[i].descriptorCount; |
| inline_info_khr->pAccelerationStructures = reinterpret_cast<VkAccelerationStructureKHR *>(update_entry); |
| write_entry.pNext = inline_info_khr; |
| break; |
| } |
| case VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV: { |
| VkWriteDescriptorSetAccelerationStructureNV *inline_info_nv = &inline_infos_nv[i]; |
| inline_info_nv->sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET_ACCELERATION_STRUCTURE_NV; |
| inline_info_nv->pNext = nullptr; |
| inline_info_nv->accelerationStructureCount = create_info.pDescriptorUpdateEntries[i].descriptorCount; |
| inline_info_nv->pAccelerationStructures = reinterpret_cast<VkAccelerationStructureNV *>(update_entry); |
| write_entry.pNext = inline_info_nv; |
| break; |
| } |
| default: |
| assert(0); |
| break; |
| } |
| dst_array_element++; |
| } |
| } |
| } |
| // These helper functions carry out the validate and record descriptor updates peformed via update templates. They decode |
| // the templatized data and leverage the non-template UpdateDescriptor helper functions. |
| bool CoreChecks::ValidateUpdateDescriptorSetsWithTemplateKHR(VkDescriptorSet descriptorSet, |
| const UPDATE_TEMPLATE_STATE *template_state, const void *pData) const { |
| // Translate the templated update into a normal update for validation... |
| cvdescriptorset::DecodedTemplateUpdate decoded_update(this, descriptorSet, template_state, pData); |
| return ValidateUpdateDescriptorSets(static_cast<uint32_t>(decoded_update.desc_writes.size()), decoded_update.desc_writes.data(), |
| 0, NULL, "vkUpdateDescriptorSetWithTemplate()"); |
| } |
| |
| std::string cvdescriptorset::DescriptorSet::StringifySetAndLayout() const { |
| std::string out; |
| auto layout_handle = layout_->GetDescriptorSetLayout(); |
| if (IsPushDescriptor()) { |
| std::ostringstream str; |
| str << "Push Descriptors defined with " << state_data_->report_data->FormatHandle(layout_handle); |
| out = str.str(); |
| } else { |
| std::ostringstream str; |
| str << state_data_->report_data->FormatHandle(GetSet()) << " allocated with " |
| << state_data_->report_data->FormatHandle(layout_handle); |
| out = str.str(); |
| } |
| return out; |
| }; |
| |
| // Loop through the write updates to validate for a push descriptor set, ignoring dstSet |
| bool CoreChecks::ValidatePushDescriptorsUpdate(const DescriptorSet *push_set, uint32_t write_count, |
| const VkWriteDescriptorSet *p_wds, const char *func_name) const { |
| assert(push_set->IsPushDescriptor()); |
| bool skip = false; |
| for (uint32_t i = 0; i < write_count; i++) { |
| std::string error_code; |
| std::string error_str; |
| if (!ValidateWriteUpdate(push_set, &p_wds[i], func_name, &error_code, &error_str, true)) { |
| skip |= LogError(push_set->GetDescriptorSetLayout(), error_code, |
| "%s VkWriteDescriptorSet[%u] failed update validation: %s.", func_name, i, error_str.c_str()); |
| } |
| } |
| return skip; |
| } |
| |
| // For the given buffer, verify that its creation parameters are appropriate for the given type |
| // If there's an error, update the error_msg string with details and return false, else return true |
| static bool ValidateBufferUsage(debug_report_data *report_data, BUFFER_STATE const *buffer_node, VkDescriptorType type, |
| std::string *error_code, std::string *error_msg) { |
| // Verify that usage bits set correctly for given type |
| auto usage = buffer_node->createInfo.usage; |
| const char *error_usage_bit = nullptr; |
| switch (type) { |
| case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: |
| if (!(usage & VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT)) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00334"; |
| error_usage_bit = "VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT"; |
| } |
| break; |
| case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: |
| if (!(usage & VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT)) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00335"; |
| error_usage_bit = "VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT"; |
| } |
| break; |
| case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: |
| case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: |
| if (!(usage & VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT)) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00330"; |
| error_usage_bit = "VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT"; |
| } |
| break; |
| case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: |
| case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: |
| if (!(usage & VK_BUFFER_USAGE_STORAGE_BUFFER_BIT)) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00331"; |
| error_usage_bit = "VK_BUFFER_USAGE_STORAGE_BUFFER_BIT"; |
| } |
| break; |
| default: |
| break; |
| } |
| if (error_usage_bit) { |
| std::stringstream error_str; |
| error_str << "Buffer (" << report_data->FormatHandle(buffer_node->buffer()) << ") with usage mask " << std::hex |
| << std::showbase << usage << " being used for a descriptor update of type " << string_VkDescriptorType(type) |
| << " does not have " << error_usage_bit << " set."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| return true; |
| } |
| |
| // For buffer descriptor updates, verify the buffer usage and VkDescriptorBufferInfo struct which includes: |
| // 1. buffer is valid |
| // 2. buffer was created with correct usage flags |
| // 3. offset is less than buffer size |
| // 4. range is either VK_WHOLE_SIZE or falls in (0, (buffer size - offset)] |
| // 5. range and offset are within the device's limits |
| // If there's an error, update the error_msg string with details and return false, else return true |
| bool CoreChecks::ValidateBufferUpdate(VkDescriptorBufferInfo const *buffer_info, VkDescriptorType type, const char *func_name, |
| std::string *error_code, std::string *error_msg) const { |
| // First make sure that buffer is valid |
| auto buffer_node = Get<BUFFER_STATE>(buffer_info->buffer); |
| // Any invalid buffer should already be caught by object_tracker |
| assert(buffer_node); |
| if (ValidateMemoryIsBoundToBuffer(buffer_node.get(), func_name, "VUID-VkWriteDescriptorSet-descriptorType-00329")) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00329"; |
| *error_msg = "No memory bound to buffer."; |
| return false; |
| } |
| // Verify usage bits |
| if (!ValidateBufferUsage(report_data, buffer_node.get(), type, error_code, error_msg)) { |
| // error_msg will have been updated by ValidateBufferUsage() |
| return false; |
| } |
| // offset must be less than buffer size |
| if (buffer_info->offset >= buffer_node->createInfo.size) { |
| *error_code = "VUID-VkDescriptorBufferInfo-offset-00340"; |
| std::stringstream error_str; |
| error_str << "VkDescriptorBufferInfo offset of " << buffer_info->offset << " is greater than or equal to buffer " |
| << report_data->FormatHandle(buffer_node->buffer()) << " size of " << buffer_node->createInfo.size; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| if (buffer_info->range != VK_WHOLE_SIZE) { |
| // Range must be VK_WHOLE_SIZE or > 0 |
| if (!buffer_info->range) { |
| *error_code = "VUID-VkDescriptorBufferInfo-range-00341"; |
| std::stringstream error_str; |
| error_str << "For buffer " << report_data->FormatHandle(buffer_node->buffer()) |
| << " VkDescriptorBufferInfo range is not VK_WHOLE_SIZE and is zero, which is not allowed."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| // Range must be VK_WHOLE_SIZE or <= (buffer size - offset) |
| if (buffer_info->range > (buffer_node->createInfo.size - buffer_info->offset)) { |
| *error_code = "VUID-VkDescriptorBufferInfo-range-00342"; |
| std::stringstream error_str; |
| error_str << "For buffer " << report_data->FormatHandle(buffer_node->buffer()) << " VkDescriptorBufferInfo range is " |
| << buffer_info->range << " which is greater than buffer size (" << buffer_node->createInfo.size |
| << ") minus requested offset of " << buffer_info->offset; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| // Check buffer update sizes against device limits |
| const auto &limits = phys_dev_props.limits; |
| if (VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER == type || VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC == type) { |
| auto max_ub_range = limits.maxUniformBufferRange; |
| if (buffer_info->range != VK_WHOLE_SIZE && buffer_info->range > max_ub_range) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00332"; |
| std::stringstream error_str; |
| error_str << "For buffer " << report_data->FormatHandle(buffer_node->buffer()) << " VkDescriptorBufferInfo range is " |
| << buffer_info->range << " which is greater than this device's maxUniformBufferRange (" << max_ub_range |
| << ")"; |
| *error_msg = error_str.str(); |
| return false; |
| } else if (buffer_info->range == VK_WHOLE_SIZE && (buffer_node->createInfo.size - buffer_info->offset) > max_ub_range) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00332"; |
| std::stringstream error_str; |
| error_str << "For buffer " << report_data->FormatHandle(buffer_node->buffer()) |
| << " VkDescriptorBufferInfo range is VK_WHOLE_SIZE but effective range " |
| << "(" << (buffer_node->createInfo.size - buffer_info->offset) << ") is greater than this device's " |
| << "maxUniformBufferRange (" << max_ub_range << ")"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } else if (VK_DESCRIPTOR_TYPE_STORAGE_BUFFER == type || VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC == type) { |
| auto max_sb_range = limits.maxStorageBufferRange; |
| if (buffer_info->range != VK_WHOLE_SIZE && buffer_info->range > max_sb_range) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00333"; |
| std::stringstream error_str; |
| error_str << "For buffer " << report_data->FormatHandle(buffer_node->buffer()) << " VkDescriptorBufferInfo range is " |
| << buffer_info->range << " which is greater than this device's maxStorageBufferRange (" << max_sb_range |
| << ")"; |
| *error_msg = error_str.str(); |
| return false; |
| } else if (buffer_info->range == VK_WHOLE_SIZE && (buffer_node->createInfo.size - buffer_info->offset) > max_sb_range) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00333"; |
| std::stringstream error_str; |
| error_str << "For buffer " << report_data->FormatHandle(buffer_node->buffer()) |
| << " VkDescriptorBufferInfo range is VK_WHOLE_SIZE but effective range " |
| << "(" << (buffer_node->createInfo.size - buffer_info->offset) << ") is greater than this device's " |
| << "maxStorageBufferRange (" << max_sb_range << ")"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| return true; |
| } |
| |
| template <typename T> |
| bool CoreChecks::ValidateAccelerationStructureUpdate(T acc_node, const char *func_name, std::string *error_code, |
| std::string *error_msg) const { |
| // nullDescriptor feature allows this to be VK_NULL_HANDLE |
| if (acc_node) { |
| if (ValidateMemoryIsBoundToAccelerationStructure(acc_node, func_name, kVUIDUndefined)) { |
| *error_code = kVUIDUndefined; |
| *error_msg = "No memory bound to acceleration structure."; |
| return false; |
| } |
| } |
| return true; |
| } |
| |
| // Verify that the contents of the update are ok, but don't perform actual update |
| bool CoreChecks::VerifyCopyUpdateContents(const VkCopyDescriptorSet *update, const DescriptorSet *src_set, |
| VkDescriptorType src_type, uint32_t src_index, const DescriptorSet *dst_set, |
| VkDescriptorType dst_type, uint32_t dst_index, const char *func_name, |
| std::string *error_code, std::string *error_msg) const { |
| // Note : Repurposing some Write update error codes here as specific details aren't called out for copy updates like they are |
| // for write updates |
| using DescriptorClass = cvdescriptorset::DescriptorClass; |
| using BufferDescriptor = cvdescriptorset::BufferDescriptor; |
| using ImageDescriptor = cvdescriptorset::ImageDescriptor; |
| using ImageSamplerDescriptor = cvdescriptorset::ImageSamplerDescriptor; |
| using SamplerDescriptor = cvdescriptorset::SamplerDescriptor; |
| using TexelDescriptor = cvdescriptorset::TexelDescriptor; |
| |
| auto device_data = this; |
| |
| if (dst_type == VK_DESCRIPTOR_TYPE_SAMPLER) { |
| auto dst_iter = dst_set->FindDescriptor(update->dstBinding, update->dstArrayElement); |
| for (uint32_t di = 0; di < update->descriptorCount; ++di, ++dst_iter) { |
| if (dst_iter.updated() && dst_iter->IsImmutableSampler()) { |
| *error_code = "VUID-VkCopyDescriptorSet-dstBinding-02753"; |
| std::stringstream error_str; |
| error_str << "Attempted copy update to an immutable sampler descriptor."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| } |
| |
| switch (src_set->GetBinding(update->srcBinding)->descriptor_class) { |
| case DescriptorClass::PlainSampler: { |
| auto src_iter = src_set->FindDescriptor(update->srcBinding, update->srcArrayElement); |
| for (uint32_t di = 0; di < update->descriptorCount; ++di) { |
| if (src_iter.updated()) { |
| if (!src_iter->IsImmutableSampler()) { |
| auto update_sampler = static_cast<const SamplerDescriptor &>(*src_iter).GetSampler(); |
| if (!ValidateSampler(update_sampler)) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00325"; |
| std::stringstream error_str; |
| error_str << "Attempted copy update to sampler descriptor with invalid sampler: " |
| << report_data->FormatHandle(update_sampler) << "."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } else { |
| // TODO : Warn here |
| } |
| } |
| } |
| break; |
| } |
| case DescriptorClass::ImageSampler: { |
| auto src_iter = src_set->FindDescriptor(update->srcBinding, update->srcArrayElement); |
| for (uint32_t di = 0; di < update->descriptorCount; ++di, ++src_iter) { |
| if (!src_iter.updated()) continue; |
| auto img_samp_desc = static_cast<const ImageSamplerDescriptor &>(*src_iter); |
| // First validate sampler |
| if (!img_samp_desc.IsImmutableSampler()) { |
| auto update_sampler = img_samp_desc.GetSampler(); |
| if (!ValidateSampler(update_sampler)) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00325"; |
| std::stringstream error_str; |
| error_str << "Attempted copy update to sampler descriptor with invalid sampler: " |
| << report_data->FormatHandle(update_sampler) << "."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } else { |
| // TODO : Warn here |
| } |
| // Validate image |
| auto image_view = img_samp_desc.GetImageView(); |
| auto image_layout = img_samp_desc.GetImageLayout(); |
| if (image_view) { |
| if (!ValidateImageUpdate(image_view, image_layout, src_type, func_name, error_code, error_msg)) { |
| std::stringstream error_str; |
| error_str << "Attempted copy update to combined image sampler descriptor failed due to: " |
| << error_msg->c_str(); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| } |
| break; |
| } |
| case DescriptorClass::Image: { |
| auto src_iter = src_set->FindDescriptor(update->srcBinding, update->srcArrayElement); |
| for (uint32_t di = 0; di < update->descriptorCount; ++di, ++src_iter) { |
| if (!src_iter.updated()) continue; |
| auto img_desc = static_cast<const ImageDescriptor &>(*src_iter); |
| auto image_view = img_desc.GetImageView(); |
| auto image_layout = img_desc.GetImageLayout(); |
| if (image_view) { |
| if (!ValidateImageUpdate(image_view, image_layout, src_type, func_name, error_code, error_msg)) { |
| std::stringstream error_str; |
| error_str << "Attempted copy update to image descriptor failed due to: " << error_msg->c_str(); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| } |
| break; |
| } |
| case DescriptorClass::TexelBuffer: { |
| auto src_iter = src_set->FindDescriptor(update->srcBinding, update->srcArrayElement); |
| for (uint32_t di = 0; di < update->descriptorCount; ++di, ++src_iter) { |
| if (!src_iter.updated()) continue; |
| auto buffer_view = static_cast<const TexelDescriptor &>(*src_iter).GetBufferView(); |
| if (buffer_view) { |
| auto bv_state = device_data->Get<BUFFER_VIEW_STATE>(buffer_view); |
| if (!bv_state) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-02994"; |
| std::stringstream error_str; |
| error_str << "Attempted copy update to texel buffer descriptor with invalid buffer view: " |
| << report_data->FormatHandle(buffer_view); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| auto buffer = bv_state->create_info.buffer; |
| auto buffer_state = Get<BUFFER_STATE>(buffer); |
| if (!ValidateBufferUsage(report_data, buffer_state.get(), src_type, error_code, error_msg)) { |
| std::stringstream error_str; |
| error_str << "Attempted copy update to texel buffer descriptor failed due to: " << error_msg->c_str(); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| } |
| break; |
| } |
| case DescriptorClass::GeneralBuffer: { |
| auto src_iter = src_set->FindDescriptor(update->srcBinding, update->srcArrayElement); |
| for (uint32_t di = 0; di < update->descriptorCount; ++di, ++src_iter) { |
| if (!src_iter.updated()) continue; |
| auto buffer_state = static_cast<const BufferDescriptor &>(*src_iter).GetBufferState(); |
| if (buffer_state) { |
| if (!ValidateBufferUsage(report_data, buffer_state, src_type, error_code, error_msg)) { |
| std::stringstream error_str; |
| error_str << "Attempted copy update to buffer descriptor failed due to: " << error_msg->c_str(); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| } |
| break; |
| } |
| case DescriptorClass::InlineUniform: |
| case DescriptorClass::AccelerationStructure: |
| case DescriptorClass::Mutable: |
| break; |
| default: |
| assert(0); // We've already verified update type so should never get here |
| break; |
| } |
| // All checks passed so update contents are good |
| return true; |
| } |
| |
| // Verify that the state at allocate time is correct, but don't actually allocate the sets yet |
| bool CoreChecks::ValidateAllocateDescriptorSets(const VkDescriptorSetAllocateInfo *p_alloc_info, |
| const cvdescriptorset::AllocateDescriptorSetsData *ds_data) const { |
| bool skip = false; |
| auto pool_state = Get<DESCRIPTOR_POOL_STATE>(p_alloc_info->descriptorPool); |
| |
| for (uint32_t i = 0; i < p_alloc_info->descriptorSetCount; i++) { |
| auto layout = Get<cvdescriptorset::DescriptorSetLayout>(p_alloc_info->pSetLayouts[i]); |
| if (layout) { // nullptr layout indicates no valid layout handle for this device, validated/logged in object_tracker |
| if (layout->IsPushDescriptor()) { |
| skip |= LogError(p_alloc_info->pSetLayouts[i], "VUID-VkDescriptorSetAllocateInfo-pSetLayouts-00308", |
| "%s specified at pSetLayouts[%" PRIu32 |
| "] in vkAllocateDescriptorSets() was created with invalid flag %s set.", |
| report_data->FormatHandle(p_alloc_info->pSetLayouts[i]).c_str(), i, |
| "VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR"); |
| } |
| if (layout->GetCreateFlags() & VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT && |
| !(pool_state->createInfo.flags & VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT)) { |
| skip |= LogError( |
| device, "VUID-VkDescriptorSetAllocateInfo-pSetLayouts-03044", |
| "vkAllocateDescriptorSets(): Descriptor set layout create flags and pool create flags mismatch for index (%d)", |
| i); |
| } |
| if (layout->GetCreateFlags() & VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_EXT && |
| !(pool_state->createInfo.flags & VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_EXT)) { |
| skip |= LogError(device, "VUID-VkDescriptorSetAllocateInfo-pSetLayouts-04610", |
| "vkAllocateDescriptorSets(): pSetLayouts[%d].flags contain " |
| "VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_EXT bit, but the pool was not created " |
| "with the VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_EXT bit.", |
| i); |
| } |
| } |
| } |
| if (!IsExtEnabled(device_extensions.vk_khr_maintenance1)) { |
| // Track number of descriptorSets allowable in this pool |
| if (pool_state->GetAvailableSets() < p_alloc_info->descriptorSetCount) { |
| skip |= LogError(pool_state->Handle(), "VUID-VkDescriptorSetAllocateInfo-descriptorSetCount-00306", |
| "vkAllocateDescriptorSets(): Unable to allocate %u descriptorSets from %s" |
| ". This pool only has %d descriptorSets remaining.", |
| p_alloc_info->descriptorSetCount, report_data->FormatHandle(pool_state->Handle()).c_str(), |
| pool_state->GetAvailableSets()); |
| } |
| // Determine whether descriptor counts are satisfiable |
| for (auto it = ds_data->required_descriptors_by_type.begin(); it != ds_data->required_descriptors_by_type.end(); ++it) { |
| auto available_count = pool_state->GetAvailableCount(it->first); |
| |
| if (ds_data->required_descriptors_by_type.at(it->first) > available_count) { |
| skip |= LogError(pool_state->Handle(), "VUID-VkDescriptorSetAllocateInfo-descriptorPool-00307", |
| "vkAllocateDescriptorSets(): Unable to allocate %u descriptors of type %s from %s" |
| ". This pool only has %d descriptors of this type remaining.", |
| ds_data->required_descriptors_by_type.at(it->first), |
| string_VkDescriptorType(VkDescriptorType(it->first)), |
| report_data->FormatHandle(pool_state->Handle()).c_str(), available_count); |
| } |
| } |
| } |
| |
| const auto *count_allocate_info = LvlFindInChain<VkDescriptorSetVariableDescriptorCountAllocateInfo>(p_alloc_info->pNext); |
| |
| if (count_allocate_info) { |
| if (count_allocate_info->descriptorSetCount != 0 && |
| count_allocate_info->descriptorSetCount != p_alloc_info->descriptorSetCount) { |
| skip |= LogError(device, "VUID-VkDescriptorSetVariableDescriptorCountAllocateInfo-descriptorSetCount-03045", |
| "vkAllocateDescriptorSets(): VkDescriptorSetAllocateInfo::descriptorSetCount (%d) != " |
| "VkDescriptorSetVariableDescriptorCountAllocateInfo::descriptorSetCount (%d)", |
| p_alloc_info->descriptorSetCount, count_allocate_info->descriptorSetCount); |
| } |
| if (count_allocate_info->descriptorSetCount == p_alloc_info->descriptorSetCount) { |
| for (uint32_t i = 0; i < p_alloc_info->descriptorSetCount; i++) { |
| auto layout = Get<cvdescriptorset::DescriptorSetLayout>(p_alloc_info->pSetLayouts[i]); |
| if (count_allocate_info->pDescriptorCounts[i] > layout->GetDescriptorCountFromBinding(layout->GetMaxBinding())) { |
| skip |= LogError(device, "VUID-VkDescriptorSetVariableDescriptorCountAllocateInfo-pSetLayouts-03046", |
| "vkAllocateDescriptorSets(): pDescriptorCounts[%d] = (%d), binding's descriptorCount = (%d)", |
| i, count_allocate_info->pDescriptorCounts[i], |
| layout->GetDescriptorCountFromBinding(layout->GetMaxBinding())); |
| } |
| } |
| } |
| } |
| |
| return skip; |
| } |
| |
| // Validate the state for a given write update but don't actually perform the update |
| // If an error would occur for this update, return false and fill in details in error_msg string |
| bool CoreChecks::ValidateWriteUpdate(const DescriptorSet *dest_set, const VkWriteDescriptorSet *update, const char *func_name, |
| std::string *error_code, std::string *error_msg, bool push) const { |
| const auto *dest_layout = dest_set->GetLayout().get(); |
| |
| // Verify dst layout still valid |
| if (dest_layout->Destroyed()) { |
| *error_code = "VUID-VkWriteDescriptorSet-dstSet-00320"; |
| std::ostringstream str; |
| str << "Cannot call " << func_name << " to perform write update on " << dest_set->StringifySetAndLayout() |
| << " which has been destroyed"; |
| *error_msg = str.str(); |
| return false; |
| } |
| // Verify dst binding exists |
| if (!dest_layout->HasBinding(update->dstBinding)) { |
| *error_code = "VUID-VkWriteDescriptorSet-dstBinding-00315"; |
| std::stringstream error_str; |
| error_str << dest_set->StringifySetAndLayout() << " does not have binding " << update->dstBinding; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| |
| auto dest = dest_set->GetBinding(update->dstBinding); |
| // Make sure binding isn't empty |
| if (0 == dest->count) { |
| *error_code = "VUID-VkWriteDescriptorSet-dstBinding-00316"; |
| std::stringstream error_str; |
| error_str << dest_set->StringifySetAndLayout() << " cannot updated binding " << update->dstBinding |
| << " that has 0 descriptors"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| |
| // Verify idle ds |
| if (dest_set->InUse() && !(dest->IsBindless())) { |
| *error_code = "VUID-vkUpdateDescriptorSets-None-03047"; |
| std::stringstream error_str; |
| error_str << "Cannot call " << func_name << " to perform write update on " << dest_set->StringifySetAndLayout() |
| << " that is in use by a command buffer"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| // We know that binding is valid, verify update and do update on each descriptor |
| if ((dest->type != VK_DESCRIPTOR_TYPE_MUTABLE_EXT) && (dest->type != update->descriptorType)) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00319"; |
| std::stringstream error_str; |
| error_str << "Attempting write update to " << dest_set->StringifySetAndLayout() << " binding #" << update->dstBinding |
| << " with type " << string_VkDescriptorType(dest->type) << " but update type is " |
| << string_VkDescriptorType(update->descriptorType); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| if (dest->type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT) { |
| if ((update->dstArrayElement % 4) != 0) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-02219"; |
| std::stringstream error_str; |
| error_str << "Attempting write update to " << dest_set->StringifySetAndLayout() << " binding #" << update->dstBinding |
| << " with " |
| << "dstArrayElement " << update->dstArrayElement << " not a multiple of 4"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| if ((update->descriptorCount % 4) != 0) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-02220"; |
| std::stringstream error_str; |
| error_str << "Attempting write update to " << dest_set->StringifySetAndLayout() << " binding #" << update->dstBinding |
| << " with " |
| << "descriptorCount " << update->descriptorCount << " not a multiple of 4"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| const auto *write_inline_info = LvlFindInChain<VkWriteDescriptorSetInlineUniformBlockEXT>(update->pNext); |
| if (!write_inline_info || write_inline_info->dataSize != update->descriptorCount) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-02221"; |
| std::stringstream error_str; |
| if (!write_inline_info) { |
| error_str << "Attempting write update to " << dest_set->StringifySetAndLayout() << " binding #" |
| << update->dstBinding << " with " |
| << "VkWriteDescriptorSetInlineUniformBlock missing"; |
| } else { |
| error_str << "Attempting write update to " << dest_set->StringifySetAndLayout() << " binding #" |
| << update->dstBinding << " with " |
| << "VkWriteDescriptorSetInlineUniformBlock dataSize " << write_inline_info->dataSize << " not equal to " |
| << "VkWriteDescriptorSet descriptorCount " << update->descriptorCount; |
| } |
| *error_msg = error_str.str(); |
| return false; |
| } |
| // This error is probably unreachable due to the previous two errors |
| if (write_inline_info && (write_inline_info->dataSize % 4) != 0) { |
| *error_code = "VUID-VkWriteDescriptorSetInlineUniformBlock-dataSize-02222"; |
| std::stringstream error_str; |
| error_str << "Attempting write update to " << dest_set->StringifySetAndLayout() << " binding #" << update->dstBinding |
| << " with " |
| << "VkWriteDescriptorSetInlineUniformBlock dataSize " << write_inline_info->dataSize |
| << " not a multiple of 4"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| // Verify all bindings update share identical properties across all items |
| if (update->descriptorCount > 0) { |
| // Save first binding information and error if something different is found |
| auto current_iter = dest_set->FindBinding(update->dstBinding); |
| VkShaderStageFlags stage_flags = (*current_iter)->stage_flags; |
| VkDescriptorType descriptor_type = (*current_iter)->type; |
| bool immutable_samplers = (*current_iter)->has_immutable_samplers; |
| uint32_t dst_array_element = update->dstArrayElement; |
| |
| for (uint32_t i = 0; i < update->descriptorCount;) { |
| if (current_iter == dest_set->end()) { |
| break; // prevents setting error here if bindings don't exist |
| } |
| auto current_binding = current_iter->get(); |
| |
| // All consecutive bindings updated, except those with a descriptorCount of zero, must have identical descType and |
| // stageFlags |
| if (current_binding->count > 0) { |
| // Check for consistent stageFlags and descriptorType |
| if ((current_binding->stage_flags != stage_flags) || (current_binding->type != descriptor_type)) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorCount-00317"; |
| std::stringstream error_str; |
| error_str |
| << "Attempting write update to " << dest_set->StringifySetAndLayout() << " binding #" |
| << current_binding->binding << " (" << i << " from dstBinding offset)" |
| << " with a different stageFlag and/or descriptorType from previous bindings." |
| << " All bindings must have consecutive stageFlag and/or descriptorType across a VkWriteDescriptorSet"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| // Check if all immutableSamplers or not |
| if (current_binding->has_immutable_samplers != immutable_samplers) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorCount-00318"; |
| std::stringstream error_str; |
| error_str << "Attempting write update to " << dest_set->StringifySetAndLayout() << " binding index #" |
| << current_binding->binding << " (" << i << " from dstBinding offset)" |
| << " with a different usage of immutable samplers from previous bindings." |
| << " All bindings must have all or none usage of immutable samplers across a VkWriteDescriptorSet"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| |
| // Skip the remaining descriptors for this binding, and move to the next binding |
| i += (current_binding->count - dst_array_element); |
| dst_array_element = 0; |
| ++current_iter; |
| } |
| } |
| |
| // Verify consecutive bindings match (if needed) |
| if (!VerifyUpdateConsistency(report_data, *dest_set, update->dstBinding, update->dstArrayElement, update->descriptorCount, |
| "write update to", error_msg)) { |
| *error_code = "VUID-VkWriteDescriptorSet-dstArrayElement-00321"; |
| return false; |
| } |
| const auto orig_binding = dest_set->GetBinding(update->dstBinding); |
| // Verify write to variable descriptor |
| if (orig_binding && orig_binding->IsVariableCount()) { |
| if ((update->dstArrayElement + update->descriptorCount) > dest_set->GetVariableDescriptorCount()) { |
| std::stringstream error_str; |
| *error_code = "VUID-VkWriteDescriptorSet-dstArrayElement-00321"; |
| error_str << "Attempting write update to " << dest_set->StringifySetAndLayout() << " binding index #" |
| << update->dstBinding << " array element " << update->dstArrayElement << " with " << update->descriptorCount |
| << " writes but variable descriptor size is " << dest_set->GetVariableDescriptorCount(); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| auto start_idx = dest_set->GetGlobalIndexRangeFromBinding(update->dstBinding).start + update->dstArrayElement; |
| // Update is within bounds and consistent so last step is to validate update contents |
| if (!VerifyWriteUpdateContents(dest_set, update, start_idx, func_name, error_code, error_msg, push)) { |
| std::stringstream error_str; |
| error_str << "Write update to " << dest_set->StringifySetAndLayout() << " binding #" << update->dstBinding |
| << " failed with error message: " << error_msg->c_str(); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| if (orig_binding != nullptr && orig_binding->type == VK_DESCRIPTOR_TYPE_MUTABLE_EXT) { |
| // Check if the new descriptor descriptor type is in the list of allowed mutable types for this binding |
| if (!dest_set->Layout().IsTypeMutable(update->descriptorType, update->dstBinding)) { |
| *error_code = "VUID-VkWriteDescriptorSet-dstSet-04611"; |
| std::stringstream error_str; |
| error_str << "Write update type is " << string_VkDescriptorType(update->descriptorType) |
| << ", but descriptor set layout binding was created with type VK_DESCRIPTOR_TYPE_MUTABLE_EXT and used type " |
| "is not in VkMutableDescriptorTypeListEXT::pDescriptorTypes for this binding."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| // All checks passed, update is clean |
| return true; |
| } |
| |
| // Verify that the contents of the update are ok, but don't perform actual update |
| bool CoreChecks::VerifyWriteUpdateContents(const DescriptorSet *dest_set, const VkWriteDescriptorSet *update, const uint32_t index, |
| const char *func_name, std::string *error_code, std::string *error_msg, |
| bool push) const { |
| using ImageSamplerDescriptor = cvdescriptorset::ImageSamplerDescriptor; |
| |
| switch (update->descriptorType) { |
| case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: { |
| auto iter = dest_set->FindDescriptor(update->dstBinding, update->dstArrayElement); |
| for (uint32_t di = 0; di < update->descriptorCount && !iter.AtEnd(); ++di, ++iter) { |
| // Validate image |
| auto image_view = update->pImageInfo[di].imageView; |
| auto image_layout = update->pImageInfo[di].imageLayout; |
| auto sampler = update->pImageInfo[di].sampler; |
| auto iv_state = Get<IMAGE_VIEW_STATE>(image_view); |
| const ImageSamplerDescriptor &desc = (const ImageSamplerDescriptor &)*iter; |
| if (image_view) { |
| const auto *image_state = iv_state->image_state.get(); |
| if (!ValidateImageUpdate(image_view, image_layout, update->descriptorType, func_name, error_code, error_msg)) { |
| std::stringstream error_str; |
| error_str << "Attempted write update to combined image sampler descriptor failed due to: " |
| << error_msg->c_str(); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| if (IsExtEnabled(device_extensions.vk_khr_sampler_ycbcr_conversion)) { |
| if (desc.IsImmutableSampler()) { |
| auto sampler_state = Get<SAMPLER_STATE>(desc.GetSampler()); |
| if (iv_state && sampler_state) { |
| if (iv_state->samplerConversion != sampler_state->samplerConversion) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-01948"; |
| std::stringstream error_str; |
| error_str |
| << "Attempted write update to combined image sampler and image view and sampler ycbcr " |
| "conversions are not identical, sampler: " |
| << report_data->FormatHandle(desc.GetSampler()) |
| << " image view: " << report_data->FormatHandle(iv_state->image_view()) << "."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| } else { |
| if (iv_state && (iv_state->samplerConversion != VK_NULL_HANDLE)) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-02738"; |
| std::stringstream error_str; |
| error_str << "Because dstSet (" << report_data->FormatHandle(update->dstSet) |
| << ") is bound to image view (" << report_data->FormatHandle(iv_state->image_view()) |
| << ") that includes a YCBCR conversion, it must have been allocated with a layout that " |
| "includes an immutable sampler."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| } |
| // If there is an immutable sampler then |sampler| isn't used, so the following VU does not apply. |
| if (sampler && !desc.IsImmutableSampler() && FormatIsMultiplane(image_state->createInfo.format)) { |
| // multiplane formats must be created with mutable format bit |
| if (0 == (image_state->createInfo.flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT)) { |
| *error_code = "VUID-VkDescriptorImageInfo-sampler-01564"; |
| std::stringstream error_str; |
| error_str << "image " << report_data->FormatHandle(image_state->image()) |
| << " combined image sampler is a multi-planar " |
| << "format and was not was not created with the VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT"; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| // image view need aspect mask for only the planes supported of format |
| VkImageAspectFlags legal_aspect_flags = (VK_IMAGE_ASPECT_PLANE_0_BIT | VK_IMAGE_ASPECT_PLANE_1_BIT); |
| legal_aspect_flags |= |
| (FormatPlaneCount(image_state->createInfo.format) == 3) ? VK_IMAGE_ASPECT_PLANE_2_BIT : 0; |
| if (0 != (iv_state->create_info.subresourceRange.aspectMask & (~legal_aspect_flags))) { |
| *error_code = "VUID-VkDescriptorImageInfo-sampler-01564"; |
| std::stringstream error_str; |
| error_str << "image " << report_data->FormatHandle(image_state->image()) |
| << " combined image sampler is a multi-planar " |
| << "format and " << report_data->FormatHandle(iv_state->image_view()) |
| << " aspectMask must only include " << string_VkImageAspectFlags(legal_aspect_flags); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| |
| // Verify portability |
| auto sampler_state = Get<SAMPLER_STATE>(sampler); |
| if (sampler_state) { |
| if (IsExtEnabled(device_extensions.vk_khr_portability_subset)) { |
| if ((VK_FALSE == enabled_features.portability_subset_features.mutableComparisonSamplers) && |
| (VK_FALSE != sampler_state->createInfo.compareEnable)) { |
| LogError(device, "VUID-VkDescriptorImageInfo-mutableComparisonSamplers-04450", |
| "%s (portability error): sampler comparison not available.", func_name); |
| } |
| } |
| } |
| } |
| } |
| } |
| // Fall through |
| case VK_DESCRIPTOR_TYPE_SAMPLER: { |
| auto iter = dest_set->FindDescriptor(update->dstBinding, update->dstArrayElement); |
| for (uint32_t di = 0; di < update->descriptorCount && !iter.AtEnd(); ++di, ++iter) { |
| const auto &desc = *iter; |
| if (!desc.IsImmutableSampler()) { |
| if (!ValidateSampler(update->pImageInfo[di].sampler)) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-00325"; |
| std::stringstream error_str; |
| error_str << "Attempted write update to sampler descriptor with invalid sampler: " |
| << report_data->FormatHandle(update->pImageInfo[di].sampler) << "."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } else if (update->descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER && !push) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-02752"; |
| std::stringstream error_str; |
| error_str << "Attempted write update to an immutable sampler descriptor."; |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| break; |
| } |
| case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: |
| case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT: |
| case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: { |
| for (uint32_t di = 0; di < update->descriptorCount; ++di) { |
| auto image_view = update->pImageInfo[di].imageView; |
| auto image_layout = update->pImageInfo[di].imageLayout; |
| if (image_view) { |
| if (!ValidateImageUpdate(image_view, image_layout, update->descriptorType, func_name, error_code, error_msg)) { |
| std::stringstream error_str; |
| error_str << "Attempted write update to image descriptor failed due to: " << error_msg->c_str(); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| } |
| break; |
| } |
| case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: |
| case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: { |
| for (uint32_t di = 0; di < update->descriptorCount; ++di) { |
| auto buffer_view = update->pTexelBufferView[di]; |
| if (buffer_view) { |
| auto bv_state = Get<BUFFER_VIEW_STATE>(buffer_view); |
| if (!bv_state) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-02994"; |
| std::stringstream error_str; |
| error_str << "Attempted write update to texel buffer descriptor with invalid buffer view: " |
| << report_data->FormatHandle(buffer_view); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| auto buffer = bv_state->create_info.buffer; |
| auto buffer_state = Get<BUFFER_STATE>(buffer); |
| // Verify that buffer underlying the view hasn't been destroyed prematurely |
| if (!buffer_state) { |
| *error_code = "VUID-VkWriteDescriptorSet-descriptorType-02994"; |
| std::stringstream error_str; |
| error_str << "Attempted write update to texel buffer descriptor failed because underlying buffer (" |
| << report_data->FormatHandle(buffer) << ") has been destroyed: " << error_msg->c_str(); |
| *error_msg = error_str.str(); |
| return false; |
| } else if (!ValidateBufferUsage(report_data, buffer_state.get(), update->descriptorType, error_code, |
| error_msg)) { |
| std::stringstream error_str; |
| error_str << "Attempted write update to texel buffer descriptor failed due to: " << error_msg->c_str(); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| } |
| break; |
| } |
| case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: |
| case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: |
| case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: |
| case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: { |
| for (uint32_t di = 0; di < update->descriptorCount; ++di) { |
| if (update->pBufferInfo[di].buffer) { |
| if (!ValidateBufferUpdate(update->pBufferInfo + di, update->descriptorType, func_name, error_code, error_msg)) { |
| std::stringstream error_str; |
| error_str << "Attempted write update to buffer descriptor failed due to: " << error_msg->c_str(); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| } |
| break; |
| } |
| case VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT: |
| break; |
| case VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV: { |
| const auto *acc_info = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureNV>(update->pNext); |
| for (uint32_t di = 0; di < update->descriptorCount; ++di) { |
| auto as_state = Get<ACCELERATION_STRUCTURE_STATE>(acc_info->pAccelerationStructures[di]); |
| if (!ValidateAccelerationStructureUpdate(as_state.get(), func_name, error_code, error_msg)) { |
| std::stringstream error_str; |
| error_str << "Attempted write update to acceleration structure descriptor failed due to: " |
| << error_msg->c_str(); |
| *error_msg = error_str.str(); |
| return false; |
| } |
| } |
| |
| } break; |
| // KHR acceleration structures don't require memory to be bound manually to them. |
| case VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR: |
| break; |
| default: |
| assert(0); // We've already verified update type so should never get here |
| break; |
| } |
| // All checks passed so update contents are good |
| return true; |
| } |