commit 8040a7af8919a47346cfeaf1fbc2ebfe09cfea09
author Charles Giessen <charles@lunarg.com> Tue Nov 16 19:10:15 2021 -0700
committer Charles Giessen <charles@lunarg.com> Tue Nov 16 20:44:20 2021 -0700
tree c32cb6e6ea89f08766488da5b30c483d477cae9e
parent cc516dcb5e671b08603b89ab06fd398bb9f5a1d2

vulkaninfo: Make printing ToolProperties optional

This field has caused numerous crashes and has generally been more trouble than
its worth to have as a default output. Now, a new command line argument is
needed to get vulkaninfo to print tooling info.

vulkaninfo/vulkaninfo.cpp

diff --git a/vulkaninfo/vulkaninfo.cpp b/vulkaninfo/vulkaninfo.cpp
index d25cf1f..79acf5f 100644
--- a/vulkaninfo/vulkaninfo.cpp
+++ b/vulkaninfo/vulkaninfo.cpp
@@ -642,7 +642,7 @@
 }
 // Print gpu info for text, html, & vkconfig_output
 // Uses a seperate function than schema-json for clarity
-void DumpGpu(Printer &p, AppGpu &gpu, bool show_formats) {
+void DumpGpu(Printer &p, AppGpu &gpu, bool show_tooling_info, bool show_formats) {
     ObjectWrapper obj_gpu(p, "GPU" + std::to_string(gpu.id));
     IndentWrapper indent(p);
 
@@ -658,7 +658,9 @@
     }
     GpuDumpMemoryProps(p, gpu);
     GpuDumpFeatures(p, gpu);
-    GpuDumpToolingInfo(p, gpu);
+    if (show_tooling_info) {
+        GpuDumpToolingInfo(p, gpu);
+    }
 
     if (p.Type() != OutputType::text || show_formats) {
         GpuDevDump(p, gpu);
@@ -831,6 +833,7 @@
     std::cout << "                    Subset Schema for the GPU specified to standard output,\n";
     std::cout << "                    where N is the GPU desired.\n";
 #endif  // defined(VK_ENABLE_BETA_EXTENSIONS)
+    std::cout << "--show-tool-props   Show the active VkPhysicalDeviceToolPropertiesEXT that vulkaninfo finds.\n";
     std::cout << "--show-formats      Display the format properties of each physical device.\n";
     std::cout << "                    Note: This option does not affect html or json output;\n";
     std::cout << "                    they will always print format properties.\n\n";
@@ -854,6 +857,7 @@
 #endif
 
     uint32_t selected_gpu = 0;
+    bool show_tool_props = false;
     bool show_formats = false;
     char *output_path = nullptr;
 
@@ -887,6 +891,8 @@
         } else if (strcmp(argv[i], "--html") == 0) {
             human_readable_output = false;
             html_output = true;
+        } else if (strcmp(argv[i], "--show-tool-props") == 0) {
+            show_tool_props = true;
         } else if (strcmp(argv[i], "--show-formats") == 0) {
             show_formats = true;
         } else if (strcmp(argv[i], "--help") == 0 || strcmp(argv[i], "-h") == 0) {
@@ -1047,7 +1053,7 @@
                 IndentWrapper indent(*p);
 
                 for (auto &gpu : gpus) {
-                    DumpGpu(*p.get(), *gpu.get(), show_formats);
+                    DumpGpu(*p.get(), *gpu.get(), show_tool_props, show_formats);
                 }
             }
         }