commit ce2f0cff74c384f56457b1959fac40e9bab1b16a
author Oliver Newman <olivernewman@google.com> Tue Sep 12 14:59:08 2023 +0000
committer CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Sep 12 14:59:08 2023 +0000
tree dc618064e51da1928f944f8ccccf044b48b2c4de
parent 1dc5220eeb6d56e64d4dbb69bfb69fb67b35e004

[go] Remove network access for Go checks

It's no longer necessary now that all dependencies are vendored.

Change-Id: I2651a90c408bfb26a0314b71afd1b7172e77bbf3
Reviewed-on: https://fuchsia-review.googlesource.com/c/shac-project/shac/+/915352
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Reviewed-by: Marc-Antoine Ruel <maruel@google.com>
Fuchsia-Auto-Submit: Oliver Newman <olivernewman@google.com>

checks/go.star

diff --git a/checks/go.star b/checks/go.star
index 61bca47..517bf01 100644
--- a/checks/go.star
+++ b/checks/go.star
@@ -128,9 +128,6 @@
         [exe, "-f=json", "./..."],
         ok_retcodes = [0, 1],
         env = env,
-        # TODO(olivernewman): Figure out why staticcheck needs network access and
-        # remove. We may need to make sure to `go get` all dependencies first?
-        allow_network = True,
     ).wait()
 
     # Output is JSON-lines.
@@ -176,7 +173,6 @@
             "./...",
         ],
         env = go_env(ctx, "shadow"),
-        allow_network = True,
     ).wait()
 
     # Example output: