commit | a2a79ebaaf6e8854b13aee32e8cfdc3e2da46669 | [log] [tgz] |
---|---|---|
author | Oliver Newman <olivernewman@google.com> | Wed Jun 28 16:53:36 2023 +0000 |
committer | CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jun 28 16:53:36 2023 +0000 |
tree | 1233ccb6d38c7adc606eda232fedb33961d7360c | |
parent | 9c420bb0f059d97d06efe1f0be52a7ac80d4947d [diff] |
[engine] Don't ignore end_col if end_line is unset If `end_col` is specified but `end_line` is not, we would previously ignore `end_col` entirely and consider the finding to apply to the end of the line. Now we'll respect `end_col` in this case, and assume `end_line` should be equal to `start_line`. Change-Id: I57b42fd4ca9ae26f9bd72ba87b8d0de56b3efcb0 Reviewed-on: https://fuchsia-review.googlesource.com/c/shac-project/shac/+/878433 Fuchsia-Auto-Submit: Oliver Newman <olivernewman@google.com> Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com> Reviewed-by: Marc-Antoine Ruel <maruel@google.com>
Shac (Scalable Hermetic Analysis and Checks) is a unified and ergonomic tool and framework for writing and running static analysis checks.
Shac checks are written in Starlark.
go install go.fuchsia.dev/shac-project/shac@latest shac check shac doc shac.star | less
⚠ The source of truth is at https://fuchsia.googlesource.com/shac-project/shac.git and uses Gerrit for code review.
See CONTRIBUTING.md to submit changes.