| commit | 9ced7f43a1afa765231b60c02dc4a3b57cc316d0 | [log] [tgz] |
|---|---|---|
| author | Oliver Newman <olivernewman@google.com> | Mon Jul 17 19:02:10 2023 +0000 |
| committer | CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jul 17 19:02:10 2023 +0000 |
| tree | ffb58a166f8f41b6c7e2c4df961267c63f7139b1 | |
| parent | f95cfe35e75e74ec5c69f1c28cdbb0c13630992b [diff] |
[scm] Fix caching bug
Previously, the cached result of the `ctx.scm.{all,affected}_files()`
functions for git repos would be affected by whether `include_affected`
was set the first time the function was called, so subsequent calls
would always return the same result regardless of their
`include_affected` value.
Change-Id: I466080f7455fb1c11a413ac44ac7d41bc42d78bf
Reviewed-on: https://fuchsia-review.googlesource.com/c/shac-project/shac/+/885393
Reviewed-by: Marc-Antoine Ruel <maruel@google.com>
Commit-Queue: Oliver Newman <olivernewman@google.com>
Fuchsia-Auto-Submit: Oliver Newman <olivernewman@google.com>
Shac (Scalable Hermetic Analysis and Checks) is a unified and ergonomic tool and framework for writing and running static analysis checks.
Shac checks are written in Starlark.
go install go.fuchsia.dev/shac-project/shac@latest shac check shac doc shac.star | less
Planned features/changes, in descending order by priority:
shac.textprotoshac.star files.shac cache directory that checks can write toctx.scmglob arguments to ctx.scm.{all,affected}_files() functions for easier filtering⚠ The source of truth is at https://fuchsia.googlesource.com/shac-project/shac.git and uses Gerrit for code review.
See CONTRIBUTING.md to submit changes.