tree 0b7391b8e2d7cd097f87a4adf63b76e74dcca7bf
parent e1684102bf173f61cef146dbc5c1d8b88e0d99a5
author Oliver Newman <olivernewman@google.com> 1692392734 +0000
committer CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> 1692392734 +0000

[engine] Prohibit forking without locking

Calling the `os/exec.Cmd` functions `Run()` or `Start()` without locking
the R/W mutex used to write the nsjail executable causes test flakiness;
see docstring of the command package for more details.

So extract a library that forks safely, and add a check that no unsafe
forks are done.

Change-Id: I926654d38f66fb614e39db5a7d9c3e1e43ebeb4a
Reviewed-on: https://fuchsia-review.googlesource.com/c/shac-project/shac/+/904660
Fuchsia-Auto-Submit: Oliver Newman <olivernewman@google.com>
Commit-Queue: Oliver Newman <olivernewman@google.com>
Reviewed-by: Marc-Antoine Ruel <maruel@google.com>