Google Git
Sign in
fuchsia / shac-project / shac / 5173251d2d06518fe01cd0a99cff70261e41053c
commit5173251d2d06518fe01cd0a99cff70261e41053c[log] [tgz]
authorOliver Newman <olivernewman@google.com>Fri Aug 18 14:44:33 2023 +0000
committerCQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Aug 18 14:44:33 2023 +0000
tree4826a1d5130bc1942c0e22908670562e39cb280b
parentab2e3b48079abef1b68dc1b95f22cf3e4db5e611 [diff]
[engine] Fix tests under go1.21

In go1.21, `go run` prints a warning if `GOROOT` and `GOPATH` are equal,
even if they're both empty:

  warning: GOPATH set to GOROOT () has no effect

This breaks tests that assume `go run` won't print anything besides the
output of the Go file being run. To fix that, explicitly set the
`GOPATH` env var.

Change-Id: I9796a93802db5a20159beecebe16da23bee3aa8d
Reviewed-on: https://fuchsia-review.googlesource.com/c/shac-project/shac/+/904658
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Reviewed-by: Mahesh Saripalli <maheshsr@google.com>
Fuchsia-Auto-Submit: Oliver Newman <olivernewman@google.com>
2 files changed
tree: 4826a1d5130bc1942c0e22908670562e39cb280b
  1. .github/
  2. checks/
  3. doc/
  4. images/
  5. internal/
  6. scripts/
  7. vendor/
  8. .gitignore
  9. AUTHORS
  10. codecov.yml
  11. CONTRIBUTING.md
  12. go.mod
  13. go.sum
  14. LICENSE
  15. main.go
  16. OWNERS
  17. PATENTS
  18. README.md
  19. shac.star
  20. shac.textproto
README.md

shac

Shac (Scalable Hermetic Analysis and Checks) is a unified and ergonomic tool and framework for writing and running static analysis checks.

Shac checks are written in Starlark.

usage demonstration

Usage

go install go.fuchsia.dev/shac-project/shac@latest
shac check
shac doc shac.star | less

Documentation

Road map

Planned features/changes, in descending order by priority:

  • [x] Configuring files to exclude from shac analysis in shac.textproto
  • [x] Include unstaged files in analysis, including respecting unstaged shac.star files
  • [x] Automatic fix application with handling for conflicting suggestions
  • [ ] Provide a .shac cache directory that checks can write to
  • [ ] Mount checkout directory read-only
    • [x] By default
    • [ ] Unconditionally
  • [ ] Give checks access to the commit message via ctx.scm
  • [ ] Built-in formatting of Starlark files
  • [ ] Configurable “pass-throughs” - non-default environment variables and mounts that can optionally be passed through to the sandbox
  • [ ] Add glob arguments to ctx.scm.{all,affected}_files() functions for easier filtering
  • [ ] Filesystem sandboxing on MacOS
  • [ ] Windows sandboxing
  • [ ] Testing framework for checks

Contributing

⚠ The source of truth is at https://fuchsia.googlesource.com/shac-project/shac.git and uses Gerrit for code review.

See CONTRIBUTING.md to submit changes.