tree ba2af2b80f4396503e781d677c4efde44d899980
parent 62acf29a492b8cf23136a3deb549843acd56bb58
author Oliver Newman <olivernewman@google.com> 1695844564 +0000
committer CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> 1695844564 +0000

[engine] Fix gosec

The gosec check was previously failing silently (producing a retcode of
zero) because it was run in a sandbox without the necessary environment
variables set (specifically `GOPACKAGESDRIVER=off` needed to be set for
it to work inside the sandbox).

After fixing the check there were a bunch of fixes required, mostly
related to error propagation.

Change-Id: Ib6ff1ae370d3e07fb9c63cb2bfddf907a526955f
Reviewed-on: https://fuchsia-review.googlesource.com/c/shac-project/shac/+/922774
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Fuchsia-Auto-Submit: Oliver Newman <olivernewman@google.com>
Reviewed-by: Anthony Fandrianto <atyfto@google.com>