)]}' { "log": [ { "commit": "d4a547c1905d0dc097a761100cc3f1b9a1bd01ec", "tree": "923caa145076094e689c49716f77fa2d79120af5", "parents": [ "d543f39915a9bf9671d61bd0799fa868228c021f" ], "author": { "name": "Renato Mangini Dias", "email": "mangini@google.com", "time": "Thu Aug 20 18:11:56 2020 +0000" }, "committer": { "name": "Mahesh Saripalli", "email": "maheshsr@google.com", "time": "Thu Aug 20 18:11:56 2020 +0000" }, "message": "Deprecate obsolete repository\n\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nChange-Id: Ifd2be70c67be5506dc28898d2dc2296b9957cf12\nReviewed-on: https://fuchsia-review.googlesource.com/c/peridot/+/418717\nCommit-Queue: Renato Mangini Dias \u003cmangini@google.com\u003e\nReviewed-by: Mahesh Saripalli \u003cmaheshsr@google.com\u003e\nAPI-Review: Dale Sather \u003cdalesat@google.com\u003e\n" }, { "commit": "d543f39915a9bf9671d61bd0799fa868228c021f", "tree": "c7e280a3a52223b618d0b9b5b176896769781cc7", "parents": [ "5160e3425f425d1a637b9995f89eaba4be8e8cb1" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Wed Jan 16 23:56:46 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 31 22:24:59 2019 +0000" }, "message": "[modular][storymodel] Un-flake ledger_story_model_storage_unittest.\n\nThe old test was flaky because it depended on the Ledger notifying the\nStoryModelStorage of changes to establish what would be the expected\nvalue of a later read from the Ledger, but it did not wait on a\ncondition that guaranteed the Ledger had notified it. This created a\nrace (against TIME!).\n\nTEST\u003dledger_story_model_storage_unittest\n\nMF-165 #done [modular][storymodel] Un-flake ledger_story_model_storage_unittest.\nMF-165 #comment\n\nChange-Id: I0d515609374922692caf2fc46491e52d7354a158\n" }, { "commit": "5160e3425f425d1a637b9995f89eaba4be8e8cb1", "tree": "605789ad8115aec26779c8501f7aeedac4450615", "parents": [ "d6d1e69a11e572d42724978a012b281f2dfeb579" ], "author": { "name": "Leo Lung", "email": "leolung@google.com", "time": "Wed Jan 30 22:12:04 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 31 19:27:40 2019 +0000" }, "message": "[fuchsia-pkg] remove deprecated_bare_package_url\n\nfind . -name \"*\" -type f | xargs sed -i -e \u0027/deprecated_bare_package_url \u003d \"\\/\\/build\"/d\u0027\n\nCF-156\n\nTESTED\u003dcq\n\nChange-Id: I786f79811574936f95d00cda99ca0b3d5283f3e1\n" }, { "commit": "d6d1e69a11e572d42724978a012b281f2dfeb579", "tree": "33c124d9695b244d1929ce8b9de90c085818e480", "parents": [ "7e97a40482fe04c6a22c2cc639df80f9638edc7d" ], "author": { "name": "Maria Glukhova", "email": "mariagl@google.com", "time": "Thu Jan 31 16:35:33 2019 +0100" }, "committer": { "name": "Maria Glukhova", "email": "mariagl@google.com", "time": "Thu Jan 31 16:56:42 2019 +0100" }, "message": "[ledger] Add LegacySocketProvider to the sandbox.\n\nTESTED\u003dSync benchmarks\nLE-681 #done\n\nChange-Id: Idfafe7b43e6f7ca24cd5f510fef4ddb0bad22e43\n" }, { "commit": "7e97a40482fe04c6a22c2cc639df80f9638edc7d", "tree": "0cbccb42916055303a02d3c27b9c9b20a45e5583", "parents": [ "be928189c604a42f9d7df74f4b6f0ffff6bb857c" ], "author": { "name": "Maria Glukhova", "email": "mariagl@google.com", "time": "Fri Jan 25 20:04:23 2019 +0100" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Wed Jan 30 18:03:29 2019 +0000" }, "message": "[benchmarks] Bring number of page requests in add_new_page back to 500.\n\nNow that LE-425 is closed, we can run this benchmark with a bigger\nammount of requests.\n\nNote: that will create some friction on the dashboard as the name of the\nmeasurement will change from get_page_samples_1_to_49 to\nget_page_samples_1_to_499.\n\nTEST\u003dOn CQ (peridot-x64-perf-dawson_canyon)\n\nChange-Id: I0d49d70ac8d842939248e841e77893963b2a8062\n" }, { "commit": "be928189c604a42f9d7df74f4b6f0ffff6bb857c", "tree": "4280dc277c0090f1cc7adf715add69708beca53b", "parents": [ "360197ef88331c89450d83927ba574cdea8afe13" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Wed Jan 16 23:54:54 2019 -0800" }, "committer": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Tue Jan 29 15:59:33 2019 -0800" }, "message": "[modular][page_client] Allow implementations of PageClient to overload Page.OnChange() directly.\n\nAlso:\n* Update outdated class comments and documentation.\n\nTEST\u003dno functional changes\n\nMF-165 #comment [modular][page_client] Allow implementations of PageClient to overload Page.OnChange() directly.\n\nChange-Id: I59efe20164b976fabb79dd0c1c0daab277c32fb0\n" }, { "commit": "360197ef88331c89450d83927ba574cdea8afe13", "tree": "a8136c92a1b7c1623e0d9eaaf5b0225d6af591b0", "parents": [ "345ccb2d1ebb501df418c3619d1c9790b5f3379d" ], "author": { "name": "Vardhan Mudunuru", "email": "vardhan@google.com", "time": "Thu Jan 24 14:59:37 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Jan 29 06:34:54 2019 +0000" }, "message": "[modular] module_package_indexer now uses real fuchsia-pkg:// URLs.\n\nSee https://fuchsia-review.googlesource.com/c/scripts/+/246495 for\nrelated change.\n\nCF-491 #done\n\nTest\u003dmanual\n\nChange-Id: I6f60eb590342ba18bf14ff5ec13400ece3aa2775\n" }, { "commit": "345ccb2d1ebb501df418c3619d1c9790b5f3379d", "tree": "c794ad8aa7f09a3a890f10daabd2b7e0f77929b7", "parents": [ "850f3b4390d24524b4d6e88063004475d0677d5a" ], "author": { "name": "Maria Glukhova", "email": "mariagl@google.com", "time": "Wed Nov 14 16:47:58 2018 +0100" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Mon Jan 28 18:12:33 2019 +0000" }, "message": "[ledger] Allow getting a part of the object as VMO.\n\nTEST\u003dPageStorageTest\n\nLE-239 #comment the mapping part is done, still need partial download.\n\nChange-Id: I93c5679b864b8da1cd582257177da17d7eccef73\n" }, { "commit": "850f3b4390d24524b4d6e88063004475d0677d5a", "tree": "29d3a23ade9ed112232d54a53fd8923eb1f10bef", "parents": [ "a751f51d4038de30f71e1cf2aba685a44e8524a0" ], "author": { "name": "Nelly Vouzoukidou", "email": "nellyv@google.com", "time": "Fri Jan 25 23:26:33 2019 +0100" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Mon Jan 28 09:40:55 2019 +0000" }, "message": "[ledger] Update documentation on directory organization.\n\nTest: Nothing, only documentation is updated.\nChange-Id: I01c47eb3764d6c31cf59a3e3f69956216b57c95f\n" }, { "commit": "a751f51d4038de30f71e1cf2aba685a44e8524a0", "tree": "a0f6f2845945b28f92a59d69f8ba9610a9f45ff0", "parents": [ "870147c29cf020c6132a470fc424231f976b0a44" ], "author": { "name": "Vickie Cheng", "email": "vickiecheng@google.com", "time": "Fri Jan 25 15:19:40 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Sat Jan 26 03:53:17 2019 +0000" }, "message": "[sessionctl] Allow mod short name for add_mod\n\nThis allows users to continue specifying a mod\u0027s package name and has\nsessionctl resolve it to a full package path. Users will still be able\nto specify a full package url:\n\nfx shell sessionctl add_mod slider_mod\nfx shell sessionctl add_mod fuchsia-pkg://fuchsia.com/slider_mod#meta/slider_mod.cmx\n\nTEST\u003dsessionctl_unittests\nMF-180 #done\n\nChange-Id: I6d8551f3467deef3d63674e6b27d11bce69121ef\n" }, { "commit": "870147c29cf020c6132a470fc424231f976b0a44", "tree": "f0333d493d6753de1e00157b2d99ab31e8bf035c", "parents": [ "0a1c2d40d92cc8abe219d9185c193c89d9da2901" ], "author": { "name": "Tamir Duberstein", "email": "tamird@gmail.com", "time": "Fri Jan 25 16:39:49 2019 -0500" }, "committer": { "name": "Tamir Duberstein", "email": "tamird@gmail.com", "time": "Fri Jan 25 16:39:49 2019 -0500" }, "message": "[all] remove dependency on LegacySocketProvider\n\nIt appears to be unused.\n\nTest: CQ\nChange-Id: I781a96c875ee1ad1e6762295d52cb353d56cc82e\n" }, { "commit": "0a1c2d40d92cc8abe219d9185c193c89d9da2901", "tree": "d79a3adfa0bbcf6c4d577160eb723fc94441a283", "parents": [ "a88814c90f73065033e79330b0ac83cbcf530809" ], "author": { "name": "Alex Min", "email": "alexmin@google.com", "time": "Thu Jan 24 22:53:37 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 25 18:23:52 2019 +0000" }, "message": "[components] Don\u0027t use bare package URLs.\n\n- Just remove the build flag, all usages of sessionmgr,\ndev_session_shell, and suggestion_engine are in fuchsia pkg URL format\nalready\n\nCF-335 #done\nCF-311 #done\n\nTESTED: CQ\nChange-Id: Ie144d54fd73e5d1f2aa83b6cb9e071180754e1f0\n" }, { "commit": "a88814c90f73065033e79330b0ac83cbcf530809", "tree": "ff62dc36a5c575dc30f9cfee39710b57ecb5cf5e", "parents": [ "07b52069e2878c703b1c23de5412c9ac3837867d" ], "author": { "name": "Miguel Flores Ruiz de Eguino", "email": "miguelfrde@google.com", "time": "Thu Jan 24 16:58:33 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 25 17:44:03 2019 +0000" }, "message": "[pkg-url-deprecation] Full url for usage_log\n\nCF-468 #comment Full url for usage_log in intelligence provider\n\nTESTED\u003dbuild\n\nChange-Id: I2df1654fb5cda152de100d8d8f44b50a596971bf\n" }, { "commit": "07b52069e2878c703b1c23de5412c9ac3837867d", "tree": "ca33e6a3bf97cffe851a140c305f0e14c102a3ee", "parents": [ "7421ede9c651cbe7fb9e832a4bf9f4d3c502b80e" ], "author": { "name": "Maria Glukhova", "email": "mariagl@google.com", "time": "Fri Jan 25 16:55:52 2019 +0100" }, "committer": { "name": "Maria Glukhova", "email": "mariagl@google.com", "time": "Fri Jan 25 17:20:22 2019 +0100" }, "message": "[benchmarks] Package name deprecation\n\nAll our workflows seem to already use \"fuchsia-pkg:\".\n\nTEST\u003dOn CQ (peridot-x64-perf-dawson_canyon), + launched some benchmarks\nmanually using instructions from bin/ledger/benchmark/README.md.\n\nLE-670 #done\n\nChange-Id: I3e2d5467cba4d75aeef87ffa0e8f9b26e36def37\n" }, { "commit": "7421ede9c651cbe7fb9e832a4bf9f4d3c502b80e", "tree": "aabb88434f989f741f9b215527104707bbf34707", "parents": [ "0d2e72e6c7d0f252ee17604b4df102cd35d8291e" ], "author": { "name": "Alex Min", "email": "alexmin@google.com", "time": "Thu Jan 24 14:32:37 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 25 03:52:13 2019 +0000" }, "message": "[components] Don\u0027t use bare package URLs.\n\nCF-473 #done\nCF-409 #done\nCF-347 #done\nCF-302 #done\n\nTESTED: CQ, manual testing of all shells\nChange-Id: I3c507c781a0d72999601eab637d927b9441407de\n" }, { "commit": "0d2e72e6c7d0f252ee17604b4df102cd35d8291e", "tree": "1ca9744599be0500510e86b99e72c31f54df9958", "parents": [ "7034020b3021cae21429f171e69ab48d71a098c5" ], "author": { "name": "Steffen Meschkat", "email": "mesch@google.com", "time": "Thu Jan 24 13:34:10 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 25 01:23:48 2019 +0000" }, "message": "[sessionmgr] Properly employ deferred_action.\n\ndeferred_action is meant to defer an action until the end of some\nscope, but we use it merely to defer it to some time later, but\ndecidedly not to the time of destruction, at which time it must\nnot execute at all if it hasn\u0027t yet.\n\nSo we use a simple fit::function\u003c\u003e instead that we simply protect\nagainst double invocation using a mutable bool flag on the capture\nlist. This is especially simple because the capture list already\nis mutable.\n\nAmends https://fuchsia-review.googlesource.com/c/peridot/+/240436\n\nTESTED\u003d/pkgfs/packages/modular_tests/0/test/run_modular_tests.sh\n\nChange-Id: I8851a349bbd4c55312fc59c443f74f98145bd2ea\n" }, { "commit": "7034020b3021cae21429f171e69ab48d71a098c5", "tree": "8ca579493e9717e170b49aa31d79545cfb8d1700", "parents": [ "a44072668a1dc36dc324616a69384a6b36abb4a9" ], "author": { "name": "Etienne J. Membrives", "email": "etiennej@google.com", "time": "Wed Jan 23 10:55:42 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 25 00:39:31 2019 +0000" }, "message": "[ledger] Document sending multiple times the same key in Merge\n\nBUG\u003dLE-653 #done\nTESTED\u003dDocumentation change only\n\nChange-Id: I2505f34dde047da3eb663df0049b0d9df64e7a4d\n" }, { "commit": "a44072668a1dc36dc324616a69384a6b36abb4a9", "tree": "e861821c4b9c06f518b2532297a74bc528b013a9", "parents": [ "4cda34f4aed29b82460cf7c6d23c39ebef392894" ], "author": { "name": "Dale Sather", "email": "dalesat@google.com", "time": "Wed Jan 23 15:31:33 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 25 00:25:41 2019 +0000" }, "message": "[mdns] mdns_util has been renamed mdns-util\n\nThis CL changes the packages reference to mdns_util so it now\nreferences mdns-util.\n\nTEST: no behavior change, build verified\n\nNET-2062 #comment\n\nChange-Id: Ib24827592a463ef356ab41276d1f93a93126b8a4\n" }, { "commit": "4cda34f4aed29b82460cf7c6d23c39ebef392894", "tree": "a58c1ab8423194ac289f6e70ed85c7bab78a8e33", "parents": [ "a99373105637e1d0b17ecda009f080be35b58fbd" ], "author": { "name": "Alex Min", "email": "alexmin@google.com", "time": "Thu Jan 24 14:05:15 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 24 23:18:18 2019 +0000" }, "message": "[sessionmgr] Fix sessionmgr crash that happens on agent runner teardown\n\n- Sessionmgr crashes in debug builds when printing |message| because\nit is corrupted in AgentRunner::Teardown\n\n- Corruption happens because |termination_callback_| execution destroys\nAgentRunner along with the captures (the |message|)\n\n- This fix is an alternative to 246372, it avoids putting the termination\ncallback on heap.\n\nMF-163 #done\nMF-171 #done\n\nTESTED: run_modular_tests\nChange-Id: Iab2acc84679f1d5ddd1a0b924d9fb2a319c1aebe\n" }, { "commit": "a99373105637e1d0b17ecda009f080be35b58fbd", "tree": "9f81a5134a8bfc220888aded85c8149d8e106afe", "parents": [ "4c31a98af9891823d226c219d034a8422d17b2cc" ], "author": { "name": "Vickie Cheng", "email": "vickiecheng@google.com", "time": "Thu Jan 17 17:41:23 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 24 22:30:57 2019 +0000" }, "message": "[sessionctl] Enable logging in a guest user.\n\nThis allows users to log in a guest user by running\nfx shell sessionctl login_guest\n\nTEST\u003dmanual: fx shell sessionctl login_guest\nMF-172 #comment Enable logging in a guest user.\n\nChange-Id: I9923a8638b6e821b97e1f0a2dd8196679b7b1d38\n" }, { "commit": "4c31a98af9891823d226c219d034a8422d17b2cc", "tree": "38a227d45fd7cda31ee768fd14e87378527f639a", "parents": [ "3202e197bf4477772a4391d91fbe72208b194ded" ], "author": { "name": "Vardhan Mudunuru", "email": "vardhan@google.com", "time": "Wed Jan 23 17:06:20 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 24 05:47:33 2019 +0000" }, "message": "[modular] Fix \u0026 renable flaky tests embed_shell and story_shell\n\nThere is a race condition between the story shell getting a ViewOwner\nfor the module, and the module dropping the ViewOwner on the floor\n(because its a test module which doesn\u0027t care to draw things on the\nscreen). The issue happens when the latter happens first, and the\nViewOwner that the story shell receives is invalid, which causes the\nFIDL call to fail (since the FIDL interface requires it to be valid).\n\nFixes in this patch:\n* Hold onto ViewProvider in these test modules indefinitely so ViewOwner\nis not dropped on the floor\n* unrelated: fix FindAnchor() to use ModuleData::is_embedded, since the\nother signal is not accurate.\n\nAdditional cleanup:\n* Clearer names which would\u0027ve helped me follow code quicker\n(e.g., ProcessPendingStoryShellViews)\n* Fix code to follow fuchsia/google C++ style guide (e.g., data types declared\n in the class first).\n\nMF-178\nMF-174 #done\n\nTEST\u003dembed_shell and story_shell don\u0027t flake for me anymore.\n\nChange-Id: I42250accaf301c10ec66dbdb2df37515f55408a5\n" }, { "commit": "3202e197bf4477772a4391d91fbe72208b194ded", "tree": "586be6a5db4da12a0db34170acc8089f3fadad42", "parents": [ "877e4652e7d2c5e73baa75b699ca177704ac4184" ], "author": { "name": "Joshua Seaton", "email": "joshuaseaton@google.com", "time": "Wed Jan 23 15:28:47 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 24 01:54:59 2019 +0000" }, "message": "[test-env] Expose test environments to (hermetic_)tests_package\n\nNeeded so that callers can specify environments.\nSee bug for context.\n\nBug: IN-927 #comment\nTest: CQ\nChange-Id: Ic6d2bc62413b39099d7babc5d4f420eb3a67b05b\n" }, { "commit": "877e4652e7d2c5e73baa75b699ca177704ac4184", "tree": "3d6af25a21190061db4c5cf5a1d3e17129d340a2", "parents": [ "4da304f20cc3b5b1fbf39f44517c3ac02570ae97" ], "author": { "name": "Gary Miguel", "email": "garymm@google.com", "time": "Wed Jan 23 15:32:54 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 24 01:08:07 2019 +0000" }, "message": "[gn] Run gn format on many files.\n\nI\u0027m going to automatically edit these files in a subsequent commit and I\ndon\u0027t want the formatting change to be mixed up with the functional\nchange.\n\nBug: IN-927 #comment\nTest: CQ\nChange-Id: Ibf619d3a419de08d1d31064e9fd2fdcca3e557f3\n" }, { "commit": "4da304f20cc3b5b1fbf39f44517c3ac02570ae97", "tree": "78ca5abf30c08bfe90a29216dfc7cf923f2aa7f9", "parents": [ "9fb46572babe466b0f7942f9d4fdf75219165709" ], "author": { "name": "Steffen Meschkat", "email": "mesch@google.com", "time": "Tue Jan 22 15:30:25 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 24 00:21:17 2019 +0000" }, "message": "[sessionmgr] Cleanup while reading the code.\n\nRearrange the construction of the service namespace passed to the\nsession shell such that the registration of the connection factory\nand the declaration of the service name are adjacent for each\nservice in the service namespace.\n\nUse type inference for the factory function |request| arguments,\nas they are determined by the type parameter of the AddService\u003c\u003e\ninvocation.\n\nTESTED\u003d/pkgfs/packages/modular_tests/0/test/run_modular_tests.sh\n\nChange-Id: I357284e6df33b0e81aa956b43bad2b03a7ed80a6\n" }, { "commit": "9fb46572babe466b0f7942f9d4fdf75219165709", "tree": "77569fb6ef89f5c58738a04741fc716bf8bbbf78", "parents": [ "6b5c1777dbacf6a78e8f84a845f4346a22f9129d" ], "author": { "name": "Nelly Vouzoukidou", "email": "nellyv@google.com", "time": "Wed Jan 23 11:28:38 2019 +0100" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Wed Jan 23 21:12:04 2019 +0000" }, "message": "[ledger][benchmarks] Don\u0027t shut down benchmark until all put operations have terminated.\n\nTest: put benchmarks\n\nIt is possible that the watcher notifications are received before the\ncallback of Put is called. E.g. this happened during CL /244232. After\nthis CL we are waiting on both watcher notifications and put callbacks\nto terminate before shuting down.\n\nChange-Id: I7866d31de4c95c5e4c2acb0511a3356f5e96845b\n" }, { "commit": "6b5c1777dbacf6a78e8f84a845f4346a22f9129d", "tree": "754041eb268b2afce78581a414b956ae674a40ec", "parents": [ "a4dca1268eff2fc7560df64d4de46001ed61196e" ], "author": { "name": "Ambre Williams", "email": "ambre@google.com", "time": "Mon Jan 21 16:01:39 2019 +0100" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Wed Jan 23 13:31:00 2019 +0000" }, "message": "[ledger] Clean up state of PageManagerContainer\n\nFix a potential null pointer dereference in PageManagerContainer and add\ncomments documenting the different possible states.\n\nTEST\u003dledger_tests\n\nChange-Id: I43f12a0aead1225a524037702d20e5e78291ce77\n" }, { "commit": "a4dca1268eff2fc7560df64d4de46001ed61196e", "tree": "f4000ef74c8010aac6fc1364c48df86cc1c9a1f2", "parents": [ "38a8f114ce09a359104934434060c815ffc818f1" ], "author": { "name": "Kishore Kumar", "email": "kishorekumar@huawei.com", "time": "Thu Jan 10 10:25:22 2019 +0530" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Wed Jan 23 09:36:45 2019 +0000" }, "message": "[basemgr] Update correct profile_id before saving user account\n\nBefore this CL, P2P sync failed due to mismatch in netconnector\nservice name created in P2P provider. Now P2P provider uses\naccount profile_id to create service name. In this CL, modified\nprofile_id field to assign unique value for the user.\n\nTESTED\u003dP2P sync between NUC and Acer devices is succesful\n\nChange-Id: Iacd3245aa845c6e2616ffd42f1c786f2cc30993f\n" }, { "commit": "38a8f114ce09a359104934434060c815ffc818f1", "tree": "5f08a4fc81916aa580a7715721976d975a4c2a87", "parents": [ "df1295399378bff0bfe748ff4e2df85c34dfdeff" ], "author": { "name": "Rich Kadel", "email": "richkadel@google.com", "time": "Tue Jan 22 20:27:10 2019 -0800" }, "committer": { "name": "Rich Kadel", "email": "richkadel@google.com", "time": "Tue Jan 22 22:48:42 2019 -0800" }, "message": "[peridot] [lib] [testing] Temporarily redefine Closure in test\n\nBefore we can restore changes in:\nhttps://fuchsia-review.googlesource.com/c/garnet/+/240405\nreverted by:\nhttps://fuchsia-review.googlesource.com/c/garnet/+/244317\n\nWe update fake_agent_runner_storage.h so it will build under\nboth pre-change and post-change.\n\nOnce the garnet change is restored, we will make remaining\nperidot change to align with the goals to remove\nfxl::MakeCopyable and replace many std::function references\nwith the new fit::function type.\n\nTest: No behavior change\nChange-Id: I683d1d9876f0d914cf8809eae69258e509aed653\n" }, { "commit": "df1295399378bff0bfe748ff4e2df85c34dfdeff", "tree": "77006502ce6cde3b111304fa9d3b702abead6302", "parents": [ "6a73fb4da69c48f0bd7b09e70221708b52e15f42" ], "author": { "name": "Vardhan Mudunuru", "email": "vardhan@google.com", "time": "Tue Jan 22 17:01:03 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Wed Jan 23 01:48:47 2019 +0000" }, "message": "[modular] Fix \u0026 renable flaky \u0027last_focus_time\u0027 test\n\nThis crash happens when the sessionmgr shutdown sequence races with a\ndifferent process (a session shell) requesting PuppetMaster access,\nwhich happened to already be destroyed.\n\nThe fix is to ignore puppet master requests if sessionmgr is\nin its termination sequence. Also in other places we vend services.\n\nMF-170 #done\n\nTest\u003dlast_focus_time passes successfully after 30x runs.\n\nChange-Id: I052bc1775c39d1372cd1ec30d4b5de19b954469e\n" }, { "commit": "6a73fb4da69c48f0bd7b09e70221708b52e15f42", "tree": "85bb1ffbf68fac6658f28da455a61e486be8d1d3", "parents": [ "e24ccc33bc006ec5ecd5848664e64df7a474bace" ], "author": { "name": "Usha Kode", "email": "ukode@google.com", "time": "Tue Jan 22 14:15:44 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Wed Jan 23 00:20:17 2019 +0000" }, "message": "[fuchsia-pkg] Remove deprecated_base_pkg_url for dev_token_manager build.\n\nThe package url is already updated in all the tests (tests/modular_tests.json, and\ntests/sessionctl) where this component is being used.\n\nTESTED \u003d Run existing modular integration tests using the following cmd:\n fx shell /pkgfs/packages/modular_tests/0/test/run_modular_tests.sh\n\nChange-Id: I38186d7660805c16632d34a5fc0e40c39d3cfd9e\n" }, { "commit": "e24ccc33bc006ec5ecd5848664e64df7a474bace", "tree": "19e0d632fd0969fd140426c4d1780fb9300446ab", "parents": [ "8e4b8804cba5284a018412b52fa37a2ae04639c6" ], "author": { "name": "Steffen Meschkat", "email": "mesch@google.com", "time": "Tue Jan 22 14:08:57 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Jan 22 23:35:26 2019 +0000" }, "message": "[components] Don\u0027t use bare package URLs.\n\nWe already don\u0027t use bare package URLs, but the package build rules\nstill request support for it. So we just adjust the test rules.\n\nHowever, we still used to use a bare package URL for context engine\nin its integration test, even though the intergration test component\nwas not flagged thus. Adjusting that too.\n\nCollateral cleanup:\n* const\n\nTESTED\u003d/pkgfs/packages/modular_tests/0/test/run_modular_tests.sh\n\nCF-478 #done\n\nChange-Id: I2d7adfc1cad4f239f7d895f82e7436112a9c6fc6\n" }, { "commit": "8e4b8804cba5284a018412b52fa37a2ae04639c6", "tree": "7aacb997c3634df6fcf489b85d71a45ade375e36", "parents": [ "8705a68680a29af9f86e7aae757a463e5fb5a4fe" ], "author": { "name": "Steffen Meschkat", "email": "mesch@google.com", "time": "Tue Jan 22 10:34:32 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Jan 22 21:52:11 2019 +0000" }, "message": "[components] Don\u0027t use bare package URLs.\n\nWe already don\u0027t use bare package URLs, but the package build rules\nstill request support for it. So we just adjust the test rules.\n\nPrevious changes where use of bare package URLs was already removed are:\n\nhttps://fuchsia-review.googlesource.com/c/peridot/+/232914\nhttps://fuchsia-review.googlesource.com/c/peridot/+/232374\n\nTESTED\u003d/pkgfs/packages/modular_tests/0/test/run_modular_tests.sh\n\nMI4-1717 #done\nMI4-1696 #done\nMI4-1667 #done\nMI4-1696 #done\nMI4-1664 #done\nMI4-1659 #done\nMI4-1643 #done\nMI4-1638 #done\nMI4-1629 #done\nMI4-1626 #done\nMI4-1617 #done\nMI4-1570 #done\nCF-339 #done\n\nChange-Id: I56b4df2c013f89cf18b13850451d1a367822fac1\n" }, { "commit": "8705a68680a29af9f86e7aae757a463e5fb5a4fe", "tree": "a683e99b71188b7e01ccee73d7600681bc809f45", "parents": [ "058f0f6c45d88bc2dce91ffcde61b0a22fb24c50" ], "author": { "name": "Przemyslaw Pietrzkiewicz", "email": "ppi@google.com", "time": "Tue Jan 22 15:06:56 2019 +0100" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Jan 22 17:04:28 2019 +0000" }, "message": "[fidl] add missing FIDL deps for fuchsia.modular.internal\n\nThose deps contain FIDL symbols referenced within fuchsia.modular.internal. Somehow the C++ build works despite the missing deps, but it triggers an error if referenced from Rust.\n\nLE-663\n\nTested: referenced from WIP Rust CL for Voila. Once the CL is landed it will prevent regressions.\nChange-Id: I8073448300e922328553b75f0b9af9a73d81acc2\n" }, { "commit": "058f0f6c45d88bc2dce91ffcde61b0a22fb24c50", "tree": "458ea981a1e416b41900e160f705d6b8d8019964", "parents": [ "01bbae70456d43beb4b098af7669b35191dfffa1" ], "author": { "name": "Maria Glukhova", "email": "mariagl@google.com", "time": "Thu Jan 10 19:03:06 2019 +0100" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Jan 22 11:32:37 2019 +0000" }, "message": "[ledger] In FetchPartial benchmark, only fetch one (but bigger) object.\n\nThis allows \"split_first\" to be actually useful, as we record the first\ncall to FetchPartial on an object separately from the rest.\n\nTEST\u003dtrace record\n--spec-file\u003d/pkgfs/packages/ledger_benchmarks/0/data/fetch_partial_big_entry.tspec\n\nChange-Id: Iac493d77f00515f7d01fd695917902153acfc450\n" }, { "commit": "01bbae70456d43beb4b098af7669b35191dfffa1", "tree": "66c057e8aa08868f3cd65e0eff70b572744360fb", "parents": [ "db1f2c66a52b27c512a93dc4edb726d12a9c46c7" ], "author": { "name": "Nelly Vouzoukidou", "email": "nellyv@google.com", "time": "Mon Jan 21 17:06:51 2019 +0100" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Jan 22 10:21:06 2019 +0000" }, "message": "[ledger][benchmarks] Randomize keys.\n\nKeys generated for the benchmarks had the index as a prefix, making\nthem partially sequential (e.g. 1, 10, 2, 3, 4, 5, 6, 7, 8, 9). After\nthis CL, keys will have the index as a suffix, forcing a random order\nin insertions/updates, while still allowing retrieving the keys\u0027 ids.\n\nNote that this change will likely change some of the results in the\ndashboard, because of the re-ordering of the keys.\n\nTest: All benchmarks are still running correctly.\nChange-Id: If88eeb556dbccf1a668d3af2040614d9b068d7b1\n" }, { "commit": "db1f2c66a52b27c512a93dc4edb726d12a9c46c7", "tree": "2ec93f42345ec5e45fe42d3064d72c525b0d2b6f", "parents": [ "fb2c782f24d0af2d06112a7c89566fda93667df1" ], "author": { "name": "Gabriel Kerneis", "email": "kerneis@google.com", "time": "Fri Jan 18 11:24:43 2019 +0100" }, "committer": { "name": "Przemysław Pietrzkiewicz", "email": "ppi@google.com", "time": "Mon Jan 21 12:30:30 2019 +0000" }, "message": "[ledger] Remove deprecated_bare_package_url from packages\n\nBug: LE-666 #done\nTested: ran all commands listed in docs/ledger/testing.md.\nChange-Id: Ib365e9ab5b339b8b1db0fb2054d1c7e5db1f547b\n" }, { "commit": "fb2c782f24d0af2d06112a7c89566fda93667df1", "tree": "b3977b6c05736ce4ebefb5a81d09da28ce0f78dc", "parents": [ "99f6c515448bbcc58dd145ef1fde32ce5902049c" ], "author": { "name": "Gabriel Kerneis", "email": "kerneis@google.com", "time": "Fri Jan 18 11:20:26 2019 +0100" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Mon Jan 21 11:52:29 2019 +0000" }, "message": "[ledger] Run all tests as components\n\nAlso fix Firestore cloud provider end-to-end tests and update testing\ndocumentation accordingly.\n\nBug: LE-604 #done\nTested: ran all commands listed in docs/ledger/testing.md.\nChange-Id: I9a244044001a78060b56beab51db9b5f730c7537\n" }, { "commit": "99f6c515448bbcc58dd145ef1fde32ce5902049c", "tree": "a68cc603e50c4ec571a3614266e26504d855e0e5", "parents": [ "97f70289dc2513e5d382732e8e32102f5d5c1194" ], "author": { "name": "Yegor Pomortsev", "email": "ypomortsev@google.com", "time": "Fri Jan 18 17:00:50 2019 -0800" }, "committer": { "name": "Yegor Pomortsev", "email": "ypomortsev@google.com", "time": "Fri Jan 18 17:04:40 2019 -0800" }, "message": "[modular tests] Remove deprecated_bare_package_url in module_context\n\nTest: run_integration_tests.sh module_context\n\nMI4-1659 #done\n\nChange-Id: I9a6ba3df714f8d576e1756a31fcb93aa124d5a2c\n" }, { "commit": "97f70289dc2513e5d382732e8e32102f5d5c1194", "tree": "73fe33635ed898daabc55bf2e51d3ae9bdd7bf6a", "parents": [ "68ce31d13ed97a5c8a2604160fb60acea7953dc5" ], "author": { "name": "David Worsham", "email": "dworsham@google.com", "time": "Fri Jan 18 23:02:22 2019 +0000" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 18 23:27:27 2019 +0000" }, "message": "Revert \"[scenic] Prepare session_shell for eventpairs\"\n\nThis reverts commit 8082f8cf181730dd33d68d74c388025d05b7e202.\n\nReason for revert: Landed out of order with v/g, so breaks flamingo\n\nOriginal change\u0027s description:\n\u003e [scenic] Prepare session_shell for eventpairs\n\u003e \n\u003e TEST: CQ\n\u003e SCN-897 #comment\n\u003e SCN-1018 #comment\n\u003e SCN-1033 #comment\n\u003e \n\u003e Change-Id: Ic2a6c432c5c534385a14d7e2e8fd7fe83b7c8eca\n\nTBR\u003dmikejurka@google.com,thatguy@google.com,jaeheon@google.com,dworsham@google.com\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nChange-Id: I81df5690149b53e79771e7a2da3104b94fa2ad34\n" }, { "commit": "68ce31d13ed97a5c8a2604160fb60acea7953dc5", "tree": "9308350c45f0d3c465ef884c56601d10e52414e7", "parents": [ "b033cee8add53dd538e602ca066815d55d052d43" ], "author": { "name": "Vardhan Mudunuru", "email": "vardhan@google.com", "time": "Fri Jan 18 14:12:58 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 18 22:53:30 2019 +0000" }, "message": "[modular] Disable flaky tests embed_shell and story_shell\n\nMF-174\n\nTest\u003dnone\n\nChange-Id: Ia4f9bcb0cc6a661b1aec3ae3f2a93bab81a2615d\n" }, { "commit": "b033cee8add53dd538e602ca066815d55d052d43", "tree": "2bdfb2e4f4db2e9c0b1e4b1b4658f4fecc9374a2", "parents": [ "cb747acff0653679b81f043df8bade08e73be876" ], "author": { "name": "Andrew Davies", "email": "awdavies@google.com", "time": "Wed Jan 16 17:45:37 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 18 06:17:56 2019 +0000" }, "message": "[test_driver_module] Removes nested env.\n\nThe nested env broke /hub visibility of the child processes. This will\nnow no longer be an issue for tests.\n\nDX-919 #done\nDX-710 #comment\n\nTEST: topaz integration tests.\nChange-Id: I6a83d63a4ac11161b6c778330e96453100e15654\n" }, { "commit": "cb747acff0653679b81f043df8bade08e73be876", "tree": "d3ed831b2e418f65d23dd167136dce6de8603862", "parents": [ "e02851c5cf2c5258ce47a0bc3713db1600ae6046" ], "author": { "name": "Vickie Cheng", "email": "vickiecheng@google.com", "time": "Wed Jan 16 15:26:19 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 17 23:29:44 2019 +0000" }, "message": "[sessionctl] Look for basemgr debug service in additional path for virtcon sessions\n\nTEST\u003dlaunched sessionctl in virtcon\nMF-169 #comment Look for basemgr debug service in additional path for virtcon sessions\n\nChange-Id: Icd1641aa716d66ceb56ecf03ef32ec7225771ee3\n" }, { "commit": "e02851c5cf2c5258ce47a0bc3713db1600ae6046", "tree": "2bcce63c0a04695b9e33b7f5e09a58e70eb5b1b5", "parents": [ "8082f8cf181730dd33d68d74c388025d05b7e202" ], "author": { "name": "Vardhan Mudunuru", "email": "vardhan@google.com", "time": "Mon Jan 07 15:55:15 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 17 21:52:36 2019 +0000" }, "message": "[modular] Don\u0027t auto-start embedded modules when story reinflates.\n\nAdditional clean up:\n* introduce a AddModParams struct for shuffling add-module parameters\nthrough to various places.\n* rename StoryController::StartModule -\u003e AddModuleToStory\n* AddMod story command will fail with an empty mod_name. multi-element\nmod_name splits into a mod_name and a parent mod.\n\nMF-164 #done\n\nTest\u003dExtend \u0027embed_shell\u0027 integration test to restart an existing story\nand see that an embedded module is not auto-started.\n\nChange-Id: I9652369750c61d87cc344455e56de6ded9ed3848\n" }, { "commit": "8082f8cf181730dd33d68d74c388025d05b7e202", "tree": "3fea34e7b8b5d7585dd9dfac687b721b57834cf8", "parents": [ "21cc6d7f7b03fae0a468ef12175f8541224d4dc5" ], "author": { "name": "David Worsham", "email": "dworsham@google.com", "time": "Fri Jan 11 15:35:50 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 17 21:45:46 2019 +0000" }, "message": "[scenic] Prepare session_shell for eventpairs\n\nTEST: CQ\nSCN-897 #comment\nSCN-1018 #comment\nSCN-1033 #comment\n\nChange-Id: Ic2a6c432c5c534385a14d7e2e8fd7fe83b7c8eca\n" }, { "commit": "21cc6d7f7b03fae0a468ef12175f8541224d4dc5", "tree": "ce53e6247a23853377e1bdcc7d1bbb2299392dae", "parents": [ "da389830f12e5a5cb32938d319e53bada1f20f43" ], "author": { "name": "Vardhan Mudunuru", "email": "vardhan@google.com", "time": "Thu Jan 17 12:40:38 2019 -0800" }, "committer": { "name": "Vardhan Mudunuru", "email": "vardhan@google.com", "time": "Thu Jan 17 20:49:42 2019 +0000" }, "message": "[modular] Disable flaky last_Focus_time integration test\n\nMF-170\n\nTest\u003dnone\n\nChange-Id: I6d52c3760866b99ab6279504a838c624cc1a6751\n" }, { "commit": "da389830f12e5a5cb32938d319e53bada1f20f43", "tree": "83a7b03511dd58b639766844ee0a8b47ffdd0447", "parents": [ "9941c87ec87f0af0c52d15dcbe9f2afabfbdc504" ], "author": { "name": "Vickie Cheng", "email": "vickiecheng@google.com", "time": "Fri Jan 04 13:33:18 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 17 18:56:50 2019 +0000" }, "message": "[sessionctl] Integration test to ensure sessionctl is able to launch\n\nTEST\u003dfx run-test sessionctl_integration_tests\nMF-139 #comment Integration test to ensure sessionctl is able to launch\n\nChange-Id: I37b29ee30307fbea06fae8fde256a2f75d787990\n" }, { "commit": "9941c87ec87f0af0c52d15dcbe9f2afabfbdc504", "tree": "de400c532d8f671b1daf4b54a536fbfd578ad007", "parents": [ "9c1eb78c914753f9f6aa3fe5f2675a89c9f34f1c" ], "author": { "name": "Andrew Wilson", "email": "apwilson@google.com", "time": "Fri Jan 11 14:34:04 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Wed Jan 16 20:35:21 2019 +0000" }, "message": "[sessionmgr] Delay initializing services until a SessionShell comes up and connects.\n\nCurrently when the sessionmgr starts it initializes all the services the\nsession shell needs before it launches the session shell. This causes a\nsignificant delay to the session shell starting as we need to launch\nnumerous components before it gets to session shell.\n\nThis change makes session shell start before any other services and the\nother services are started upon session shell first asking for them.\n\nTest: Logged in and gathered metrics with traceutil to see the order of things being launched.\n\nChange-Id: I42a654b874cbc910957eba5975e6befc28b68d03\n" }, { "commit": "9c1eb78c914753f9f6aa3fe5f2675a89c9f34f1c", "tree": "0dc02b39e029f6d9038b7e72b5cc356b490fe115", "parents": [ "b6c9e5d3e6189b69eb3940307e36009d9a117476" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Tue Jan 15 14:39:27 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Wed Jan 16 19:29:54 2019 +0000" }, "message": "[modular][manifests] Remove some log spam when no manifest is found.\n\nTEST\u003dnone\n\nChange-Id: I986324d517c9e2aece210bebdcbccefeda39b5ab\n" }, { "commit": "b6c9e5d3e6189b69eb3940307e36009d9a117476", "tree": "07151d8cc91b8275435f27ecf8ef1d158f65e856", "parents": [ "a5c817d4e2f0f21b68a7974fce0e822d369d2cbe" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Tue Jan 15 16:01:32 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Wed Jan 16 00:48:44 2019 +0000" }, "message": "[modular] Disable flaky test ledger_story_model_storage_unittest\n\nTEST\u003dnone\nFLK-30 #done\n\nChange-Id: I861a0252575d9b31d320fa9a0a701cf454485dd0\n" }, { "commit": "a5c817d4e2f0f21b68a7974fce0e822d369d2cbe", "tree": "46e4a0fab239c9f019866739700c9d4a30352db4", "parents": [ "76c4db769d498b01ca5650ca97a35403d1a8b33d" ], "author": { "name": "Bryan Henry", "email": "bryanhenry@google.com", "time": "Tue Jan 15 14:47:51 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Wed Jan 16 00:28:55 2019 +0000" }, "message": "[test_driver] Get EnvironmentController when creating environment\n\nEnvironmentController is being made a required argument for\nCreateNestedEnvironment in fxr/241175. This helps ensure that\nEnvironments aren\u0027t abandoned unintenionally and never cleaned up,\nespecially in tests.\n\nTest: Build \u0026 CQ (though the topaz_modular_integration_tests that use this\nseem to be disabled at the moment)\n\nChange-Id: I17b5c155ccc863a0ec3b34b516a5f763af2b7ce2\n" }, { "commit": "76c4db769d498b01ca5650ca97a35403d1a8b33d", "tree": "53caf4bd62d343007920291d54836f0798b00a9d", "parents": [ "0e585d990f7eb062f80d2c75a74a399b604a6148" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Sat Jan 05 22:46:46 2019 -0800" }, "committer": { "name": "Gabe Schine", "email": "thatguy@google.com", "time": "Wed Jan 16 00:02:49 2019 +0000" }, "message": "[modular][storage] Don\u0027t store ModuleManifest in ModuleData.\n\nWe stored ModuleManifest in ModuleData so that we could eventually send\nit to the StoryShell. Instead of doing that, we can look it up right\nbefore sending a Module\u0027s info to the StoryShell and thus remove a\nnumber of unnecessarily locations depending on ModuleFacetReader.\n\nNow, we always use the ModuleFacetReader to get our ModuleManifest.\n\nTEST\u003dexisting\n\nChange-Id: If7043b9663571241e28da7f8efd2a4f365a1f7a1\n" }, { "commit": "0e585d990f7eb062f80d2c75a74a399b604a6148", "tree": "e061b341c436886fa9f15c641baca607b55679fc", "parents": [ "b9c08f677c93fe295b51057ab62d3f85e16cf76b" ], "author": { "name": "Bryan Henry", "email": "bryanhenry@google.com", "time": "Tue Jan 15 14:19:32 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Jan 15 23:02:05 2019 +0000" }, "message": "[maxwell_integration] Get EnvironmentController when creating environment in StartAgent\n\nEnvironmentController is being made a required argument for\nCreateNestedEnvironment in fxr/241175. This helps ensure that\nEnvironments aren\u0027t abandoned unintenionally and never cleaned up,\nespecially in tests.\n\nThis also refactors AgentLauncher::StartAgent out bin/sessionmgr, since it\nis not actually used by sessionmgr currently, and into\ntests/maxwell_integration\u0027s base test class, MaxwellTestBase.\n\nTest: fx run-test maxwell_integration_tests (although it seems like\nStartAgent might be dead code even in this test anyway...)\n\nChange-Id: I0588b56b78b7d0464a3b7d15ab17e9c2a4aec5bd\n" }, { "commit": "b9c08f677c93fe295b51057ab62d3f85e16cf76b", "tree": "d1c8402dbc5c15366a7af2b8f065c8ef45850172", "parents": [ "3069b57a18e860f4da80e2556031ab4b3ca68b93" ], "author": { "name": "Andrew Davies", "email": "awdavies@google.com", "time": "Tue Jan 08 17:39:22 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Jan 15 22:15:51 2019 +0000" }, "message": "[test_driver_module] Add CMX file.\n\nCMX file was missing.\n\nDX-710 #comment\n\nTEST: Running disabled topaz integration tests.\n\nChange-Id: Id461bf4764faa972140f4fe9bb5fc866f2df837c\n" }, { "commit": "3069b57a18e860f4da80e2556031ab4b3ca68b93", "tree": "2bda71a6486e82d08312040380761bf2d33f65b6", "parents": [ "a9da1fb31c4effe774b6ee625cd44436c4f5bc3d" ], "author": { "name": "Yegor Pomortsev", "email": "ypomortsev@google.com", "time": "Mon Jan 14 13:06:06 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Jan 15 18:48:30 2019 +0000" }, "message": "[modular][fostr] Remove hand-written FIDL formatters\n\nAlso migrate some tests to component packages so they can load shared\nlibraries in their package.\n\nTest: N/A\nMF-34 #comment [modular][fostr] Remove hand-written FIDL formatters\n\nChange-Id: If6b973c7d88af6e17a3b1d1a7b8d184dae4b81ce\n" }, { "commit": "a9da1fb31c4effe774b6ee625cd44436c4f5bc3d", "tree": "75fe96becd7e51751f6c2c2a7843e1c08f7cdc2f", "parents": [ "d64ebc7b869d71e78e1734ef0a6d492ef4769412" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Sat Jan 05 15:40:17 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Jan 15 01:22:31 2019 +0000" }, "message": "[modular][storycontroller] Remove implementation of StartContainerInShell().\n\nThis is deprecated \u0026 has a single client (an example app in topaz/).\n\nTEST\u003dnone\n\nChange-Id: I700624fe5913ada448aa7c0032b8a7bc91e376fc\n" }, { "commit": "d64ebc7b869d71e78e1734ef0a6d492ef4769412", "tree": "d26805063173d9d19bfbfc40b98c177e55f37e86", "parents": [ "a093bb833406767c46afcb1f58d173fcf1efae46" ], "author": { "name": "Kevin Lindkvist", "email": "lindkvist@google.com", "time": "Mon Jan 14 15:59:22 2019 -0800" }, "committer": { "name": "Kevin Lindkvist", "email": "lindkvist@google.com", "time": "Mon Jan 14 16:36:01 2019 -0800" }, "message": "[intent] Remove links from intents\n\nThis removes the link-based intent parameters.\n\nMF-6 #done\nTESTED\u003dExisting tests.\n\nChange-Id: Icc56d62dbc4fa2938fafa3afb768bb336761d02b\n" }, { "commit": "a093bb833406767c46afcb1f58d173fcf1efae46", "tree": "0aec297e13f0f5f723dc44352a5a47dd79e641ab", "parents": [ "dd8a3e7ca2dfa677f8591f4c1390305f8faa8846" ], "author": { "name": "Kevin Lindkvist", "email": "lindkvist@google.com", "time": "Mon Jan 14 15:43:27 2019 -0800" }, "committer": { "name": "Kevin Lindkvist", "email": "lindkvist@google.com", "time": "Mon Jan 14 15:43:27 2019 -0800" }, "message": "[link_data] Remove link_data integration test\n\nLink passing between modules is being removed, and this test only\nexercises the link-based parameter passing. There are other existing\ntests which cover passing parameters back and forth between modules.\n\nMF-6 #comment Remove link_data integration test\nTESTED\u003dN/A\n\nChange-Id: I0bf32a2e00388e605c9fb1eb8ed485a289888d2a\n" }, { "commit": "dd8a3e7ca2dfa677f8591f4c1390305f8faa8846", "tree": "aa25c2ede5c1dbcbd08516f490f171018b07704b", "parents": [ "17c51470704e2c3de2582061f3469ad8abe84d39" ], "author": { "name": "Kevin Lindkvist", "email": "lindkvist@google.com", "time": "Mon Jan 14 15:20:53 2019 -0800" }, "committer": { "name": "Kevin Lindkvist", "email": "lindkvist@google.com", "time": "Mon Jan 14 15:25:06 2019 -0800" }, "message": "[module_resolver] Remove context observation\n\nRemove the proposal publishing based on context.\n\nThis doesn\u0027t belong in module resolver and is currently unused.\n\nTESTED\u003dExisting tests.\nMF-6 #comment Remove context observation\n\nChange-Id: I15b92beac356880ab937f876353958d2e09a18f6\n" }, { "commit": "17c51470704e2c3de2582061f3469ad8abe84d39", "tree": "3419f922715fad114d5f844873b6c10641321d56", "parents": [ "3d07d5d3d29eb5d7b8fc4de83ff2a476fdbbb75c" ], "author": { "name": "Christopher Johnson", "email": "crjohns@google.com", "time": "Mon Jan 14 11:25:42 2019 -0800" }, "committer": { "name": "Christopher Johnson", "email": "crjohns@google.com", "time": "Mon Jan 14 11:45:46 2019 -0800" }, "message": "[inspect] Do not explicitly require inspect FIDL.\n\nTEST\u003druntests\nCF-207: #progress\n\nChange-Id: I5efea0ded7ad3e9d9056199d492ac21ba202d0cb\n" }, { "commit": "3d07d5d3d29eb5d7b8fc4de83ff2a476fdbbb75c", "tree": "9150c1b51b7b761aed979b98a617a58f37cd470f", "parents": [ "d7e825de59d09778e27fbe3a99b324f9e76041d4" ], "author": { "name": "Ian McKellar", "email": "ianloic@google.com", "time": "Sat Jan 12 09:22:33 2019 -0800" }, "committer": { "name": "Ian McKellar", "email": "ianloic@google.com", "time": "Sat Jan 12 09:22:33 2019 -0800" }, "message": "[build] A trivial whitespace change to see if the roller is un-stuck\n\nTEST\u003dCQ\n\nChange-Id: Ibc9eac13bfce4a037f9a9982ed9969f7930c40aa\n" }, { "commit": "d7e825de59d09778e27fbe3a99b324f9e76041d4", "tree": "e8d28c07870cc7678ef93deec064d7e8b60a6b89", "parents": [ "545b929bafc3a6b7369acddb86cc696a3c630bc2" ], "author": { "name": "Ian McKellar", "email": "ianloic@google.com", "time": "Wed Dec 26 19:40:29 2018 -0800" }, "committer": { "name": "Ian McKellar", "email": "ianloic@google.com", "time": "Thu Jan 10 17:14:16 2019 -0800" }, "message": "[fidl][cpp] Use std:: types for non-nullable strings and vectors.\n\nSee: https://fuchsia-review.googlesource.com/c/garnet/+/236996\n\nTest: built everything, booted system and poked around\n\nChange-Id: I97ef4a0cc6970339bf1665d0b915fd618f43d947\n" }, { "commit": "545b929bafc3a6b7369acddb86cc696a3c630bc2", "tree": "7c330b76c8b7a21368d5405fa292b5fbd4355fe9", "parents": [ "89bd357a5e4cfb88b478f6a0c3d898f5e74a826b" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Wed Dec 26 15:49:52 2018 -0800" }, "committer": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Thu Jan 10 16:20:03 2019 -0800" }, "message": "[sessionmgr][refactor] Implement Ledger-backed storage.\n\nThis stores only those fields in StoryModel in use right now:\nruntime_state and visibility_state. They are stored in a device-local\nprefix of the page.\n\nNote that this will replace most if not all of StoryStorage entirely\nonce all of its data has been migrated into StoryModel.\n\nTEST\u003dledger_story_model_storage_unittest\nMF-152 #comment [sessionmgr][refactor] Implement Ledger-backed storage.\n\nChange-Id: Ia96e581aaa633abb3b9c90e907be18dac1772e75\n" }, { "commit": "89bd357a5e4cfb88b478f6a0c3d898f5e74a826b", "tree": "e893ad9cf4f49e6068746c7c265084ff72710c18", "parents": [ "65672cb7acfc8ffde0bf77514838974b5f3147a5" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Thu Jan 10 12:51:52 2019 -0800" }, "committer": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Thu Jan 10 16:20:03 2019 -0800" }, "message": "[modular][promise] Add more documentation and example to ledger_client fit::promise wrappers.\n\nTEST\u003dnone\n\nChange-Id: I807e3b4d64516fb15c2cdc47b5d6da9efc9b27e8\n" }, { "commit": "65672cb7acfc8ffde0bf77514838974b5f3147a5", "tree": "5df48564401c6d4724f286b3308282b3e79f6482", "parents": [ "f499fad839b667fb855c752b3661e6284d6ec9fd" ], "author": { "name": "Kevin Lindkvist", "email": "lindkvist@google.com", "time": "Wed Jan 09 10:40:19 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 10 23:47:23 2019 +0000" }, "message": "[chain] Remove chain tests\n\nThe link-setting behavior is deprecated, and this is part of removing clients.\n\nTESTED\u003dN/A\nMF-6 #comment Remove chain test\n\nChange-Id: I9f4188384e94cd5facf9b4c133f2879baf829b46\n" }, { "commit": "f499fad839b667fb855c752b3661e6284d6ec9fd", "tree": "b36e42cea9394493c985e523431e6316a46ec969", "parents": [ "c73cf3142ee1fd4855f7a27fdc5b6aefd7f9e6ff" ], "author": { "name": "Kevin Lindkvist", "email": "lindkvist@google.com", "time": "Wed Jan 09 10:46:23 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 10 23:09:42 2019 +0000" }, "message": "[links] Remove link passing tests\n\nLinks are being removed, and this is a step towards being able to\nremove the associated FIDL API.\n\nTESTED\u003dN/A\nMF-6 #comment Remove link passing tests\n\nChange-Id: I11aa89798741f836461b5c41a7e59ea493a0530d\n" }, { "commit": "c73cf3142ee1fd4855f7a27fdc5b6aefd7f9e6ff", "tree": "ea7f24b6bc813606a2b06ee3cd37413f9d98d0bb", "parents": [ "718160d4f1fc8354de2bd666c054704e5c372d3d" ], "author": { "name": "Kevin Lindkvist", "email": "lindkvist@google.com", "time": "Mon Dec 17 16:03:57 2018 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 10 22:58:43 2019 +0000" }, "message": "[docs] Add updated modular documentation\n\nThis includes updated documentation for:\n * Agents\n * Modules\n * Shells\n * Stories\n * Entities\n * Intents\n\nIt also provides an overview page.\n\nNot all of the documentation is equally well fleshed out, and future\nchanges are in the works.\n\nTESTED\u003dN/A\nMF-86 #done\nChange-Id: Id777b6b39b6ed88535de7390fe27aba57ec5564b\n" }, { "commit": "718160d4f1fc8354de2bd666c054704e5c372d3d", "tree": "5b94754221d9c52b17538143228be7a012a8d48b", "parents": [ "0578ff4525691e01aa1667da8399f34e111feb73" ], "author": { "name": "Bryan Henry", "email": "bryanhenry@google.com", "time": "Wed Jan 09 19:22:49 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 10 22:46:02 2019 +0000" }, "message": "[puppet_master] Switch from InterfacePtr::Close(zx_status_t) to Unbind()\n\nClose(zx_status_t) is being removed since epitaphs are only meant to be\nsent from server to client.\n\nTest: fx run-test puppet_master_unittests\nChange-Id: Iecb582d425e23fed8ef4c6229967f18e7b259f3a\n" }, { "commit": "0578ff4525691e01aa1667da8399f34e111feb73", "tree": "1e8b02801bbe3f3e7259f67c14848a409936312d", "parents": [ "4b6c2794ec4407fef57b4690b92963f94711c35c" ], "author": { "name": "Adam Barth", "email": "abarth@google.com", "time": "Thu Jan 10 12:52:18 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 10 21:58:36 2019 +0000" }, "message": "[component] Migrate to CreateFromStartupInfo()\n\nCreateFromStartupInfoNotChecked is being replaced with\nCreateFromStartupInfo.\n\nTest: Updates tests to new library interface.\nChange-Id: Ibb2ac10928d207dbd906dbb96214be0725fb50e7\n" }, { "commit": "4b6c2794ec4407fef57b4690b92963f94711c35c", "tree": "67b21c2e76112bde1b82ecf0587607567a149f6f", "parents": [ "a66890e977045535eb874614ac340a82770b4c64" ], "author": { "name": "Adam Barth", "email": "abarth@google.com", "time": "Thu Jan 10 12:55:40 2019 -0800" }, "committer": { "name": "Adam Barth", "email": "abarth@google.com", "time": "Thu Jan 10 21:17:55 2019 +0000" }, "message": "[basemgr] Remove call to has_environment_services()\n\nAll components have environment services now.\n\nTest: Removes unreachable code.\n\nChange-Id: I1546d38206e445e3633db28db3b5e253c85112b8\n" }, { "commit": "a66890e977045535eb874614ac340a82770b4c64", "tree": "591d93e482ffaf5bbed4895182b26292f4a4a83e", "parents": [ "08ad0db98c910535f710d38f0680de62b699bcfc" ], "author": { "name": "Kevin Lindkvist", "email": "lindkvist@google.com", "time": "Tue Jan 08 10:46:00 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Wed Jan 09 19:00:37 2019 +0000" }, "message": "[puppet_master] Reomve UpdateMod command\n\nThis is using links in intents, which are being removed. The same\nfunctionality can also be achieved by using the AddMod command.\n\nTESTED\u003dN/A\nMF-6 #comment Remove UpdateMod command\n\nChange-Id: I8ffdae69bbf5096be77db5a0a2fa83dd44a97f7b\n" }, { "commit": "08ad0db98c910535f710d38f0680de62b699bcfc", "tree": "7b8304825aa61c309f47a9a2ebfe2212e7f1edbd", "parents": [ "0c943c8b8b2ae366adfde1923afbec060ba531d6" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Wed Jan 02 18:01:39 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Wed Jan 09 17:58:13 2019 +0000" }, "message": "[ledger_client] Add fit::promise\u003c\u003e wrappers for some common Ledger API calls.\n\nThese wrappers turn various Page and PageSnapshot calls into\nfit::promise\u003c\u003e equivalents. Where a ledger.Status is returned, an OK\nstatus is translated into an ok() result, and any other value is\ntranslated into an error() result.\n\nTEST\u003dfuture CLs exercise these methods\n\nChange-Id: I556cb1267edad4d0284a16c9e3b07def71837dc2\n" }, { "commit": "0c943c8b8b2ae366adfde1923afbec060ba531d6", "tree": "171b0a62a8fd9bb12a3468fa3717cc866aa15e36", "parents": [ "c85b3a1bfb6d4981d483c88dbcfcf22acce33ffe" ], "author": { "name": "Nelly Vouzoukidou", "email": "nellyv@google.com", "time": "Wed Jan 09 10:41:07 2019 +0100" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Wed Jan 09 12:45:06 2019 +0000" }, "message": "[ledger] Avoid calling IsDirectoryAt twice, when getting a LevelDb.\n\nLedgerStorageImpl::GetPageStorage would check if the directory at the\ngiven path existed, in order to return NOT_FOUND if necessary. It would\nthen call DbFactory::GetOrCreateDb, which checked again if the directory\nexists.\n\nIn this CL DbFactory::GetOrCreateDb is updated to support only getting\nan existing Db, and fail with NOT_FOUND status if it doesn\u0027t exist.\nThis helps remove the extra call to IsDirectoryAt in LedgerStorageImpl.\n\nTest: LevelDbFactoryTest.*\nChange-Id: I6b97615179ceae2347e9403b17177f44ee4e1112\n" }, { "commit": "c85b3a1bfb6d4981d483c88dbcfcf22acce33ffe", "tree": "dcbb3fb455702f08683ef86f79e305cedd0a5ac1", "parents": [ "305241b8db3851bd9cca488eac28e49785e007c2" ], "author": { "name": "Alex Min", "email": "alexmin@google.com", "time": "Mon Jan 07 12:35:35 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Wed Jan 09 00:19:22 2019 +0000" }, "message": "[modular] Add build flag auto_login_to_guest_user for skipping login.\n\n- Also remove auto_login flag which is default behavior for all session\nshells.\n\nUsage: specify --args\u003dauto_login_to_guest\u003dtrue in fx set\n\nMF-160 #done\nTESTED: manual testing\n\nChange-Id: I5dfcb7cb69c11bc48a8e4186a01d4db67b773898\n" }, { "commit": "305241b8db3851bd9cca488eac28e49785e007c2", "tree": "c888a18ccea6559b1bea88b640a4624532930367", "parents": [ "00adc3b399b737adeb95073418416cffbdf7f102" ], "author": { "name": "Nelly Vouzoukidou", "email": "nellyv@google.com", "time": "Tue Jan 08 11:22:29 2019 +0100" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Jan 08 10:58:12 2019 +0000" }, "message": "[ledger] Test that watch notifications are aggregated.\n\nLE-661 #done\n\nTest: PageWatcherIntegrationTest.PageWatcherAggregatedNotifications\nChange-Id: Icfd27e45d390c6186fe2cabad1c7f97540d47d0f\n" }, { "commit": "00adc3b399b737adeb95073418416cffbdf7f102", "tree": "69126327ab51fd1de25aa9ec86e2a1fa973f3076", "parents": [ "531cd086eb93fd79119476d5e2c4d488b8287773" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Mon Jan 07 16:21:45 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Jan 08 06:25:39 2019 +0000" }, "message": "[modular][fostr] Adjust deps for modular fostr BUILD.gn defs\n\nTEST\u003dnone\n\nChange-Id: I055c987dd3e050d50fc1c949aba188bf77814870\n" }, { "commit": "531cd086eb93fd79119476d5e2c4d488b8287773", "tree": "a173ebc2352e0c5d4baaf1a952bb5c0e658a9344", "parents": [ "c2455a912762f388f11be6467b5fd9ec85c15be4" ], "author": { "name": "Steffen Meschkat", "email": "mesch@google.com", "time": "Tue Dec 18 15:09:33 2018 -0800" }, "committer": { "name": "Steffen Meschkat", "email": "mesch@google.com", "time": "Mon Jan 07 15:11:27 2019 -0800" }, "message": "[session_shell] Remove StoryController.Start().\n\nConvert remaining places to use StoryController.RequestStart():\n\n* session_shell integration test,\n* dev_session_shell,\n* modular benchmarks.\n\nCollateral cleanup:\n\n* Convert benchmark config to use fuchsia-pkg URLs.\n* Simplify type parameters in requests for environment services.\n* Simplify passing FIDL service pointers to watcher implementations.\n\nTESTED\u003drun_modular_benchmarks.sh\n\nMF-121 #comment Remove StoryController.Start().\nMF-121 #done\n\nChange-Id: I40f9572acc14bfc5545dbca9246c4bfcd05cb4c1\n" }, { "commit": "c2455a912762f388f11be6467b5fd9ec85c15be4", "tree": "f06c011c94f759df4448d32e90a4da1887c13911", "parents": [ "04674b6a6f73226508658665caccd5f91a83a334" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Sat Jan 05 12:53:58 2019 -0800" }, "committer": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Sat Jan 05 13:47:59 2019 -0800" }, "message": "[modular][story_controller] Remove unused StoryModulesWatcher.\n\nThis was optionally passed to StoryController.GetActiveModules(), but was not used\nby any clients (they all passed null).\n\nTEST\u003dexisting\n\nChange-Id: If2f98a1281e95bc3d0d9e9428530e3aa6da5d88f\n" }, { "commit": "04674b6a6f73226508658665caccd5f91a83a334", "tree": "ae187e13888b559c00715986f549b5bc7ac500c5", "parents": [ "26b8124b0ff7e31c1ed377f1288ae3c07718a3fd" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Wed Jan 02 16:52:06 2019 -0800" }, "committer": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Fri Jan 04 18:43:15 2019 -0800" }, "message": "[modular][storymodel] Add StoryModelStorage.Load() and .Flush()\n\nTEST\u003dexisting\n\nChange-Id: Iaddbde3b8e2042a11c29fe6033b0ccf02d068a0d\n" }, { "commit": "26b8124b0ff7e31c1ed377f1288ae3c07718a3fd", "tree": "66039cdbf26078e92bed2a540eb12d5d708ec2c9", "parents": [ "63ac08437fef44db061f40627ef3a73465c29404" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Fri Dec 28 15:41:04 2018 -0800" }, "committer": { "name": "Gabe Schine", "email": "thatguy@google.com", "time": "Sat Jan 05 01:31:36 2019 +0000" }, "message": "[modular][storymodel] Improve ergonomics of constructing a TestMutator.\n\nTEST\u003dfx run-test story_visibility_system_unittest\n\nChange-Id: I2732c06d81696117c06ff339f655c1b1c4960d12\n" }, { "commit": "63ac08437fef44db061f40627ef3a73465c29404", "tree": "8ddf37b682d817441615aa958973ff9c394cf27f", "parents": [ "cb8b7b8515faebe25ab0262e04aaba8d96e9cc23" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Fri Dec 28 15:08:18 2018 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Sat Jan 05 01:27:57 2019 +0000" }, "message": "[modular][storymodel] Break test support classes/macros into their own files.\n\nThis extracts gmock matchers and TestMutator (a StoryMutator impl) into\ntheir own files for other tests to take advantage of.\n\nTEST\u003dfx run-test story_visibility_system_unittest\n\nChange-Id: I77aceccc66b19698d883edd8c449a746a3717f68\n" }, { "commit": "cb8b7b8515faebe25ab0262e04aaba8d96e9cc23", "tree": "1cbb92c1e6434623253b8f547fd5fd8fe549b207", "parents": [ "d299e2aa6be53214ec6ceb1d8b597883a6cbe7c0" ], "author": { "name": "Leo Lung", "email": "leolung@google.com", "time": "Fri Jan 04 13:26:31 2019 -0800" }, "committer": { "name": "Leo Lung", "email": "leolung@google.com", "time": "Fri Jan 04 15:02:44 2019 -0800" }, "message": "[fuchsia-pkg] Mark bare package url packages\n\nTESTED\u003dcq\n\nChange-Id: I8359c7d6eca11b4859a7d789694a653e0c79f311\n" }, { "commit": "d299e2aa6be53214ec6ceb1d8b597883a6cbe7c0", "tree": "68765a97202438b2080b04e0f74213966e512177", "parents": [ "da0e0b7e7f9dac38b5eecac39e9670bfd87d20aa" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Wed Dec 26 15:47:58 2018 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 04 20:03:57 2019 +0000" }, "message": "[sessionmgr][refactor] ApplyMutations() switch{} no longer has default.\n\nThis makes it a compile error, not a runtime error, when a new\nStoryModelMutation command is introduced without updating\nApplyMutations().\n\nTEST\u003dapply_mutations_unittest\n\nChange-Id: I7141093c446dd5409661995745c3c8bf3e167627\n" }, { "commit": "da0e0b7e7f9dac38b5eecac39e9670bfd87d20aa", "tree": "587d04b60d8ae249a1c086f766732cc58ed999f5", "parents": [ "0107ad95266c472c033f6848b3d0013d019f7bc0" ], "author": { "name": "liuchao", "email": "liuchao741@huawei.com", "time": "Wed Jan 02 20:03:07 2019 +0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 04 19:07:47 2019 +0000" }, "message": "[doc] Fix typo in doc and comment\n\nTEST\u003dNone.\n\nChange-Id: I08df16b2905580fdda20243e0c5e12db9523b82e\n" }, { "commit": "0107ad95266c472c033f6848b3d0013d019f7bc0", "tree": "a9863932c265ee396c5a86e9886009970ca1ea2d", "parents": [ "2ff9eaeb2b3b919756a416789231e8212e323b51" ], "author": { "name": "Gabe Schine", "email": "thatguy@google.com", "time": "Fri Jan 04 18:02:03 2019 +0000" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 04 18:33:27 2019 +0000" }, "message": "Revert \"[scenic] SessionMgr now uses eventpairs\"\n\nThis reverts commit 3142417d8b8615c51887a9d9bc3281406809a1d1.\n\nReason for revert: Breaks mods being displayed in Ermine.\n\nOriginal change\u0027s description:\n\u003e [scenic] SessionMgr now uses eventpairs\n\u003e\n\u003e TEST: set_root_view perspective; Ran SysUI\n\u003e SCN-897 #comment\n\u003e SCN-1033 #comment\n\u003e\n\u003e Change-Id: I18d57c41081912c8fcd2d6277854d1d401068399\n\nMF-162 #done\nTBR\u003dmikejurka@google.com,thatguy@google.com,jaeheon@google.com,dworsham@google.com\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nChange-Id: I6333cf8170a523ed769377ffaf77fa482e293af7\n" }, { "commit": "2ff9eaeb2b3b919756a416789231e8212e323b51", "tree": "1b8636bd42bb68951d36ce6439b2158c02e7ec7b", "parents": [ "c20d8ca424deeede0a137d7682031e629bb023ac" ], "author": { "name": "Gabe Schine", "email": "thatguy@google.com", "time": "Fri Jan 04 18:01:39 2019 +0000" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 04 18:01:59 2019 +0000" }, "message": "Revert \"[scenic] basemgr now uses eventpairs\"\n\nThis reverts commit 8cb213b8614816bc043d813dcc499cf4dcc49731.\n\nReason for revert: Breaks mods being displayed in Ermine.\n\nOriginal change\u0027s description:\n\u003e [scenic] basemgr now uses eventpairs\n\u003e \n\u003e TEST: set_root_view perspective; Ran SysUI\n\u003e SCN-897 #comment\n\u003e SCN-1033 #comment\n\u003e \n\u003e Change-Id: Ifceddb01cfdae8c7524c93bc0d940f879d4c4004\n\nTBR\u003dmikejurka@google.com,thatguy@google.com,jaeheon@google.com,dworsham@google.com,alexmin@google.com\n\nChange-Id: I6fbc9792d0ba398be18153441b000951ecf500c3\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\n" }, { "commit": "c20d8ca424deeede0a137d7682031e629bb023ac", "tree": "2033a1bcc6955ad0e9df11ee076ed6d10ff552dc", "parents": [ "207fe3e55eb3f11e31bbcc09a8741642052f0067" ], "author": { "name": "Jean-François Geyelin", "email": "jif@google.com", "time": "Thu Jan 03 19:01:43 2019 +0100" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 04 12:22:58 2019 +0000" }, "message": "[cleanup] Fix conversion of string to array.\n\nAlso add a comment pointing to a more efficient alternative to\nmodular::to_array.\n\nTEST\u003dNo functional change.\n\nChange-Id: I073ca615d3abea4fc2273fe3263e262749531470\n" }, { "commit": "207fe3e55eb3f11e31bbcc09a8741642052f0067", "tree": "19cabfee2b375539fee71ee9270fca1541613fee", "parents": [ "8cb213b8614816bc043d813dcc499cf4dcc49731" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Fri Dec 21 17:47:21 2018 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 04 00:45:40 2019 +0000" }, "message": "[sessionmgr][refactor] Use StoryModel for StoryState.\n\nTEST\u003drun_modular_tests.sh\nMF-149 #done\n\nChange-Id: I31f2cf585cc22ce5d62755c9c983e465caf20fa0\n" }, { "commit": "8cb213b8614816bc043d813dcc499cf4dcc49731", "tree": "ab9bc97d063c8019fe28e350a70ff562fcd9c366", "parents": [ "ca5ffff6f90d53742e346e226a49460058e3606d" ], "author": { "name": "David Worsham", "email": "dworsham@google.com", "time": "Mon Dec 31 22:12:49 2018 -0500" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Jan 04 00:07:59 2019 +0000" }, "message": "[scenic] basemgr now uses eventpairs\n\nTEST: set_root_view perspective; Ran SysUI\nSCN-897 #comment\nSCN-1033 #comment\n\nChange-Id: Ifceddb01cfdae8c7524c93bc0d940f879d4c4004\n" }, { "commit": "ca5ffff6f90d53742e346e226a49460058e3606d", "tree": "649172dd2f4fa74740116bc308944bbc57504908", "parents": [ "11721e798c13394eeb5164da2ae18c41f2fb6731" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Thu Jan 03 10:36:59 2019 -0800" }, "committer": { "name": "Gabe Schine", "email": "thatguy@google.com", "time": "Thu Jan 03 23:56:04 2019 +0000" }, "message": "[modular][sessionctl] Look for the component-version of basemgr.\n\nAlso:\n* Print a nicer error when we can\u0027t find a basemgr instance in the first\nplace.\n\nTEST\u003dmanual\nMF-158 #done\nMF-158 #comment [modular][sessionctl] Look for the component-version of basemgr.\n\nChange-Id: I52aaa91fe6e6aa8f25dc7af588f7d1b1c4e502e4\n" }, { "commit": "11721e798c13394eeb5164da2ae18c41f2fb6731", "tree": "9387e7614692ba5de9c1794095e5ded699130f0e", "parents": [ "cce3dd8b719c1d06526262fae1e5de5a9e921256" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Wed Jan 02 21:33:05 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 03 22:28:51 2019 +0000" }, "message": "[sessionmgr][refactor] Use StoryModel/Systems for StoryVisibilityState.\n\nAlso:\n* Use pass-through NoopStoryModelStorage, which will be in use\nuntil we implement a ledger-backed system and after that whenever we\ndon\u0027t want a particular story in the ledger.\n* Plumb everything into StoryControllerImpl and StoryProviderImpl.\n* Simplify StoryProviderImpl.NotifyStoryStateChange()\n\nIn this change you can see how trivial policy logic (when a Module\nrequests to change the story visibility state, should we honor it?) is\nbroken out into its own system and unit-tested in isolation of other\nclasses.\n\nTEST\u003dstory_runtime_unittest,story_visibility_system_unittest,integration tests\n\nMF-89 #comment [sessionmgr][refactor] Use StoryModel for StoryVisibilityState.\nMF-106 #comment [sessionmgr][refactor] Use StoryModel for StoryVisibilityState.\nMF-106 #done\n\nChange-Id: I8263288cb442ee27a7e3a297947a4ef4399a1cf8\n" }, { "commit": "cce3dd8b719c1d06526262fae1e5de5a9e921256", "tree": "1ff522c46babcc07330bd30ded1c1e8b04e17fa3", "parents": [ "3142417d8b8615c51887a9d9bc3281406809a1d1" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Wed Jan 02 21:30:54 2019 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 03 21:57:11 2019 +0000" }, "message": "[sessionmgr][refactor] Add NoopStoryModelStorage.\n\nThis is a \"pass-through\" storage system, or otherwise one which does not\npersist anything to disk. It essentially treats the StoryModel as one\nthat is stored only in memory.\n\nTEST\u003dtrivial class exercised in future CLs\nMF-89 #comment [sessionmgr][refactor] Add NoopStoryModelStorage.\n\nChange-Id: I1cac4be50f24bc73f0cf89a608cba2ebaccf3f47\n" }, { "commit": "3142417d8b8615c51887a9d9bc3281406809a1d1", "tree": "d31c9fe12b8576075b5b6780b44b33e6193718a6", "parents": [ "292c8d30352bfce3ae7c91464d28eafd19048650" ], "author": { "name": "David Worsham", "email": "dworsham@google.com", "time": "Sun Dec 30 21:17:26 2018 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 03 17:50:13 2019 +0000" }, "message": "[scenic] SessionMgr now uses eventpairs\n\nTEST: set_root_view perspective; Ran SysUI\nSCN-897 #comment\nSCN-1033 #comment\n\nChange-Id: I18d57c41081912c8fcd2d6277854d1d401068399\n" }, { "commit": "292c8d30352bfce3ae7c91464d28eafd19048650", "tree": "51e7708d7898ec6c20f78455ab38b61bbb46736c", "parents": [ "ccd6360738a8385d2b6b2a7a971daf9c5993fdbc" ], "author": { "name": "Benjamin Lerman", "email": "qsr@chromium.org", "time": "Thu Jan 03 17:22:43 2019 +0100" }, "committer": { "name": "Benjamin Lerman", "email": "qsr@chromium.org", "time": "Thu Jan 03 17:22:43 2019 +0100" }, "message": "[ledger] Remove unused member.\n\nTEST\u003dEverything still compiles, Tests still pass.\n\nChange-Id: I067ddec34698b30623fab7e16db835826a01db66\n" }, { "commit": "ccd6360738a8385d2b6b2a7a971daf9c5993fdbc", "tree": "c887a1f7ab4173353da806441a366b2bb1446f77", "parents": [ "9926c19336c0032a6ab859ae76cf34578d3242cc" ], "author": { "name": "Jean-François Geyelin", "email": "jif@google.com", "time": "Thu Jan 03 14:24:19 2019 +0100" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 03 14:11:53 2019 +0000" }, "message": "[ledger][testing] Don\u0027t exit instance provider.\n\n`exit` was an (incorrect) attempt to prevent the instance provider from\nbeing alive too long.\nNow, the instance provider is expected to be cleaned-up by the Component\nController with which it is launched.\n\nTEST\u003dRun tests that uses the instance provider.\nNotice that `fx shell ps | grep ledger | wc -l` returns 0.\n\nChange-Id: Iaed522d3fce5a8b2c588f76a525ec4b196bce518\n" }, { "commit": "9926c19336c0032a6ab859ae76cf34578d3242cc", "tree": "2f39cf8fda1e5df69374d1ce076380109587bac1", "parents": [ "98f3f9715aaa9467715b93d7ed27a78af951e8bd" ], "author": { "name": "Benjamin Lerman", "email": "qsr@chromium.org", "time": "Thu Jan 03 12:00:48 2019 +0100" }, "committer": { "name": "Benjamin Lerman", "email": "qsr@chromium.org", "time": "Thu Jan 03 12:00:48 2019 +0100" }, "message": "[ledger] Fix use-after-move warning from clang-tidy\n\nThe code was in fact correct because the moved token is replaced by the\nCapture afterwards, but it is better to please clang-tidy, and doesn\u0027t\ncost us more than a pointer move.\n\nLE-660 #done\n\nTEST\u003dclang-tidy is not complaining anymore.\n\nChange-Id: I14826ae7557b7e48662975e2bf8f2d722dce1230\n" }, { "commit": "98f3f9715aaa9467715b93d7ed27a78af951e8bd", "tree": "334a53ee4b7cb1522b013f9abd4879a48d9e66cc", "parents": [ "32d801d184ad31de25a18f916dd265e94bda4de2" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Wed Jan 02 21:33:42 2019 -0800" }, "committer": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Wed Jan 02 21:34:07 2019 -0800" }, "message": "[cleanup] While reading the code.\n\nFix extra newline in a comment.\n\nTEST\u003dnone\n\nChange-Id: Ia921953012bd2de1dab07c8181a3d2ee027d0bdb\n" }, { "commit": "32d801d184ad31de25a18f916dd265e94bda4de2", "tree": "8c82adf9c15c9cd9c4c9a770914d7749b89d5ba3", "parents": [ "ecc95d46ec7acabad66cb5c6ab4b6b0368e53a35" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Fri Dec 28 12:17:29 2018 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 03 01:45:43 2019 +0000" }, "message": "[modular][storymodel] Don\u0027t notify observers when the StoryModel doesn\u0027t change.\n\nTEST\u003dfx run-test story_model_owner_unittest\n\nChange-Id: I66d86e9675764d78d8b221ae63c6461663f7e23d\n" }, { "commit": "ecc95d46ec7acabad66cb5c6ab4b6b0368e53a35", "tree": "ef1aa2b1dc439935cbac717dd4fecb647a628974", "parents": [ "cc6a2b5df11024f0bdf26b4710a28162d45be807" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Thu Dec 27 17:21:48 2018 -0800" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Jan 03 01:44:53 2019 +0000" }, "message": "[cleanup] While reading code.\n\nFormat per style apply_mutations.h\n\nTEST\u003dnone\n\nChange-Id: Ib47622068f46cb0c8c78cf59d72b199aaa6a42c7\n" }, { "commit": "cc6a2b5df11024f0bdf26b4710a28162d45be807", "tree": "e35ab59f610f67551b516fe7b7d25ade3ffc5f03", "parents": [ "05f056f8361b0fa7c64c3fa658ebfc3828f8f1b5" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Wed Dec 26 16:04:26 2018 -0800" }, "committer": { "name": "Gabe Schine", "email": "thatguy@google.com", "time": "Thu Jan 03 01:44:21 2019 +0000" }, "message": "[cleanup] While reading the code.\n\nFix comment typo in story_storage.cc\n\nTEST\u003dnone\n\nChange-Id: Ie98980356aee95a9f0fbcb08053308598a34e017\n" }, { "commit": "05f056f8361b0fa7c64c3fa658ebfc3828f8f1b5", "tree": "da2e00f719207f3058b51bc2238400ab617684ad", "parents": [ "e7ea2b2ac2da392292d2f74d7b48dc7c38864f06" ], "author": { "name": "Gabriel Schine", "email": "thatguy@google.com", "time": "Wed Dec 26 15:12:59 2018 -0800" }, "committer": { "name": "Gabe Schine", "email": "thatguy@google.com", "time": "Thu Jan 03 01:43:33 2019 +0000" }, "message": "[cleanup][device_info] While reading the code.\n\n* Add comments for methods in device_info.h\n* Remove obsolete TODOs and FIXMEs in the .cc\n\nTEST\u003dnone (no code changes)\n\nChange-Id: I530c539a14bbe7f1533354c85f2d102d8de94ae3\n" } ], "next": "e7ea2b2ac2da392292d2f74d7b48dc7c38864f06" }