| commit | ff5d94b658d45fc5c9dec3e9b4c26e5182a588ba | [log] [tgz] |
|---|---|---|
| author | Alex Zaslavsky <azaslavsky@fuchsia.infra.roller.google.com> | Wed Jun 09 00:03:07 2021 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Jun 08 17:04:27 2021 -0700 |
| tree | 64204161f2e679b08172dbfe7590674fb5b4e087 | |
| parent | 9f6d2153578f10776eb37743ed525040dd55c7ef [diff] |
[roll] Roll fuchsia [fidlfmt] Implement struct formatting in the new fidlfmt
This change also takes care to validate that formatting works as
expected for nested structs.
Additionally, a number of other small issues have been fixed:
* `FooMinimalWhitespace` tests have been added for each type. These
are basically the opposite of the `FooMaximalNewlines` tests,
validating that formatting is correct even when the input text is
one long, minimally spaced line.
* The `MaybeAddBlankLinesAfterStandaloneComment` helper function has
been added in the interest of making the code a bit easier to read.
It is also now called in a couple of new areas, fixing previously
"forgotten" trailing newlines on some standalone comments.
* TODOs have been left in places where the implementation of
fxbug.dev/77861 will provide a prettier output.
* Finally, a bug in the LayoutMember(s) raw AST visitors has been
fixed.
Test: fidldev test fidlc
Original-Bug: 73507
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/539179
Original-Revision: a67ac94fbf3937b37ac8c2f11c5cd45f7ff75fd0
GitOrigin-RevId: c781d20103b8657ca6759e781fa33f00251c47ac
Change-Id: Ifd08824e64d55316e0687eeae46bbcafbee7d5c5
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.