| commit | ff18642a82d6ccb50e0a06ff670b6ec3791b5bcc | [log] [tgz] |
|---|---|---|
| author | Thomas Gales <tgales@fuchsia.infra.roller.google.com> | Thu Sep 29 01:46:37 2022 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Sep 28 18:48:21 2022 -0700 |
| tree | ddfbc5900dcc21ea67e93db845f35e715816856d | |
| parent | 6e490d09a6e98e4e94d3a920a2435129b2faa81b [diff] |
[roll] Roll fuchsia [forensics] Fix snapshot garbage collection Previously, SnapshotCollector was responsible for telling SnapshotStore which snapshots to potentially garbage collect. However, https://fuchsia-review.googlesource.com/c/fuchsia/+/724768 changed SnapshotCollector to only hold onto snapshot requests until snapshot generation is complete. Because of this, SnapshotCollector was only trying to garbage collect snapshots which did not exist yet. This resulted in 2 potential problems: 1. No actual snapshot garbage collection was happening 2. Crashes could occur if SnapshotCollector attempted garbage collection while there were still other pending snapshot requests To mitigate this, SnapshotStore will now do its own garbage collection when a new snapshot is added. Original-Fixed: 110601 TESTED='fx test //src/developer/forensics' TESTED='fx shell crasher' @ 5589f41e59a5054d Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/732562 Original-Revision: d3156e88c27f3367f62a7a439e5771a49b39a667 GitOrigin-RevId: d34db0977037f2850f17912cd45485de2007a39d Change-Id: I269a45eb335ee1b9b02f48de36f90ff84ea85437
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.