| commit | fc9ee4eeb76dccbd83709fdfc3863563464edea2 | [log] [tgz] |
|---|---|---|
| author | Kyle Gong <kgong@fuchsia.infra.roller.google.com> | Tue Jan 07 11:33:12 2025 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Jan 07 11:35:45 2025 -0800 |
| tree | 87fb2feb54070c0e50897791280c8ef8a07b4307 | |
| parent | 1e2dfb9780b580563b94ab247a4ed2cb2ecc3d6c [diff] |
[roll] Roll fuchsia Reland "[power][broker] Drop redundant claims immediately" This reverts commit 752a5848ff630363b8ab08623f7db3f74f6f23e8. Reason for revert: Fixed issue with redundant claims * Restricts claims to being dropped only if a claim in another still open lease still requires the claim's required level or higher. (Previously it was possible for this check to see a claim within the same lease, which was already in the process of being dropped). * Adds test_broker_lease_shared_required_element to cover this case. Original change's description: > Revert "[power][broker] Drop redundant claims immediately" > > This reverts commit 8dc348384a1fbeff1f1794639eeb52368a17cb11. > > Reason for revert: This is a likely cause of b/383894169 and > b/380463683. See https://fxrev.dev/1173774 for a possible > fix, which will instead be incorporated into a reland. > > Original change's description: > > [power][broker] Drop redundant claims immediately > > > > * Before this change, Power Broker deferred dropping claims > > until after their required elements dropped below their > > required levels. However, for elements with lots of > > overlapping leases that don't actually change their level, > > this resulted in a large number of dormant claims > > piling up, increasing memory usage and processing > > time for computing required levels. > > * Instead of requiring the required element actually lower > > its level, this now looks at other claims to see if > > it is redundant--there is another assertive activated > > claim whose required level satisfies the former's > > required level. If so, this claim can be safely dropped > > immediately. > > * Add test_broker_lease_redundant_claims to exercise this > > scenario. > > * Verified through tracing that this reduces the number of > > outstanding claims: > > Before: https://screenshot.googleplex.com/6Yf4mCJ6Vq6kpnf > > After: https://screenshot.googleplex.com/4FxiQe8dUadu72c > > > > Original-Bug: b/375447941 > > > > Change-Id: I14b0053df0ad3cbc4b0622ed6fdc1318dfd1c23c > > Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1152302 > > Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com> > > Reviewed-by: Prashanth Swaminathan <prashanthsw@google.com> > > Fuchsia-Auto-Submit: Kyle Gong <kgong@google.com> > > Original-Bug: b/375447941 > Change-Id: Icb3284e2b70c009b3af02bebde90df071159f2ff > Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1175755 > Fuchsia-Auto-Submit: Onath Dillinger <claridge@google.com> > Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com> > Reviewed-by: Didi She <didis@google.com> Original-Bug: b/383894169 Original-Bug: b/380463683 Original-Bug: b/375447941 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1177893 Original-Revision: 73e5e5afb110d27982739b1b51db8911dd395049 GitOrigin-RevId: ba0d6615bf564d9a6757cc3b088d4447213cf767 Change-Id: I6dec598577e036d57f09a0613bada32404dad22e
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance in one of the communication channels documented at get involved.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.