commit ebf5945318a4b8f4e0b6094c8540844d0cf18166
author David 'Digit' Turner <digit@fuchsia.infra.roller.google.com> Wed Jan 10 22:43:42 2024 +0000
committer Copybara-Service <copybara-worker@google.com> Wed Jan 10 14:45:12 2024 -0800
tree d51b7a8441387a4287166be15e282868d1ddab26
parent 2fac99cdf3dd3c6bdf910c9d42837fe5ef01e7d4

[roll] Roll fuchsia [bazel_sdk][tests] Fix Python3 runtime dependencies.

This CL fixes how python-based tests are generated by ensuring
that they use the current Python toolchain runtime, instead of
blinding relying on `python3` being available in PATH, which failed
when these tests are run remotely, on builders which do not have
it installed.

This fixes 17 failing tests when running
`fx build bazel_sdk_tests_x64` with
`enable_bazel_remote_rbe = true` in args.gn.

This is done in the following way:

- py_test_utils.bzl: Ensure the definition of the `_py_toolchain`
  attribute within PY_TOOLCHAIN_DEPS includes a `providers` list
  that allows access to the current PyRuntimeInfo provider.

  Provide create_python3_shell_wrapper_provider(), which will
  generate a DefaultInfo value for the generated launcher
  shell script, and associated runtime requirements.

  The PyRuntimeInfo is accessed there, to ensure that the
  generated script invokes the resolved Python3 executable,
  and that the runfiles will include the runtime's own
  files as well. This ensures that the test can run remotely.

  Remove the obsolete populate_py_test_sh_script() function.

- json_validator.bzl: Add create_validation_script_provider()
  that uses create_python3_shell_wrapper_provider() under the
  hood, and which also returns a DefaultInfo value.

  Remote the obsolete create_validation_script() function.

- Update all callers of populate_py_test_sh_script() or
  create_validation_script() to use
  create_python3_shell_wrapper_provider() or
  create_validation_script_provider(), respectively.

+ make_file.bzl: Minor formatting fix.

- fuchsia/licenses/review/BUILD.bazel,
  tools/licenses/BUILD.bazel: Add `tags = [ "no-remote" ]`
  to ensure these py_test() targets are always run
  locally, as running them remotely fails because the
  runfiles do not export the python toolchain files
  correctly (see b/319458863 for details), an issue
  that will be addressed separately.

Original-Bug: b/317291511
Original-Bug: b/319458863
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/971994
Original-Revision: e4a0a979fee9e330241e37859074c7b6a7ad2cdb
GitOrigin-RevId: f4460d66810e5058fe9cfea6e50a411a16197354
Change-Id: Iedddf2cb96a34b6ee3c1603265bd7387b8bb3378