| commit | e6575ed5e2977a3d35e9f29fd72af8ef8518cb5c | [log] [tgz] |
|---|---|---|
| author | Daniel Dougherty <doughertyda@fuchsia.infra.roller.google.com> | Fri Oct 29 23:44:06 2021 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Oct 29 16:45:12 2021 -0700 |
| tree | d85db0d002503c889d9a36ef79e2e48c1abec53e | |
| parent | 3f33f4e6fa509e10d4d6145672e49bb54556c5ab [diff] |
[roll] Roll fuchsia [ffx] Fix flake in ffx_emulator_common_lib_test The test for download_and_extract has been flaking for some time, because it actually calls out to CIPD and downloads and extracts a file multiple times on each invocation. To stop this, this CL mocks out the actual downloading and extraction, and just tests the code in HostTools which coordinates the calls to CIPD. We use the mockall and async_trait crates to define a new trait and implementing struct around the existing CIPD code, then mock the CIPD functions for the test. The mocks never make http calls, or extract any files; rather we just ensure the calls themselves are made, and that the HostTools code reacts correctly according to the return values of those calls. By removing the test's dependency on CIPD and the network, we expect this will resolve the flakiness entirely. Original-Bug: 85945 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/599074 Original-Revision: f32816c9a69a437fcea86c1f7299377b5d25d653 GitOrigin-RevId: 8572f58c5b2964b45149da2695892840a220112d Change-Id: Iad9b7ac98a491f2cb9eea57bbd3ab402d9e88f0a
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.